html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3042#issuecomment-505645069,https://api.github.com/repos/pydata/xarray/issues/3042,505645069,MDEyOklzc3VlQ29tbWVudDUwNTY0NTA2OQ==,5635139,2019-06-25T22:22:59Z,2019-06-25T22:22:59Z,MEMBER,@jukent I don't think that's our bot,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505621145,https://api.github.com/repos/pydata/xarray/issues/3042,505621145,MDEyOklzc3VlQ29tbWVudDUwNTYyMTE0NQ==,5635139,2019-06-25T21:01:22Z,2019-06-25T21:01:22Z,MEMBER,Those look great!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505611145,https://api.github.com/repos/pydata/xarray/issues/3042,505611145,MDEyOklzc3VlQ29tbWVudDUwNTYxMTE0NQ==,46687291,2019-06-25T20:32:33Z,2019-06-25T20:32:33Z,CONTRIBUTOR,"> @jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130
> 
> You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result.
> 
> Ping back with any issues

Thanks @max-sixty. I added some very simple tests. I might copy more of the test_rename functions (if I tried to rename a variable to the same name for example)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505555118,https://api.github.com/repos/pydata/xarray/issues/3042,505555118,MDEyOklzc3VlQ29tbWVudDUwNTU1NTExOA==,24736507,2019-06-25T17:59:27Z,2019-06-25T20:30:26Z,NONE,"Hello @jukent! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`xarray/core/dataset.py`](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/core/dataset.py):

> [Line 2217:9](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/core/dataset.py#L2217): [F841](https://duckduckgo.com/?q=pep8%20F841) local variable 'coord_names' is assigned to but never used
> [Line 2313:5](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/core/dataset.py#L2313): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)
> [Line 2344:58](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/core/dataset.py#L2344): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 2349:5](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/core/dataset.py#L2349): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)
> [Line 2382:5](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/core/dataset.py#L2382): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)

* In the file [`xarray/tests/test_dataset.py`](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py):

> [Line 2115:32](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2115:37](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:40](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:42](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:46](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:50](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2115:55](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:59](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:62](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:67](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2115:71](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2115): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2116:32](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2116:41](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:44](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:46](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:50](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:54](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2116:63](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:67](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:70](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:75](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2116:79](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2116:80](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2116): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (83 > 79 characters)
> [Line 2117:25](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2117): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2122:32](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2122:37](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:40](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:42](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:46](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:50](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2122:55](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:59](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:62](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:67](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2122:71](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2122): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2123:36](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2123:41](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:44](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:46](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:50](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:54](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2123:59](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:63](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:66](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:71](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 2123:75](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2123): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'
> [Line 2124:25](https://github.com/pydata/xarray/blob/babf193b518e6263d641cbf6d40640b690a0ba17/xarray/tests/test_dataset.py#L2124): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ':'



##### Comment last updated at 2019-06-25 20:30:26 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505604339,https://api.github.com/repos/pydata/xarray/issues/3042,505604339,MDEyOklzc3VlQ29tbWVudDUwNTYwNDMzOQ==,5635139,2019-06-25T20:13:25Z,2019-06-25T20:13:25Z,MEMBER,"@jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130

You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result.

Ping back with any issues","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505599777,https://api.github.com/repos/pydata/xarray/issues/3042,505599777,MDEyOklzc3VlQ29tbWVudDUwNTU5OTc3Nw==,46687291,2019-06-25T20:00:01Z,2019-06-25T20:00:01Z,CONTRIBUTOR,"> > #3026
> > There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.
> 
> Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.

This works now! But to do so I created three different renaming variable helper functions (var name only, var and dims, var dims only). I will clean this up since the majority of these three functions is the same.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505598969,https://api.github.com/repos/pydata/xarray/issues/3042,505598969,MDEyOklzc3VlQ29tbWVudDUwNTU5ODk2OQ==,46687291,2019-06-25T19:57:36Z,2019-06-25T19:57:36Z,CONTRIBUTOR,"> And tbc, we should add tests here. That will help clarify the issues above re exactly which items on the dataset each method should rename vs leave.

Yes I need to add tests, but I don't have much experience with this yet. I will ask my team here to help me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505596702,https://api.github.com/repos/pydata/xarray/issues/3042,505596702,MDEyOklzc3VlQ29tbWVudDUwNTU5NjcwMg==,5635139,2019-06-25T19:51:09Z,2019-06-25T19:51:09Z,MEMBER,"And tbc, we should add tests here. That will help clarify the issues above re exactly which items on the dataset each method should rename vs leave.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505594770,https://api.github.com/repos/pydata/xarray/issues/3042,505594770,MDEyOklzc3VlQ29tbWVudDUwNTU5NDc3MA==,5635139,2019-06-25T19:45:53Z,2019-06-25T19:45:53Z,MEMBER,This is great! Thanks @jukent ! Ping back here if there's anything we can do to help,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505587938,https://api.github.com/repos/pydata/xarray/issues/3042,505587938,MDEyOklzc3VlQ29tbWVudDUwNTU4NzkzOA==,46687291,2019-06-25T19:26:43Z,2019-06-25T19:26:43Z,CONTRIBUTOR,"> #3026
> 
> There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.

Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505569846,https://api.github.com/repos/pydata/xarray/issues/3042,505569846,MDEyOklzc3VlQ29tbWVudDUwNTU2OTg0Ng==,46687291,2019-06-25T18:38:25Z,2019-06-25T18:38:25Z,CONTRIBUTOR,"pydata#3026

There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436