html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3013#issuecomment-510127083,https://api.github.com/repos/pydata/xarray/issues/3013,510127083,MDEyOklzc3VlQ29tbWVudDUxMDEyNzA4Mw==,2448579,2019-07-10T16:09:29Z,2019-07-10T16:09:29Z,MEMBER,Thanks @ecarrara !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-509772022,https://api.github.com/repos/pydata/xarray/issues/3013,509772022,MDEyOklzc3VlQ29tbWVudDUwOTc3MjAyMg==,22429695,2019-07-09T19:18:05Z,2019-07-09T19:27:19Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3013?src=pr&el=h1) Report
> Merging [#3013](https://codecov.io/gh/pydata/xarray/pull/3013?src=pr&el=desc) into [master](https://codecov.io/gh/pydata/xarray/commit/681893ed96685052e5f5822cc867245aaf138b32?src=pr&el=desc) will **increase** coverage by `0.49%`.
> The diff coverage is `75%`.
```diff
@@ Coverage Diff @@
## master #3013 +/- ##
==========================================
+ Coverage 92.16% 92.66% +0.49%
==========================================
Files 63 63
Lines 12787 12795 +8
Branches 2906 2910 +4
==========================================
+ Hits 11785 11856 +71
+ Misses 688 622 -66
- Partials 314 317 +3
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-509769620,https://api.github.com/repos/pydata/xarray/issues/3013,509769620,MDEyOklzc3VlQ29tbWVudDUwOTc2OTYyMA==,1217238,2019-07-09T19:11:44Z,2019-07-09T19:11:44Z,MEMBER,I fixed up the merge. Let's just make sure tests pass...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-501651662,https://api.github.com/repos/pydata/xarray/issues/3013,501651662,MDEyOklzc3VlQ29tbWVudDUwMTY1MTY2Mg==,24736507,2019-06-13T10:47:12Z,2019-07-09T19:11:29Z,NONE,"Hello @ecarrara! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2019-07-09 19:11:28 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-506409703,https://api.github.com/repos/pydata/xarray/issues/3013,506409703,MDEyOklzc3VlQ29tbWVudDUwNjQwOTcwMw==,2448579,2019-06-27T16:05:31Z,2019-06-27T16:05:31Z,MEMBER,OK let's remove the mask_flag_enums bits then. I noticed that there's a binary .idx file that was added to. Is that needed?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-501892946,https://api.github.com/repos/pydata/xarray/issues/3013,501892946,MDEyOklzc3VlQ29tbWVudDUwMTg5Mjk0Ng==,2448579,2019-06-13T21:54:11Z,2019-06-13T21:54:11Z,MEMBER,"Yeah I think @ecarrara found a workaround.
@ecarrara You should also add a note to whats-new and give yourself credit.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-501884771,https://api.github.com/repos/pydata/xarray/issues/3013,501884771,MDEyOklzc3VlQ29tbWVudDUwMTg4NDc3MQ==,10050469,2019-06-13T21:25:32Z,2019-06-13T21:25:32Z,MEMBER,"Thanks @ecarrara !
> but the TestRasterio::test_serialization fails
This is not the case anymore, right? This test is here to ensure that the dataarrays we are creating with `open_rasterio` are compatible with the NetCDF model. I think it is good to try to keep it that way.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-501075199,https://api.github.com/repos/pydata/xarray/issues/3013,501075199,MDEyOklzc3VlQ29tbWVudDUwMTA3NTE5OQ==,191850,2019-06-12T00:37:24Z,2019-06-12T00:37:24Z,CONTRIBUTOR,"thank you @dcherian!
I added `offsets`, `units`, `descriptions` attributes. The other attributes (`res`, `nodata`, `crs`, `transform`, `bounds` and `res`) were already available.
`mask_flag_enums` is a list of tuples, I have tried to add this attribute too but the `TestRasterio::test_serialization` fails with the message:
```python
> ???
E ValueError: multi-dimensional array attributes not supported
netCDF4/_netCDF4.pyx:1529: ValueError
```
@fmaussion any feedback is welcome!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-501030000,https://api.github.com/repos/pydata/xarray/issues/3013,501030000,MDEyOklzc3VlQ29tbWVudDUwMTAzMDAwMA==,2448579,2019-06-11T21:28:20Z,2019-06-11T21:28:20Z,MEMBER,"I think we should read and expose all those attributes.
@ecarrara are you up for expanding the scope of your PR? Also, I see you're a ""first-time contributor"". Welcome! and thanks for contributing!
ping @fmaussion for feedback.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-501014979,https://api.github.com/repos/pydata/xarray/issues/3013,501014979,MDEyOklzc3VlQ29tbWVudDUwMTAxNDk3OQ==,191850,2019-06-11T20:42:37Z,2019-06-11T20:42:37Z,CONTRIBUTOR,"> Does rasterio define a set of valid attributes or can you assign arbitrary attributes? If so, should we read and assign all attributes as we do for netCDF files?
@dcherian the attributes are pre-defined. Looking at the source code[1] of rasterio I found this list:
```property nodatavals # Nodata values for each band
property nodata # The dataset's single nodata value
property mask_flag_enums # Sets of flags describing the sources of band masks.
property crs # The dataset's coordinate reference system
property descriptions # Descriptions for each dataset band
property transform # The dataset's georeferencing transformation matrix
property offsets # Raster offset for each dataset band
property scales # Raster scale for each dataset band
property units # A list of str: one units string for each dataset band
property bounds # Returns the lower left and upper right bounds of the dataset
property res # Returns the (width, height) of pixels in the units of its
```
I belive that the attributes not handled yet by xarray are: **scales, offsets and units**.
[1] - https://github.com/mapbox/rasterio/blob/1.0.24/rasterio/_base.pyx","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592
https://github.com/pydata/xarray/pull/3013#issuecomment-500872911,https://api.github.com/repos/pydata/xarray/issues/3013,500872911,MDEyOklzc3VlQ29tbWVudDUwMDg3MjkxMQ==,2448579,2019-06-11T14:41:18Z,2019-06-11T14:41:18Z,MEMBER,"Does rasterio define a set of valid attributes or can you assign arbitrary attributes? If so, should we read and assign all attributes as we do for netCDF files?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454337592