html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2987#issuecomment-497971124,https://api.github.com/repos/pydata/xarray/issues/2987,497971124,MDEyOklzc3VlQ29tbWVudDQ5Nzk3MTEyNA==,5635139,2019-06-01T19:23:03Z,2019-06-01T19:23:03Z,MEMBER,"LMK if good to merge!
(coming from the person with a terrible record of finishing PRs... 😉 )","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143
https://github.com/pydata/xarray/pull/2987#issuecomment-496971365,https://api.github.com/repos/pydata/xarray/issues/2987,496971365,MDEyOklzc3VlQ29tbWVudDQ5Njk3MTM2NQ==,5635139,2019-05-29T14:52:49Z,2019-05-29T14:52:49Z,MEMBER,Great - I added `rmatmul` and a v short example in the basic-array-math section. LMK if good to merge,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143
https://github.com/pydata/xarray/pull/2987#issuecomment-495738823,https://api.github.com/repos/pydata/xarray/issues/2987,495738823,MDEyOklzc3VlQ29tbWVudDQ5NTczODgyMw==,24736507,2019-05-24T18:14:25Z,2019-05-29T14:52:29Z,NONE,"Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2019-05-29 14:52:29 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143
https://github.com/pydata/xarray/pull/2987#issuecomment-496667122,https://api.github.com/repos/pydata/xarray/issues/2987,496667122,MDEyOklzc3VlQ29tbWVudDQ5NjY2NzEyMg==,1217238,2019-05-28T20:01:50Z,2019-05-28T20:01:50Z,MEMBER,"It might be worth using @ instead of dot() in the docs in a few places, but
I don't think it's essential to mention it specifically.
On Tue, May 28, 2019 at 12:36 PM Deepak Cherian
wrote:
> Do we need a line here?
> https://xarray.pydata.org/en/stable/computation.html#basic-array-math
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143
https://github.com/pydata/xarray/pull/2987#issuecomment-496658267,https://api.github.com/repos/pydata/xarray/issues/2987,496658267,MDEyOklzc3VlQ29tbWVudDQ5NjY1ODI2Nw==,2448579,2019-05-28T19:36:45Z,2019-05-28T19:36:45Z,MEMBER,Do we need a line here? https://xarray.pydata.org/en/stable/computation.html#basic-array-math,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143
https://github.com/pydata/xarray/pull/2987#issuecomment-496635695,https://api.github.com/repos/pydata/xarray/issues/2987,496635695,MDEyOklzc3VlQ29tbWVudDQ5NjYzNTY5NQ==,1217238,2019-05-28T18:31:03Z,2019-05-28T18:31:03Z,MEMBER,"This looks good to me!
In general, it's a good idea to also define reflexive methods, e.g., `__rmatmul__` in this case. But I'm not sure we actually need that, given that `dot` only supports operations with xarray.DataArray at present.
I guess this could be useful for people writing subclasses, or other objects that override arithmetic with xarray objects. So you might as well add something like:
```
def __rmatmul__(self, other):
return xarray.dot(other, dot)
```","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143
https://github.com/pydata/xarray/pull/2987#issuecomment-496568423,https://api.github.com/repos/pydata/xarray/issues/2987,496568423,MDEyOklzc3VlQ29tbWVudDQ5NjU2ODQyMw==,5635139,2019-05-28T15:32:29Z,2019-05-28T15:32:29Z,MEMBER,"Any thoughts, team?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,448295143