html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2964#issuecomment-496043263,https://api.github.com/repos/pydata/xarray/issues/2964,496043263,MDEyOklzc3VlQ29tbWVudDQ5NjA0MzI2Mw==,1217238,2019-05-27T00:21:02Z,2019-05-27T00:21:02Z,MEMBER,Thanks @zdgriffith !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710
https://github.com/pydata/xarray/pull/2964#issuecomment-494514343,https://api.github.com/repos/pydata/xarray/issues/2964,494514343,MDEyOklzc3VlQ29tbWVudDQ5NDUxNDM0Mw==,1217238,2019-05-21T18:54:22Z,2019-05-21T18:54:22Z,MEMBER,"> Just to be totally explicit then changing `_auto_combine()` obviously means that `open_mfdataset()` will have an implicit default kwarg `fill_value='dtypes.NA'`, but if that's always the desired behaviour then that's fine.
This is the current default behavior for `open_mfdataset`. We could potentially had a `fill_value` option there, too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710
https://github.com/pydata/xarray/pull/2964#issuecomment-494512015,https://api.github.com/repos/pydata/xarray/issues/2964,494512015,MDEyOklzc3VlQ29tbWVudDQ5NDUxMjAxNQ==,35968931,2019-05-21T18:47:38Z,2019-05-21T18:47:53Z,MEMBER,"Yeah this looks fine to me - it basically bypasses all the complicated combining logic anyway.
Just to be totally explicit then changing `_auto_combine()` obviously means that `open_mfdataset()` will have an implicit default kwarg `fill_value='dtypes.NA'`, but if that's always the desired behaviour then that's fine.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710
https://github.com/pydata/xarray/pull/2964#issuecomment-494488275,https://api.github.com/repos/pydata/xarray/issues/2964,494488275,MDEyOklzc3VlQ29tbWVudDQ5NDQ4ODI3NQ==,1217238,2019-05-21T17:39:48Z,2019-05-21T17:39:48Z,MEMBER,This looks pretty safe to me. It's basically just threading down the `fill_value` argument.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710
https://github.com/pydata/xarray/pull/2964#issuecomment-494471201,https://api.github.com/repos/pydata/xarray/issues/2964,494471201,MDEyOklzc3VlQ29tbWVudDQ5NDQ3MTIwMQ==,2448579,2019-05-21T16:50:54Z,2019-05-21T16:50:54Z,MEMBER,:+1:. Mind giving this PR a review? You know this bit of the code well...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710
https://github.com/pydata/xarray/pull/2964#issuecomment-494468833,https://api.github.com/repos/pydata/xarray/issues/2964,494468833,MDEyOklzc3VlQ29tbWVudDQ5NDQ2ODgzMw==,35968931,2019-05-21T16:43:56Z,2019-05-21T16:43:56Z,MEMBER,Yeah I saw this - that's fine. Probably best to do them as separate commits though no? Just depends which one gets merged first. If we merge mine first then I'm happy to review/adapt this PR to be compatible. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710
https://github.com/pydata/xarray/pull/2964#issuecomment-494467365,https://api.github.com/repos/pydata/xarray/issues/2964,494467365,MDEyOklzc3VlQ29tbWVudDQ5NDQ2NzM2NQ==,2448579,2019-05-21T16:39:44Z,2019-05-21T16:39:44Z,MEMBER,@TomNicholas looks like you'll need to add `fill_value` to `combine_auto` and `combine_manual`?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,444510710