html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2941#issuecomment-498835498,https://api.github.com/repos/pydata/xarray/issues/2941,498835498,MDEyOklzc3VlQ29tbWVudDQ5ODgzNTQ5OA==,2448579,2019-06-04T20:41:44Z,2019-06-04T20:41:44Z,MEMBER,=). Thanks @jmccreight. Merging.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-489267577,https://api.github.com/repos/pydata/xarray/issues/2941,489267577,MDEyOklzc3VlQ29tbWVudDQ4OTI2NzU3Nw==,24736507,2019-05-03T23:13:41Z,2019-06-04T16:16:10Z,NONE,"Hello @jmccreight! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2019-06-04 16:16:07 UTC","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 1, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-494118496,https://api.github.com/repos/pydata/xarray/issues/2941,494118496,MDEyOklzc3VlQ29tbWVudDQ5NDExODQ5Ng==,12465248,2019-05-20T19:24:41Z,2019-05-20T19:24:41Z,CONTRIBUTOR,"🎊 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-494079089,https://api.github.com/repos/pydata/xarray/issues/2941,494079089,MDEyOklzc3VlQ29tbWVudDQ5NDA3OTA4OQ==,2448579,2019-05-20T17:27:28Z,2019-05-20T17:27:28Z,MEMBER,The failures seem unrelated. can you merge master and remove the warning?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-489828927,https://api.github.com/repos/pydata/xarray/issues/2941,489828927,MDEyOklzc3VlQ29tbWVudDQ4OTgyODkyNw==,12465248,2019-05-06T23:56:01Z,2019-05-06T23:56:01Z,CONTRIBUTOR,"There were easy patterns to follow for this, so I just went for it. @dcherian Are the failures fixable? I'm not sure what to make of them. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-489372622,https://api.github.com/repos/pydata/xarray/issues/2941,489372622,MDEyOklzc3VlQ29tbWVudDQ4OTM3MjYyMg==,2448579,2019-05-04T23:15:22Z,2019-05-04T23:15:22Z,MEMBER,"Thanks @jmccreight. That was quick. I think we can do without the warning but we should wait till someone else chimes in. Otherwise, this looks right to me but I don't know this bit of the code too well.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-489328948,https://api.github.com/repos/pydata/xarray/issues/2941,489328948,MDEyOklzc3VlQ29tbWVudDQ4OTMyODk0OA==,12465248,2019-05-04T13:51:22Z,2019-05-04T13:51:22Z,CONTRIBUTOR,"I should add that changing the encoding on the variable itself was not ""an easy detail"". The basic thing I tried was unsuccessful, so if this is desired some more work is needed.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754 https://github.com/pydata/xarray/pull/2941#issuecomment-489268054,https://api.github.com/repos/pydata/xarray/issues/2941,489268054,MDEyOklzc3VlQ29tbWVudDQ4OTI2ODA1NA==,12465248,2019-05-03T23:16:21Z,2019-05-03T23:16:21Z,CONTRIBUTOR,"I guess the additional documentation would go here. http://xarray.pydata.org/en/stable/io.html#writing-encoded-data If we decide to keep the ""gnarly"" warning message, we should probably do a bit of explaination here.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,440254754