html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2936#issuecomment-491091115,https://api.github.com/repos/pydata/xarray/issues/2936,491091115,MDEyOklzc3VlQ29tbWVudDQ5MTA5MTExNQ==,5635139,2019-05-09T22:31:01Z,2019-05-09T22:31:01Z,MEMBER,"Ah, thanks @pletchm , and @shoyer for spotting this I should have caught this - I didn't separately check the windows tests; I expected the same unrelated failures as on Travis and didn't consider this would be an area that would be different between platforms. Mea culpa. It's always the avenues you least suspect...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-491032096,https://api.github.com/repos/pydata/xarray/issues/2936,491032096,MDEyOklzc3VlQ29tbWVudDQ5MTAzMjA5Ng==,10720577,2019-05-09T19:19:12Z,2019-05-09T19:19:12Z,CONTRIBUTOR,"@shoyer, I spent sometime looking into it and it looks like the test fails for the shallow copy, and apparently only on Windows for some reason. In Windows coords seem to be immutable unless it's one dataarray deep copied from another (which is why only the `deep=False` test fails). So I decided to just mark the tests as `xfail` for now (but I'd be happy to create an issue and look into it more in the future). I'll open a new PR marking the tests with `xfail` shortly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-490969141,https://api.github.com/repos/pydata/xarray/issues/2936,490969141,MDEyOklzc3VlQ29tbWVudDQ5MDk2OTE0MQ==,1217238,2019-05-09T16:13:29Z,2019-05-09T16:13:29Z,MEMBER,"Don't worry about it, this happens. If you can't figure out an immediate fix, please just mark the tests as ""xfail"" so they don't block other PRs. I'm pretty sure the issue here is in the tests, not your fix. On Thu, May 9, 2019 at 9:08 AM Martin Pletcher wrote: > Sure. I'm looking into it now. > > Sorry about that. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > , or mute > the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-490967152,https://api.github.com/repos/pydata/xarray/issues/2936,490967152,MDEyOklzc3VlQ29tbWVudDQ5MDk2NzE1Mg==,10720577,2019-05-09T16:08:07Z,2019-05-09T16:08:07Z,CONTRIBUTOR,"Sure. I'm looking into it now. Sorry about that.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-490964929,https://api.github.com/repos/pydata/xarray/issues/2936,490964929,MDEyOklzc3VlQ29tbWVudDQ5MDk2NDkyOQ==,1217238,2019-05-09T16:02:07Z,2019-05-09T16:02:07Z,MEMBER,"It seems xarray (mistakenly?) relies on the immutability of index data somewhere else, and hence reuses the same pandas.Index object for data in both `data` and `coords`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-490963840,https://api.github.com/repos/pydata/xarray/issues/2936,490963840,MDEyOklzc3VlQ29tbWVudDQ5MDk2Mzg0MA==,1217238,2019-05-09T15:59:03Z,2019-05-09T15:59:03Z,MEMBER,"Can you take a look at the test failures on Windows? These seem to be due to your charge: ``` ================================== FAILURES =================================== ____________ TestDataArray.test_copy_coords[False-expected_orig1] _____________ self = deep = False expected_orig = array([999, 2]) Coordinates: * a (a) int32 999 2 @pytest.mark.parametrize('deep, expected_orig', [ [True, xr.DataArray(xr.IndexVariable('a', np.array([1, 2])), coords={'a': [1, 2]}, dims=['a'])], [False, xr.DataArray(xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a'])]]) def test_copy_coords(self, deep, expected_orig): da = xr.DataArray( np.ones([2, 2, 2]), coords={'a': [1, 2], 'b': ['x', 'y'], 'c': [0, 1]}, dims=['a', 'b', 'c']) da_cp = da.copy(deep) da_cp['a'].data[0] = 999 expected_cp = xr.DataArray( xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a']) > assert_identical(da_cp['a'], expected_cp) xarray\tests\test_dataarray.py:3342: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ a = array([1, 2]) Coordinates: * a (a) int32 1 2 b = array([999, 2]) Coordinates: * a (a) int32 999 2 def assert_identical(a, b): > xarray.testing.assert_identical(a, b) E AssertionError: Left and right DataArray objects are not identical E E Differing values: E L E array([1, 2]) E R E array([999, 2]) E Differing coordinates: E L * a (a) int32 1 2 E R * a (a) int32 999 2 xarray\tests\__init__.py:195: AssertionError _____________ TestDataset.test_copy_coords[False-expected_orig1] ______________ self = deep = False expected_orig = array([999, 2]) Coordinates: * a (a) int32 999 2 @pytest.mark.parametrize('deep, expected_orig', [ [True, xr.DataArray(xr.IndexVariable('a', np.array([1, 2])), coords={'a': [1, 2]}, dims=['a'])], [False, xr.DataArray(xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a'])]]) def test_copy_coords(self, deep, expected_orig): ds = xr.DataArray( np.ones([2, 2, 2]), coords={'a': [1, 2], 'b': ['x', 'y'], 'c': [0, 1]}, dims=['a', 'b', 'c'], name='value').to_dataset() ds_cp = ds.copy(deep=deep) ds_cp.coords['a'].data[0] = 999 expected_cp = xr.DataArray( xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a']) > assert_identical(ds_cp.coords['a'], expected_cp) xarray\tests\test_dataset.py:1993: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ a = array([1, 2]) Coordinates: * a (a) int32 1 2 b = array([999, 2]) Coordinates: * a (a) int32 999 2 def assert_identical(a, b): > xarray.testing.assert_identical(a, b) E AssertionError: Left and right DataArray objects are not identical E E Differing values: E L E array([1, 2]) E R E array([999, 2]) E Differing coordinates: E L * a (a) int32 1 2 E R * a (a) int32 999 2 xarray\tests\__init__.py:195: AssertionError ============================== warnings summary =============================== ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-490515211,https://api.github.com/repos/pydata/xarray/issues/2936,490515211,MDEyOklzc3VlQ29tbWVudDQ5MDUxNTIxMQ==,5635139,2019-05-08T14:44:32Z,2019-05-08T14:44:32Z,MEMBER,Thanks @pletchm !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-490147560,https://api.github.com/repos/pydata/xarray/issues/2936,490147560,MDEyOklzc3VlQ29tbWVudDQ5MDE0NzU2MA==,5635139,2019-05-07T16:14:15Z,2019-05-07T16:14:15Z,MEMBER,"Perfect @pletchm ! Sorry for the test failures on our end - we had some dependency issues. I'll merge tomorrow unless anyone has other comments.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-489878553,https://api.github.com/repos/pydata/xarray/issues/2936,489878553,MDEyOklzc3VlQ29tbWVudDQ4OTg3ODU1Mw==,10720577,2019-05-07T02:07:14Z,2019-05-07T02:07:14Z,CONTRIBUTOR,"Yep, the tests are back now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-489876173,https://api.github.com/repos/pydata/xarray/issues/2936,489876173,MDEyOklzc3VlQ29tbWVudDQ4OTg3NjE3Mw==,5635139,2019-05-07T01:55:01Z,2019-05-07T01:55:01Z,MEMBER,"Then it's fine! They'll be fixed separately. But did we lose the tests on this branch? Can we add those back?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-489818753,https://api.github.com/repos/pydata/xarray/issues/2936,489818753,MDEyOklzc3VlQ29tbWVudDQ4OTgxODc1Mw==,10720577,2019-05-06T23:05:20Z,2019-05-06T23:05:20Z,CONTRIBUTOR,"> @pletchm thanks for the PR! > > I think the test failuers are dependencies rather than your changes! I kicked off a build of master here: https://travis-ci.org/pydata/xarray/builds/524754660 to confirm - if it's the same failures then we'll know it's not this code Thanks for looking into this, @max-sixty! It looks like the errors are the same, so the problem is dependencies, right? How do we go about fixing that?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-488882173,https://api.github.com/repos/pydata/xarray/issues/2936,488882173,MDEyOklzc3VlQ29tbWVudDQ4ODg4MjE3Mw==,5635139,2019-05-03T00:57:23Z,2019-05-03T00:57:23Z,MEMBER,"@pletchm thanks for the PR! I think the test failuers are dependencies rather than your changes! I kicked off a build of master here: https://travis-ci.org/pydata/xarray/builds/524754660 to confirm - if it's the same failures then we'll know it's not this code","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329 https://github.com/pydata/xarray/pull/2936#issuecomment-488862083,https://api.github.com/repos/pydata/xarray/issues/2936,488862083,MDEyOklzc3VlQ29tbWVudDQ4ODg2MjA4Mw==,10720577,2019-05-02T23:00:07Z,2019-05-02T23:00:07Z,CONTRIBUTOR,"Tests and documentation forthcoming. I had already opened a PR, but was perplexed when the build and tests weren't passing -- suspected it was related to my commits.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,439823329