html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2929#issuecomment-505645154,https://api.github.com/repos/pydata/xarray/issues/2929,505645154,MDEyOklzc3VlQ29tbWVudDUwNTY0NTE1NA==,5635139,2019-06-25T22:23:21Z,2019-06-25T22:23:21Z,MEMBER,Thanks @crusaderky !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505640130,https://api.github.com/repos/pydata/xarray/issues/2929,505640130,MDEyOklzc3VlQ29tbWVudDUwNTY0MDEzMA==,1217238,2019-06-25T22:03:56Z,2019-06-25T22:03:56Z,MEMBER,Thanks @max-sixty and @crusaderky !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505630653,https://api.github.com/repos/pydata/xarray/issues/2929,505630653,MDEyOklzc3VlQ29tbWVudDUwNTYzMDY1Mw==,5635139,2019-06-25T21:31:36Z,2019-06-25T21:31:36Z,MEMBER,(AppVeyor fail looks unrelated),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-487667139,https://api.github.com/repos/pydata/xarray/issues/2929,487667139,MDEyOklzc3VlQ29tbWVudDQ4NzY2NzEzOQ==,24736507,2019-04-29T17:19:43Z,2019-06-25T18:14:47Z,NONE,"Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

























There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-06-25 18:14:47 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505533789,https://api.github.com/repos/pydata/xarray/issues/2929,505533789,MDEyOklzc3VlQ29tbWVudDUwNTUzMzc4OQ==,5635139,2019-06-25T17:02:37Z,2019-06-25T17:02:37Z,MEMBER,"> I was considering adding this into pep8speaks, but I think this fundamentally incompatible with pep8speak's design. It runs a handful of pre-specified linters, without actually installing/running user code. But something like mypy needs to actually have xarray and its dependencies installed to work.

Yes, good point. 

I haven't spent much time with the GitHub Checks, but potentially could be a good fit - one issue with the simpler ""Update the comment"" model is that it doesn't encode to GH whether it's safe to merge, so projects need to duplicate the test in CI","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505529733,https://api.github.com/repos/pydata/xarray/issues/2929,505529733,MDEyOklzc3VlQ29tbWVudDUwNTUyOTczMw==,1217238,2019-06-25T16:52:10Z,2019-06-25T16:52:10Z,MEMBER,"> > By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....
> 
> That would be v cool. I'm kinda surprised something like pep8speaks doesn't do this already tbh...

I was considering adding this into pep8speaks, but I think this fundamentally incompatible with pep8speak's design. It runs a handful of pre-specified linters, without actually installing/running user code. But something like mypy needs to actually have xarray and its dependencies installed to work.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505527575,https://api.github.com/repos/pydata/xarray/issues/2929,505527575,MDEyOklzc3VlQ29tbWVudDUwNTUyNzU3NQ==,5635139,2019-06-25T16:46:33Z,2019-06-25T16:46:33Z,MEMBER,"> By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....

That would be v cool. I'm kinda surprised something like pep8speaks doesn't do this already tbh...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505522494,https://api.github.com/repos/pydata/xarray/issues/2929,505522494,MDEyOklzc3VlQ29tbWVudDUwNTUyMjQ5NA==,1217238,2019-06-25T16:32:53Z,2019-06-25T16:32:53Z,MEMBER,"By the way, I think I can write a script based on pep8speaks that writes/updates GitHub comments from within from Travis or Azure Pipelines. We could use that for surfacing mypy results in pull requests. I will probably give that a try over the next few days....","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505496869,https://api.github.com/repos/pydata/xarray/issues/2929,505496869,MDEyOklzc3VlQ29tbWVudDUwNTQ5Njg2OQ==,5635139,2019-06-25T15:29:05Z,2019-06-25T15:29:05Z,MEMBER,"Ah it works! Didn't know permissions transferred to forks.

@crusaderky hope that's OK, not wanting to step on your toes here...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505484234,https://api.github.com/repos/pydata/xarray/issues/2929,505484234,MDEyOklzc3VlQ29tbWVudDUwNTQ4NDIzNA==,1217238,2019-06-25T14:59:36Z,2019-06-25T14:59:36Z,MEMBER,"@max-sixty do you want to push those changes to @crusaderky's branch? As a maintainer for xarray, I think you should have push permissions.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505274907,https://api.github.com/repos/pydata/xarray/issues/2929,505274907,MDEyOklzc3VlQ29tbWVudDUwNTI3NDkwNw==,5635139,2019-06-25T04:14:22Z,2019-06-25T04:20:40Z,MEMBER,"Great, I've resolved those comments @shoyer , thanks: https://github.com/max-sixty/xarray/tree/annotations

@crusaderky we should be ready to go - maybe take a glance over to ensure you're happy.

I added a whatsnew with both of us - hope that's OK","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505158224,https://api.github.com/repos/pydata/xarray/issues/2929,505158224,MDEyOklzc3VlQ29tbWVudDUwNTE1ODIyNA==,5635139,2019-06-24T20:02:54Z,2019-06-24T20:02:54Z,MEMBER,"Cool, I think it should be a straight fast-forward merge from my branch to yours, and then an easy merge to master","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505148315,https://api.github.com/repos/pydata/xarray/issues/2929,505148315,MDEyOklzc3VlQ29tbWVudDUwNTE0ODMxNQ==,6213168,2019-06-24T19:32:36Z,2019-06-24T19:32:36Z,MEMBER,Sorry I didn't have time last week - I'll try merging into the pr ASAP. I'm in favour of merging to mainline too,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505128139,https://api.github.com/repos/pydata/xarray/issues/2929,505128139,MDEyOklzc3VlQ29tbWVudDUwNTEyODEzOQ==,2448579,2019-06-24T18:34:40Z,2019-06-24T18:34:40Z,MEMBER,"> Thoughts on merging this now and continuing off master?

+1 else the merge conflicts will just pile up.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-505124409,https://api.github.com/repos/pydata/xarray/issues/2929,505124409,MDEyOklzc3VlQ29tbWVudDUwNTEyNDQwOQ==,5635139,2019-06-24T18:24:10Z,2019-06-24T18:24:10Z,MEMBER,"Just fixed some more merge conflicts over at https://github.com/max-sixty/xarray/tree/annotations. 

Thoughts on merging this now and continuing off master?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-504296594,https://api.github.com/repos/pydata/xarray/issues/2929,504296594,MDEyOklzc3VlQ29tbWVudDUwNDI5NjU5NA==,5635139,2019-06-21T05:37:55Z,2019-06-21T05:37:55Z,MEMBER,"@crusaderky I updated my branch slightly:
- Couple of merge conflicts
- Couple of issues around dict / OrderedDict. I tried to stay as close as possible while making the tests pass (I don't think I undid any of your most recent changes - if I did it was a mistake - feel free to modify)
- I wonder whether we should merge this and then continue; I worry we'll get a constant tax of merge conflicts given how many places this touches
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502502167,https://api.github.com/repos/pydata/xarray/issues/2929,502502167,MDEyOklzc3VlQ29tbWVudDUwMjUwMjE2Nw==,6213168,2019-06-17T01:04:17Z,2019-06-17T01:04:17Z,MEMBER,@max-sixty you can keep adding type info to all functions in dataset.py. I don't think I'll have time to touch it next week anyway... ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502486292,https://api.github.com/repos/pydata/xarray/issues/2929,502486292,MDEyOklzc3VlQ29tbWVudDUwMjQ4NjI5Mg==,5635139,2019-06-16T21:13:32Z,2019-06-16T21:13:32Z,MEMBER,"Great, thanks @crusaderky ! Let me know if I can do anything to help!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502465584,https://api.github.com/repos/pydata/xarray/issues/2929,502465584,MDEyOklzc3VlQ29tbWVudDUwMjQ2NTU4NA==,6213168,2019-06-16T16:15:57Z,2019-06-16T16:15:57Z,MEMBER,"@max-sixty I merged your branch in and did some tweaks to the OrderedDict's.
Now moving to add more typing info to dataset.py...","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502397112,https://api.github.com/repos/pydata/xarray/issues/2929,502397112,MDEyOklzc3VlQ29tbWVudDUwMjM5NzExMg==,6213168,2019-06-15T20:27:54Z,2019-06-15T20:27:54Z,MEMBER,@max-sixty thanks for the work! I'll go through it ASAP,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502302695,https://api.github.com/repos/pydata/xarray/issues/2929,502302695,MDEyOklzc3VlQ29tbWVudDUwMjMwMjY5NQ==,5635139,2019-06-14T22:45:05Z,2019-06-14T22:45:05Z,MEMBER,"@crusaderky I finished this off as best I could. Tests pass though needs a review. Here's the code: https://github.com/max-sixty/xarray/tree/annotations

(I tried pasting a patch, but I my git-fu isn't enough to exclude all the master code given there's a merge commit in there)

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-490589169,https://api.github.com/repos/pydata/xarray/issues/2929,490589169,MDEyOklzc3VlQ29tbWVudDQ5MDU4OTE2OQ==,1217238,2019-05-08T18:02:25Z,2019-05-08T18:02:25Z,MEMBER,"@crusaderky let's discuss that over in https://github.com/pydata/xarray/issues/2292. For now, I would try to defer making a decision on non-string dimension/variable names, even though that means we will have less informative type annotations.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-490325901,https://api.github.com/repos/pydata/xarray/issues/2929,490325901,MDEyOklzc3VlQ29tbWVudDQ5MDMyNTkwMQ==,6213168,2019-05-08T02:45:57Z,2019-05-08T02:45:57Z,MEMBER,"DataArray finished; unit tests (hopefully) successful. Will now move to Dataset.
Would appreciate an official, final decision from @shoyer et. al. on Hashable vs. str before I continue - also in light of all the hacks Hashable forced me to go through.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-487694226,https://api.github.com/repos/pydata/xarray/issues/2929,487694226,MDEyOklzc3VlQ29tbWVudDQ4NzY5NDIyNg==,5635139,2019-04-29T18:36:02Z,2019-04-29T18:36:02Z,MEMBER,"Thanks @crusaderky , this looks great!

Re: 

>Switching all variable names from str to Hashable. Without proper unit tests however (out of scope) non-string hashables are expected not work most of the times. My preference would still be to stay limited on str...

Curious on others' thoughts. I would vote to allow `Hashable` for data variable names in Datasets - similar to other `Mapping`s - but less so for dimension names in arrays. (Not opposed to it per se, open to instances where that would be helpful)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-487671110,https://api.github.com/repos/pydata/xarray/issues/2929,487671110,MDEyOklzc3VlQ29tbWVudDQ4NzY3MTExMA==,6213168,2019-04-29T17:30:26Z,2019-04-29T17:30:26Z,MEMBER,"One of the many reasons why I'm strongly against generic Hashables instead of strings is that I expect user code all over the world to have string-specific functions and methods applied to variable names and dimensions.
e.g.
```
[d for d in arr.dims if d.startswith('foo')]
```
The above will produce an error in mypy, and the user will be forced to either disable the test or verbosely convince mypy with a ``typing.cast`` that actually in his project he never uses non-string dims.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176