html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2924#issuecomment-506410362,https://api.github.com/repos/pydata/xarray/issues/2924,506410362,MDEyOklzc3VlQ29tbWVudDUwNjQxMDM2Mg==,2448579,2019-06-27T16:07:12Z,2019-06-27T16:07:12Z,MEMBER,Thanks @arabidopsis. Welcome to xarray!,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437956917 https://github.com/pydata/xarray/pull/2924#issuecomment-487297145,https://api.github.com/repos/pydata/xarray/issues/2924,487297145,MDEyOklzc3VlQ29tbWVudDQ4NzI5NzE0NQ==,24736507,2019-04-27T15:53:19Z,2019-06-27T16:06:21Z,NONE,"Hello @arabidopsis! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2019-06-27 16:06:21 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437956917 https://github.com/pydata/xarray/pull/2924#issuecomment-487331380,https://api.github.com/repos/pydata/xarray/issues/2924,487331380,MDEyOklzc3VlQ29tbWVudDQ4NzMzMTM4MA==,1217238,2019-04-28T01:08:08Z,2019-04-28T01:08:08Z,MEMBER,"> Just a question. I put a guard in to test just for tuples (because that's what was breaking for me) but it seems to me that `_nan_minmax_object` should just return `utils.to_0d_object_array(data)` > unconditionally at that point no? It's a max or a min right. > > Wasn't sure. Yes, it does seem like a good idea to just return `utils.to_0d_object_array()` unilaterally in this case.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437956917 https://github.com/pydata/xarray/pull/2924#issuecomment-487329592,https://api.github.com/repos/pydata/xarray/issues/2924,487329592,MDEyOklzc3VlQ29tbWVudDQ4NzMyOTU5Mg==,9948595,2019-04-28T00:21:15Z,2019-04-28T00:21:15Z,CONTRIBUTOR,"No problem. Thanks for xarray! Just a question. I put a guard in to test just for tuples (because that's what was breaking for me) but it seems to me that `_nan_minmax_object` should just return `utils.to_0d_object_array(data)` unconditionally at that point no? It's a max or a min right. Wasn't sure.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437956917 https://github.com/pydata/xarray/pull/2924#issuecomment-487325673,https://api.github.com/repos/pydata/xarray/issues/2924,487325673,MDEyOklzc3VlQ29tbWVudDQ4NzMyNTY3Mw==,1217238,2019-04-27T22:53:12Z,2019-04-27T22:53:12Z,MEMBER,"Awesome, thank you @arabidopsis! If you don't mind, it would be great if you could add a brief note about the bug fix to `whats-new.rst`. (if not, don't worry, I'll merge this in a few days either way) You can ignore the test failure on Python 3.5. Something else seems to be going wrong there.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437956917 https://github.com/pydata/xarray/pull/2924#issuecomment-487298047,https://api.github.com/repos/pydata/xarray/issues/2924,487298047,MDEyOklzc3VlQ29tbWVudDQ4NzI5ODA0Nw==,9948595,2019-04-27T16:04:45Z,2019-04-27T16:04:45Z,CONTRIBUTOR,Oops... I usually use black -- which I turned off since it would really have stuffed the code :),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437956917