html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2922#issuecomment-601210885,https://api.github.com/repos/pydata/xarray/issues/2922,601210885,MDEyOklzc3VlQ29tbWVudDYwMTIxMDg4NQ==,2448579,2020-03-19T14:29:42Z,2020-03-19T14:29:42Z,MEMBER,"This is going in. Thanks @mathause. This is a major contribution!","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437765416 https://github.com/pydata/xarray/pull/2922#issuecomment-545200082,https://api.github.com/repos/pydata/xarray/issues/2922,545200082,MDEyOklzc3VlQ29tbWVudDU0NTIwMDA4Mg==,2448579,2019-10-22T23:35:52Z,2019-10-22T23:35:52Z,MEMBER,"> I decided to replace all NaN in the weights with 0. Can we raise an error instead? It should be easy for the user to do `weights.fillna(0)` instead of relying on xarray's magical behaviour. > if weights sum to 0 it returns NaN (and not inf) Should we raise an error here? > The following returns NaN (could be 1) I think NaN is fine since that's the result of `1 + 0*np.nan` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,437765416