html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2906#issuecomment-484955366,https://api.github.com/repos/pydata/xarray/issues/2906,484955366,MDEyOklzc3VlQ29tbWVudDQ4NDk1NTM2Ng==,5635139,2019-04-19T16:53:44Z,2019-04-19T16:53:44Z,MEMBER,"OK, thanks @dnowacki-usgs !","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855 https://github.com/pydata/xarray/pull/2906#issuecomment-484951848,https://api.github.com/repos/pydata/xarray/issues/2906,484951848,MDEyOklzc3VlQ29tbWVudDQ4NDk1MTg0OA==,13837821,2019-04-19T16:38:48Z,2019-04-19T16:38:48Z,CONTRIBUTOR,"Good to go as far as I'm concerned. I'm not even sure how I'd phrase these changes in whats-new, so let's go with it as-is.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855 https://github.com/pydata/xarray/pull/2906#issuecomment-484645088,https://api.github.com/repos/pydata/xarray/issues/2906,484645088,MDEyOklzc3VlQ29tbWVudDQ4NDY0NTA4OA==,1217238,2019-04-18T19:05:02Z,2019-04-18T19:05:02Z,MEMBER,"Looks great! You can ignore the failing doc build in the tests, that is unrelated. If you like, feel free to give yourself a credit in `whats-new.rst` for fixing this. Otherwise I'll merge this in a day or two.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855 https://github.com/pydata/xarray/pull/2906#issuecomment-484605054,https://api.github.com/repos/pydata/xarray/issues/2906,484605054,MDEyOklzc3VlQ29tbWVudDQ4NDYwNTA1NA==,13837821,2019-04-18T17:34:24Z,2019-04-18T17:34:24Z,CONTRIBUTOR,"Thanks @shoyer. I think numeric indexes are clearer, though maybe not cleaner. Removed them and fixed the dask CI test I didn't catch the first time through. Hopefully everything passes now. 🤞 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855 https://github.com/pydata/xarray/pull/2906#issuecomment-484364344,https://api.github.com/repos/pydata/xarray/issues/2906,484364344,MDEyOklzc3VlQ29tbWVudDQ4NDM2NDM0NA==,24736507,2019-04-18T05:45:59Z,2019-04-18T17:20:14Z,NONE,"Hello @dnowacki-usgs! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2019-04-18 17:20:14 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855 https://github.com/pydata/xarray/pull/2906#issuecomment-484524659,https://api.github.com/repos/pydata/xarray/issues/2906,484524659,MDEyOklzc3VlQ29tbWVudDQ4NDUyNDY1OQ==,5635139,2019-04-18T14:06:07Z,2019-04-18T14:06:07Z,MEMBER,"Also come Py3.6, f strings 🙏 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855 https://github.com/pydata/xarray/pull/2906#issuecomment-484378485,https://api.github.com/repos/pydata/xarray/issues/2906,484378485,MDEyOklzc3VlQ29tbWVudDQ4NDM3ODQ4NQ==,1217238,2019-04-18T06:51:30Z,2019-04-18T06:51:30Z,MEMBER,"Thanks @dnowacki-usgs ! One minor note -- it's valid (since Python 2.7) to write string formatting with explicit positional indexes, e.g., you could just write `'{} {}'.format('one', 'two')` rather than `'{0} {1}'.format('one', 'two')`. I think it's usually a little cleaner to omit the numeric indices, unless you're reusing arguments multiple times or printing the names out of order. (But even in these cases it's usually nicer to use keyword names.)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434599855