html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2877#issuecomment-481813527,https://api.github.com/repos/pydata/xarray/issues/2877,481813527,MDEyOklzc3VlQ29tbWVudDQ4MTgxMzUyNw==,1217238,2019-04-10T18:41:55Z,2019-04-10T18:41:55Z,MEMBER,thanks @crusaderky !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,430214243
https://github.com/pydata/xarray/pull/2877#issuecomment-481773505,https://api.github.com/repos/pydata/xarray/issues/2877,481773505,MDEyOklzc3VlQ29tbWVudDQ4MTc3MzUwNQ==,1217238,2019-04-10T16:55:07Z,2019-04-10T16:55:07Z,MEMBER,"> @shoyer I changed dimensions from str to Hashable as requested. In my opinion however it's not great, because
> 
> 1. it's currently thoroughly broken due to lack of unit tests
> 2. it weakens type checking a lot, since Tuple is a subclass of Hashable however the vast majority of xarray functions deal with tuples with a specific code branch

I agree it's not great. But some of our APIs are going to be hard to type check regardless, e.g., in cases where we have different behavior for strings vs sequences of strings.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,430214243
https://github.com/pydata/xarray/pull/2877#issuecomment-481491326,https://api.github.com/repos/pydata/xarray/issues/2877,481491326,MDEyOklzc3VlQ29tbWVudDQ4MTQ5MTMyNg==,1217238,2019-04-10T00:46:45Z,2019-04-10T00:46:45Z,MEMBER,"If it's not too much trouble, I'd like to keep the xarray (with type checking) working on Python 3.5.0 for now. The type checks themselves only need to work on Python 3.7.

This should be relatively straightforward if you put type annotations in strings as needed and guard typing imports in `if TYPE_CHECKING` blocks.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,430214243