html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2858#issuecomment-480093002,https://api.github.com/repos/pydata/xarray/issues/2858,480093002,MDEyOklzc3VlQ29tbWVudDQ4MDA5MzAwMg==,6628425,2019-04-04T22:59:48Z,2019-04-04T22:59:48Z,MEMBER,Thanks @shoyer and @max-sixty 👍.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,427451138
https://github.com/pydata/xarray/pull/2858#issuecomment-480071693,https://api.github.com/repos/pydata/xarray/issues/2858,480071693,MDEyOklzc3VlQ29tbWVudDQ4MDA3MTY5Mw==,1217238,2019-04-04T21:32:27Z,2019-04-04T21:32:27Z,MEMBER,"> I did look at the index invariant tests with more detail, and they look

Yes, this is the main part I was hoping for someone to take a look at. I would not trust my fixes if I did not believe the tests :).

The rest of it are various smaller changes, mostly correcting my previously mistaken (and untested) implementations.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,427451138
https://github.com/pydata/xarray/pull/2858#issuecomment-479931557,https://api.github.com/repos/pydata/xarray/issues/2858,479931557,MDEyOklzc3VlQ29tbWVudDQ3OTkzMTU1Nw==,5635139,2019-04-04T14:54:56Z,2019-04-04T14:54:56Z,MEMBER,"I had a look through the code. I'm struggling a bit to be a good reviewer given my current understanding of how the goals connect to to the implementation. With that disclaimer, the code looks good. So if anyone knows this better, maybe have a look.
I did look at the index invariant tests with more detail, and they look 👍 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,427451138
https://github.com/pydata/xarray/pull/2858#issuecomment-479703772,https://api.github.com/repos/pydata/xarray/issues/2858,479703772,MDEyOklzc3VlQ29tbWVudDQ3OTcwMzc3Mg==,1217238,2019-04-04T00:20:26Z,2019-04-04T00:20:26Z,MEMBER,@pydata/xarray it would be great if someone could review this. I'd like to submit this and then issue the 0.12.1 bug fix release.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,427451138
https://github.com/pydata/xarray/pull/2858#issuecomment-478388568,https://api.github.com/repos/pydata/xarray/issues/2858,478388568,MDEyOklzc3VlQ29tbWVudDQ3ODM4ODU2OA==,24736507,2019-03-31T21:48:54Z,2019-04-03T16:22:01Z,NONE,"Hello @shoyer! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



















There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-04-03 16:22:01 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,427451138