html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2782#issuecomment-473481213,https://api.github.com/repos/pydata/xarray/issues/2782,473481213,MDEyOklzc3VlQ29tbWVudDQ3MzQ4MTIxMw==,1217238,2019-03-16T00:36:12Z,2019-03-16T00:36:12Z,MEMBER,thanks @scottyhq !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-473478323,https://api.github.com/repos/pydata/xarray/issues/2782,473478323,MDEyOklzc3VlQ29tbWVudDQ3MzQ3ODMyMw==,2443309,2019-03-16T00:13:18Z,2019-03-16T00:13:18Z,MEMBER,I think we're good here. I made one minor tweak to the windows fix @scottyhq implemented. I plan to merge this on Monday if I don't hear any objections.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-469932852,https://api.github.com/repos/pydata/xarray/issues/2782,469932852,MDEyOklzc3VlQ29tbWVudDQ2OTkzMjg1Mg==,24736507,2019-03-06T01:46:54Z,2019-03-15T23:35:29Z,NONE,"Hello @scottyhq! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2019-03-15 23:35:28 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-470826890,https://api.github.com/repos/pydata/xarray/issues/2782,470826890,MDEyOklzc3VlQ29tbWVudDQ3MDgyNjg5MA==,2443309,2019-03-08T06:58:20Z,2019-03-08T06:58:20Z,MEMBER,"@scottyhq - can you add note to the what's new page?
From what I can tell, I don't think the failing tests are related to this PR. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-470765319,https://api.github.com/repos/pydata/xarray/issues/2782,470765319,MDEyOklzc3VlQ29tbWVudDQ3MDc2NTMxOQ==,3924836,2019-03-08T01:13:16Z,2019-03-08T01:13:58Z,MEMBER,"thanks for the input @shoyer, I attempted to tidy up a bit and in the process re-ordered some things such as adding an 'engine' check at the top of open_dataset(). backend tests are passing locally on my machine. hopefully i didn't add too much here or overstep!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-469941846,https://api.github.com/repos/pydata/xarray/issues/2782,469941846,MDEyOklzc3VlQ29tbWVudDQ2OTk0MTg0Ng==,1217238,2019-03-06T02:27:49Z,2019-03-06T02:27:49Z,MEMBER,"I don't think it's essential to have an integration test doing real network
access in xarray, so I would consider just dropping that part instead.
On Tue, Mar 5, 2019 at 6:10 PM Ryan Abernathey
wrote:
> *@rabernat* commented on this pull request.
> ------------------------------
>
> In xarray/tests/test_backends.py
> :
>
> > @@ -1955,6 +1955,39 @@ def test_dump_encodings_h5py(self):
> assert actual.x.encoding['compression_opts'] is None
>
>
> +@requires_h5fileobj
> +class TestH5NetCDFFileObject(TestH5NetCDFData):
> + h5py = pytest.importorskip('h5py', minversion='2.9.0')
> + engine = 'h5netcdf'
> +
> + @network
> + def test_h5remote(self):
> + # alternative: http://era5-pds.s3.amazonaws.com/2008/01/main.nc
>
>
> + import requests
> + url = ('https://www.unidata.ucar.edu/'
> + 'software/netcdf/examples/test_hgroups.nc')
>
> Rather than going over the network, it might be quite easy to fire up a
> http.server.SimpleHTTPRequestHandler
>
> as part of a fixture. This would allow us to test the remote capability
> without internet (and without depending on a third party to host a file.)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-469556377,https://api.github.com/repos/pydata/xarray/issues/2782,469556377,MDEyOklzc3VlQ29tbWVudDQ2OTU1NjM3Nw==,3924836,2019-03-05T06:27:51Z,2019-03-05T06:27:51Z,MEMBER,"@shoyer , it would be great to have your feedback on these recent changes now that h5netcdf 0.7 is out. There's a bit more logic required in `api.py` now that scipy isn't the only backend that is able to read file-like objects (and people may not specify `engine=` when opening datasets)
`test_backends.py` passes locally for me except for `TestValidateAttrs.test_validating_attrs`... not sure why.
Also, per your comment here: https://github.com/shoyer/h5netcdf/pull/51#issuecomment-467591446, I think it would be great to get a few small netcdf4/hdf test files in https://github.com/pydata/xarray-data. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-466260533,https://api.github.com/repos/pydata/xarray/issues/2782,466260533,MDEyOklzc3VlQ29tbWVudDQ2NjI2MDUzMw==,1217238,2019-02-22T03:27:56Z,2019-02-22T03:27:56Z,MEMBER,"This looks great!
I'll note one minor extension: you could look at the first few bytes of the file (the ""magic number"") to determine if it's a netCDF3 or netCDF4 file, and hence whether it can be opened with scipy or h5netcdf:
- `CDF\001` or `CDF\002` would indicate [netCDF3](https://en.wikipedia.org/wiki/NetCDF) (use scipy)
- `\211HDF\r\n\032\n` would indicate [netCDF4/HDF5](https://en.wikipedia.org/wiki/Hierarchical_Data_Format) (use h5netcdf)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481
https://github.com/pydata/xarray/pull/2782#issuecomment-465770077,https://api.github.com/repos/pydata/xarray/issues/2782,465770077,MDEyOklzc3VlQ29tbWVudDQ2NTc3MDA3Nw==,306380,2019-02-20T21:54:15Z,2019-02-20T21:54:15Z,MEMBER,"I'm glad to see this. I'll also be curious to see what the performance will look like.
cc @llllllllll","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481