html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2766#issuecomment-464282626,https://api.github.com/repos/pydata/xarray/issues/2766,464282626,MDEyOklzc3VlQ29tbWVudDQ2NDI4MjYyNg==,5635139,2019-02-16T03:52:01Z,2019-02-16T03:52:01Z,MEMBER,"OK, thanks. Being able to call `np.pinv(da, dim='x')` would be awesome, but ack the downsides you outlined in the PEP ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618015
https://github.com/pydata/xarray/pull/2766#issuecomment-464254541,https://api.github.com/repos/pydata/xarray/issues/2766,464254541,MDEyOklzc3VlQ29tbWVudDQ2NDI1NDU0MQ==,5635139,2019-02-16T00:01:36Z,2019-02-16T00:01:36Z,MEMBER,"> Yes, `np.pinv` will raise if passed a `dim` kwargs. This was an intentional choice: http://www.numpy.org/neps/nep-0018-array-function-protocol.html#support-for-implementation-specific-arguments

Thanks.

With the current state, am I correct in thinking we still need wrappers for any `numpy.linalg` function that requires a `dim` kwarg?
(I guess we _could_ use the `axis` kwarg instead, but that might be confusing things)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618015
https://github.com/pydata/xarray/pull/2766#issuecomment-464234058,https://api.github.com/repos/pydata/xarray/issues/2766,464234058,MDEyOklzc3VlQ29tbWVudDQ2NDIzNDA1OA==,5635139,2019-02-15T22:48:33Z,2019-02-15T22:48:33Z,MEMBER,"> No, that would give an error message about passing in a bad argument name. We'll need our own wrappers to switch `axis` to `dim`.

I understand we'd need to define `__array_function__` on xarray objects managed the conversion. 

Conditional on that, could someone call `np.pinv(da, dim=['x', 'y']`? And then `DataArray.__array_function__` would receive the `dim` kwarg. 

Or would `np.pinv` raise if passed a `dim` kwarg? (if so, we'd still need to declare n wrappers, IIUC?)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618015
https://github.com/pydata/xarray/pull/2766#issuecomment-464183807,https://api.github.com/repos/pydata/xarray/issues/2766,464183807,MDEyOklzc3VlQ29tbWVudDQ2NDE4MzgwNw==,5635139,2019-02-15T20:11:38Z,2019-02-15T20:11:38Z,MEMBER,"> Note that with [NEP-18](http://www.numpy.org/neps/nep-0018-array-function-protocol.html) we'll be able to directly everything in numpy.linalg on xarray objects, without requiring the use of a separate wrapper.

It would be awesome for those numpy functions to just work! Could we start on this now, making it conditional on numpy 1.16 installed? 

Reading the NEP, I _think_ you could literally pass `dim=['x','y']` to the numpy function, and it'll pass that onto xarray. Lmk if I'm mistaken.

Speaking for @erbian (my colleague) , no rush to merge this - we thought it would be helpful but have it internally. Even better if we can get a general solution.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618015
https://github.com/pydata/xarray/pull/2766#issuecomment-463719035,https://api.github.com/repos/pydata/xarray/issues/2766,463719035,MDEyOklzc3VlQ29tbWVudDQ2MzcxOTAzNQ==,5635139,2019-02-14T17:36:36Z,2019-02-14T17:36:36Z,MEMBER,Unfortunately this requires numpy 1.14. That's a year old - too soon to bump the minimum version?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618015