html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2749#issuecomment-462419899,https://api.github.com/repos/pydata/xarray/issues/2749,462419899,MDEyOklzc3VlQ29tbWVudDQ2MjQxOTg5OQ==,1217238,2019-02-11T17:35:07Z,2019-02-11T17:35:07Z,MEMBER,thanks Yohai!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,407523050 https://github.com/pydata/xarray/pull/2749#issuecomment-462342581,https://api.github.com/repos/pydata/xarray/issues/2749,462342581,MDEyOklzc3VlQ29tbWVudDQ2MjM0MjU4MQ==,6164157,2019-02-11T14:17:04Z,2019-02-11T14:17:04Z,CONTRIBUTOR,@shoyer your fix works. I think it's ready to merge.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,407523050 https://github.com/pydata/xarray/pull/2749#issuecomment-461271787,https://api.github.com/repos/pydata/xarray/issues/2749,461271787,MDEyOklzc3VlQ29tbWVudDQ2MTI3MTc4Nw==,24736507,2019-02-07T02:59:48Z,2019-02-11T14:16:13Z,NONE,"Hello @yohai! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. :beers: ##### Comment last updated on February 11, 2019 at 14:16 Hours UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,407523050 https://github.com/pydata/xarray/pull/2749#issuecomment-461542452,https://api.github.com/repos/pydata/xarray/issues/2749,461542452,MDEyOklzc3VlQ29tbWVudDQ2MTU0MjQ1Mg==,6164157,2019-02-07T18:27:41Z,2019-02-07T18:27:41Z,CONTRIBUTOR,"I agree that my solution is a bit hacky, but from a computational cost viewpoint they are identical (or almost. I don't think there's a way to avoid one if statement per call of `where`). I thought my solution is good because catching this at a high level captures all possible edge cases that we might miss at lower ones. But I can try to do what you suggested to.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,407523050 https://github.com/pydata/xarray/pull/2749#issuecomment-461538356,https://api.github.com/repos/pydata/xarray/issues/2749,461538356,MDEyOklzc3VlQ29tbWVudDQ2MTUzODM1Ng==,1217238,2019-02-07T18:16:03Z,2019-02-07T18:16:03Z,MEMBER,"This looks fine, though I'd rather fix this at a lower level, if possible. This line in `computation.py` sets the name on result DataArray objects: https://github.com/pydata/xarray/blob/0dfc0e63650deb3da1fb1cba48cda88a704c2d60/xarray/core/computation.py#L210 If `keep_attrs=True` (you'll need to thread the argument into `apply_dataarray_ufunc` from `apply_ufunc`), then we should just copy the name from the first argument instead, e.g., `name = args[0].name if keep_attrs else result_name(args)`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,407523050