html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2716#issuecomment-457963623,https://api.github.com/repos/pydata/xarray/issues/2716,457963623,MDEyOklzc3VlQ29tbWVudDQ1Nzk2MzYyMw==,43613877,2019-01-27T23:16:58Z,2019-01-27T23:24:46Z,CONTRIBUTOR,"Sure @jhamman, I'll add some tests. However, I thought the test should rather go into [test_dataarray.py](https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataarray.py) than [test_missing.py](https://github.com/pydata/xarray/blob/master/xarray/tests/test_missing.py), because this is an improvement to resample/_upsample? Something like ```python def test_upsample_tolerance(self): # Test tolerance keyword for upsample methods bfill, pad, nearest times = pd.date_range('2000-01-01', freq='1D', periods=2) times_upsampled = pd.date_range('2000-01-01', freq='6H', periods=5) array = DataArray(np.arange(2), [('time', times)]) # Forward fill actual = array.resample(time='6H').ffill(tolerance='12H') expected = DataArray([0., 0., 0., np.nan, 1.], [('time', times_upsampled)]) assert_identical(expected, actual) ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403462155