html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2716#issuecomment-459432101,https://api.github.com/repos/pydata/xarray/issues/2716,459432101,MDEyOklzc3VlQ29tbWVudDQ1OTQzMjEwMQ==,1217238,2019-01-31T17:28:16Z,2019-01-31T17:28:16Z,MEMBER,Thanks @observingClouds -- really nice PR!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403462155
https://github.com/pydata/xarray/pull/2716#issuecomment-458013591,https://api.github.com/repos/pydata/xarray/issues/2716,458013591,MDEyOklzc3VlQ29tbWVudDQ1ODAxMzU5MQ==,24736507,2019-01-28T06:35:12Z,2019-01-30T22:33:52Z,NONE,"Hello @observingClouds! Thanks for updating the PR.







Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 30, 2019 at 22:33 Hours UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403462155
https://github.com/pydata/xarray/pull/2716#issuecomment-457968698,https://api.github.com/repos/pydata/xarray/issues/2716,457968698,MDEyOklzc3VlQ29tbWVudDQ1Nzk2ODY5OA==,2443309,2019-01-28T00:31:55Z,2019-01-28T00:31:55Z,MEMBER,"@observingClouds - I had forgotten the upsample tests were in `test_dataarray.py`. That seems like a better place to test this functionality. 

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403462155
https://github.com/pydata/xarray/pull/2716#issuecomment-457963623,https://api.github.com/repos/pydata/xarray/issues/2716,457963623,MDEyOklzc3VlQ29tbWVudDQ1Nzk2MzYyMw==,43613877,2019-01-27T23:16:58Z,2019-01-27T23:24:46Z,CONTRIBUTOR,"Sure @jhamman, I'll add some tests.
However, I thought the test should rather go into [test_dataarray.py](https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataarray.py) than [test_missing.py](https://github.com/pydata/xarray/blob/master/xarray/tests/test_missing.py), because
this is an improvement to resample/_upsample?

Something like
```python
    def test_upsample_tolerance(self):
        # Test tolerance keyword for upsample methods bfill, pad, nearest
        times = pd.date_range('2000-01-01', freq='1D', periods=2)
        times_upsampled = pd.date_range('2000-01-01', freq='6H', periods=5)
        array = DataArray(np.arange(2), [('time', times)])

        # Forward fill
        actual = array.resample(time='6H').ffill(tolerance='12H')
        expected = DataArray([0., 0., 0., np.nan, 1.],
                             [('time', times_upsampled)])
        assert_identical(expected, actual)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403462155
https://github.com/pydata/xarray/pull/2716#issuecomment-457852456,https://api.github.com/repos/pydata/xarray/issues/2716,457852456,MDEyOklzc3VlQ29tbWVudDQ1Nzg1MjQ1Ng==,2443309,2019-01-26T18:08:49Z,2019-01-26T18:08:49Z,MEMBER,"Thanks @observingClouds - At first glance, this seems right but we'll want some tests to confirm. You'll probably want to put these in [test_missing.py](https://github.com/pydata/xarray/blob/master/xarray/tests/test_missing.py). That's where the existing tests for bfill/pad/etc are so should be easy to extend for this feature.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,403462155