html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2668#issuecomment-453843848,https://api.github.com/repos/pydata/xarray/issues/2668,453843848,MDEyOklzc3VlQ29tbWVudDQ1Mzg0Mzg0OA==,1217238,2019-01-13T16:29:44Z,2019-01-13T16:29:44Z,MEMBER,"> I couldn't make `datetime_to_numeric` compatible both `np.ndarray` and `Variable`. I think it would be cleaner if `Variable` has a (private) method to do this, like `Variable._to_numeric(offset=None, datetime_unit=None)`.

Sounds good to me. It's definitely best to handle numpy arrays and xarray.Variable objects separately.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453680857,https://api.github.com/repos/pydata/xarray/issues/2668,453680857,MDEyOklzc3VlQ29tbWVudDQ1MzY4MDg1Nw==,1217238,2019-01-11T22:44:32Z,2019-01-11T22:44:32Z,MEMBER,"(at least for now, until we can figure out how to handle missing values)

On Fri, Jan 11, 2019 at 2:44 PM Stephan Hoyer <shoyer@gmail.com> wrote:

> OK, in that case let's only worry about NaT for datetime64/timedelta64
> arrays.
>
> On Fri, Jan 11, 2019 at 2:37 PM Spencer Clark <notifications@github.com>
> wrote:
>
>> what convention do you use for missing values in cftime arrays?
>>
>> Currently there is nothing built in to xarray to support missing values
>> for cftime arrays. I think we would have to come up with a convention.
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/pydata/xarray/pull/2668#issuecomment-453679270>, or mute
>> the thread
>> <https://github.com/notifications/unsubscribe-auth/ABKS1iSjXGAEXm6e5gqGCY390bNdMIiMks5vCRISgaJpZM4Z8P5F>
>> .
>>
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453680807,https://api.github.com/repos/pydata/xarray/issues/2668,453680807,MDEyOklzc3VlQ29tbWVudDQ1MzY4MDgwNw==,1217238,2019-01-11T22:44:18Z,2019-01-11T22:44:18Z,MEMBER,"OK, in that case let's only worry about NaT for datetime64/timedelta64
arrays.

On Fri, Jan 11, 2019 at 2:37 PM Spencer Clark <notifications@github.com>
wrote:

> what convention do you use for missing values in cftime arrays?
>
> Currently there is nothing built in to xarray to support missing values
> for cftime arrays. I think we would have to come up with a convention.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/2668#issuecomment-453679270>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1iSjXGAEXm6e5gqGCY390bNdMIiMks5vCRISgaJpZM4Z8P5F>
> .
>
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453675862,https://api.github.com/repos/pydata/xarray/issues/2668,453675862,MDEyOklzc3VlQ29tbWVudDQ1MzY3NTg2Mg==,1217238,2019-01-11T22:21:45Z,2019-01-11T22:21:45Z,MEMBER,@spencerkclark what convention do you use for missing values in cftime arrays?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139