html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2590#issuecomment-446866434,https://api.github.com/repos/pydata/xarray/issues/2590,446866434,MDEyOklzc3VlQ29tbWVudDQ0Njg2NjQzNA==,8898319,2018-12-13T07:16:23Z,2018-12-13T07:16:23Z,CONTRIBUTOR,Cool. I will keep using Xarray. Thanks for the great work,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324
https://github.com/pydata/xarray/pull/2590#issuecomment-446666682,https://api.github.com/repos/pydata/xarray/issues/2590,446666682,MDEyOklzc3VlQ29tbWVudDQ0NjY2NjY4Mg==,1217238,2018-12-12T17:11:45Z,2018-12-12T17:11:45Z,MEMBER,"Thank @MBlaschek -- we appreciate your help here! It does get easier for next time, I promise :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324
https://github.com/pydata/xarray/pull/2590#issuecomment-446663592,https://api.github.com/repos/pydata/xarray/issues/2590,446663592,MDEyOklzc3VlQ29tbWVudDQ0NjY2MzU5Mg==,2448579,2018-12-12T17:03:05Z,2018-12-12T17:03:05Z,MEMBER,"Thanks, @MBlaschek. Looks great to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324
https://github.com/pydata/xarray/pull/2590#issuecomment-446546926,https://api.github.com/repos/pydata/xarray/issues/2590,446546926,MDEyOklzc3VlQ29tbWVudDQ0NjU0NjkyNg==,8898319,2018-12-12T10:57:46Z,2018-12-12T10:57:46Z,CONTRIBUTOR,"I hope that is all you guys wanted. It's kinda complicated for me to follow all these procedures to do really simple thing. I hope that helps and thanks for the inside into pull-requests.
Please let me know if I can close it and be done with it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324
https://github.com/pydata/xarray/pull/2590#issuecomment-444424066,https://api.github.com/repos/pydata/xarray/issues/2590,444424066,MDEyOklzc3VlQ29tbWVudDQ0NDQyNDA2Ng==,24736507,2018-12-05T09:47:51Z,2018-12-07T09:40:11Z,NONE,"Hello @MBlaschek! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`xarray/core/variable.py`](https://github.com/MBlaschek/xarray/blob/80cca11e67d14774a0193e3227a57a7b7d724de4/xarray/core/variable.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_variable.py`](https://github.com/MBlaschek/xarray/blob/80cca11e67d14774a0193e3227a57a7b7d724de4/xarray/tests/test_variable.py) !



##### Comment last updated on December 07, 2018 at 09:40 Hours UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324
https://github.com/pydata/xarray/pull/2590#issuecomment-444562863,https://api.github.com/repos/pydata/xarray/issues/2590,444562863,MDEyOklzc3VlQ29tbWVudDQ0NDU2Mjg2Mw==,2448579,2018-12-05T17:04:43Z,2018-12-05T17:07:30Z,MEMBER,"Thanks @MBlaschek. 
1. You'll need to also add a note to `doc/whats-new.rst`.
2. Looks like there's trailing whitespace in `test_variable.py` that will need to be fixed.

EDIT: Looks like the tests aren't running because of this ImportError

```
ImportError while importing test module '/home/travis/build/pydata/xarray/xarray/tests/test_variable.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
xarray/tests/test_variable.py:27: in <module>
    from . import (
E   ImportError: cannot import name 'set_options'
```

I think you need `from xarray import set_options` as in `test_dataset.py`. You can test this out locally using pytest. We have some documentation on contributing here: http://xarray.pydata.org/en/stable/contributing.html. Feel free to ask if you have questions","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324