html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2516#issuecomment-434899873,https://api.github.com/repos/pydata/xarray/issues/2516,434899873,MDEyOklzc3VlQ29tbWVudDQzNDg5OTg3Mw==,1217238,2018-11-01T01:22:01Z,2018-11-01T01:22:01Z,MEMBER,"> In 6d08d3b I made changes to set_options to only fill the self.old dictionary with the old values for the keyword arguments specified in the constructor, and then had the __exit__ method only reset the values that were temporarily set before. The win-32 build now passes, and we no longer have the undesirable warning behavior shown above. Do you think that was a reasonable fix?

This looks like a reasonable fix to me","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077
https://github.com/pydata/xarray/pull/2516#issuecomment-434747673,https://api.github.com/repos/pydata/xarray/issues/2516,434747673,MDEyOklzc3VlQ29tbWVudDQzNDc0NzY3Mw==,1217238,2018-10-31T16:08:46Z,2018-10-31T16:08:46Z,MEMBER,"I don't know why this failed in one of the Appveyor builds:
```
================================== FAILURES ===================================
___________________________ test_enable_cftimeindex ___________________________
    def test_enable_cftimeindex():
        with pytest.raises(ValueError):
            xarray.set_options(enable_cftimeindex=None)
        with pytest.warns(FutureWarning, match='no-op'):
            with xarray.set_options(enable_cftimeindex=True):
>               assert OPTIONS['enable_cftimeindex']
E               Failed: DID NOT WARN. No warnings of type (<type 'exceptions.FutureWarning'>,) was emitted. The list of emitted warnings is: [].
xarray\tests\test_options.py:38: Failed
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077