html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2516#issuecomment-434899873,https://api.github.com/repos/pydata/xarray/issues/2516,434899873,MDEyOklzc3VlQ29tbWVudDQzNDg5OTg3Mw==,1217238,2018-11-01T01:22:01Z,2018-11-01T01:22:01Z,MEMBER,"> In 6d08d3b I made changes to set_options to only fill the self.old dictionary with the old values for the keyword arguments specified in the constructor, and then had the __exit__ method only reset the values that were temporarily set before. The win-32 build now passes, and we no longer have the undesirable warning behavior shown above. Do you think that was a reasonable fix?
This looks like a reasonable fix to me","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077
https://github.com/pydata/xarray/pull/2516#issuecomment-434899060,https://api.github.com/repos/pydata/xarray/issues/2516,434899060,MDEyOklzc3VlQ29tbWVudDQzNDg5OTA2MA==,6628425,2018-11-01T01:17:06Z,2018-11-01T01:17:06Z,MEMBER,"Thanks @shoyer -- that was a bit puzzling but I think I sorted it out. I haven't done a careful diagnosis, but my hunch is that the previous build was running into this issue: https://github.com/pytest-dev/pytest/issues/2917. A fix was merged a few weeks ago, but the Python 2.7 32-bit build is/was using a relatively old version of pytest (3.5 versus the most recent 3.9.3).
In the previous build, the FutureWarning for setting the `enable_cftimeindex` option was being emitted earlier in `test_backends.py` in the `test_open_mfdataset_manyfiles` test (before we were watching for it in the options tests). It was being raised there, because upon calling `set_options.__exit__`, every option (not just the options that were set in a `with` statement) would be reset to its global value. For example doing something like this would emit the warning (which even outside of this minor testing issue, I think is undesirable):
```
In [1]: import xarray
In [2]: with xarray.set_options(display_width=40):
...: pass
...:
/Users/spencerclark/xarray-dev/xarray/xarray/core/options.py:49: FutureWarning: The enable_cftimeindex option is now a no-op and will be removed in a future version of xarray.
FutureWarning)
```
In 6d08d3b I made changes to `set_options` to only fill the `self.old` dictionary with the old values for the keyword arguments specified in the constructor, and then had the `__exit__` method only reset the values that were temporarily set before. The win-32 build now passes, and we no longer have the undesirable warning behavior shown above. Do you think that was a reasonable fix?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077
https://github.com/pydata/xarray/pull/2516#issuecomment-434747673,https://api.github.com/repos/pydata/xarray/issues/2516,434747673,MDEyOklzc3VlQ29tbWVudDQzNDc0NzY3Mw==,1217238,2018-10-31T16:08:46Z,2018-10-31T16:08:46Z,MEMBER,"I don't know why this failed in one of the Appveyor builds:
```
================================== FAILURES ===================================
___________________________ test_enable_cftimeindex ___________________________
def test_enable_cftimeindex():
with pytest.raises(ValueError):
xarray.set_options(enable_cftimeindex=None)
with pytest.warns(FutureWarning, match='no-op'):
with xarray.set_options(enable_cftimeindex=True):
> assert OPTIONS['enable_cftimeindex']
E Failed: DID NOT WARN. No warnings of type (,) was emitted. The list of emitted warnings is: [].
xarray\tests\test_options.py:38: Failed
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077
https://github.com/pydata/xarray/pull/2516#issuecomment-433446875,https://api.github.com/repos/pydata/xarray/issues/2516,433446875,MDEyOklzc3VlQ29tbWVudDQzMzQ0Njg3NQ==,24736507,2018-10-26T15:26:35Z,2018-10-27T18:13:36Z,NONE,"Hello @spencerkclark! Thanks for updating the PR.
- There are no PEP8 issues in the file [`xarray/coding/cftimeindex.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/coding/cftimeindex.py) !
- There are no PEP8 issues in the file [`xarray/coding/times.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/coding/times.py) !
- There are no PEP8 issues in the file [`xarray/core/common.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/core/common.py) !
- There are no PEP8 issues in the file [`xarray/core/options.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/core/options.py) !
- There are no PEP8 issues in the file [`xarray/core/utils.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/core/utils.py) !
- There are no PEP8 issues in the file [`xarray/plot/plot.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/plot/plot.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_backends.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/tests/test_backends.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_cftimeindex.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/tests/test_cftimeindex.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_coding_times.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/tests/test_coding_times.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_dataarray.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/tests/test_dataarray.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_options.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/tests/test_options.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_utils.py`](https://github.com/spencerkclark/xarray/blob/1a6841df309a680b0315c1d6b1923bf8a683d8ee/xarray/tests/test_utils.py) !
##### Comment last updated on October 27, 2018 at 18:13 Hours UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077
https://github.com/pydata/xarray/pull/2516#issuecomment-433485272,https://api.github.com/repos/pydata/xarray/issues/2516,433485272,MDEyOklzc3VlQ29tbWVudDQzMzQ4NTI3Mg==,2448579,2018-10-26T17:32:55Z,2018-10-26T17:32:55Z,MEMBER,Should we add nice error messages to resample and plot telling the user what to do if they try those two with cftimeindex?,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374434077