html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2500#issuecomment-432184231,https://api.github.com/repos/pydata/xarray/issues/2500,432184231,MDEyOklzc3VlQ29tbWVudDQzMjE4NDIzMQ==,226037,2018-10-23T10:06:20Z,2018-10-23T10:31:37Z,MEMBER,"@shoyer you are right, I had to make a user-visible backward-incompatible change in cfgrib and Travis is getting the latest version. I'll make a PR to fix the test. Note that I don't expect to do any other backward-incompatible change this big and the test is going to be robust to version change from now on.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063 https://github.com/pydata/xarray/pull/2500#issuecomment-432037896,https://api.github.com/repos/pydata/xarray/issues/2500,432037896,MDEyOklzc3VlQ29tbWVudDQzMjAzNzg5Ng==,1217238,2018-10-23T00:22:56Z,2018-10-23T00:22:56Z,MEMBER,thanks @mrocklin !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063 https://github.com/pydata/xarray/pull/2500#issuecomment-432037721,https://api.github.com/repos/pydata/xarray/issues/2500,432037721,MDEyOklzc3VlQ29tbWVudDQzMjAzNzcyMQ==,1217238,2018-10-23T00:22:01Z,2018-10-23T00:22:01Z,MEMBER,"I'm pretty sure that error is different, cc @alexamici ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063 https://github.com/pydata/xarray/pull/2500#issuecomment-432016733,https://api.github.com/repos/pydata/xarray/issues/2500,432016733,MDEyOklzc3VlQ29tbWVudDQzMjAxNjczMw==,306380,2018-10-22T22:42:11Z,2018-10-22T22:42:11Z,MEMBER,"I'm not sure that I understand the failure here. Can someone verify that this is related to these changes? ``` =================================== FAILURES =================================== _____________________________ TestCfGrib.test_read _____________________________ self = def test_read(self): expected = {'number': 2, 'time': 3, 'air_pressure': 2, 'latitude': 3, 'longitude': 4} with open_example_dataset('example.grib', engine='cfgrib') as ds: > assert ds.dims == expected E AssertionError: assert Frozen(Sorted...ngitude': 4})) == {'air_pressure...mber': 2, ...} E Full diff: E - Frozen(SortedKeysDict({'number': 2, 'time': 3, 'isobaricInhPa': 2, 'latitude': 3, 'longitude': 4})) E + {'air_pressure': 2, 'latitude': 3, 'longitude': 4, 'number': 2, 'time': 3} xarray/tests/test_backends.py:2473: AssertionError _____________________ TestCfGrib.test_read_filter_by_keys ______________________ self = def test_read_filter_by_keys(self): kwargs = {'filter_by_keys': {'shortName': 't'}} expected = {'number': 2, 'time': 3, 'air_pressure': 2, 'latitude': 3, 'longitude': 4} with open_example_dataset('example.grib', engine='cfgrib', backend_kwargs=kwargs) as ds: > assert ds.dims == expected E AssertionError: assert Frozen(Sorted...ngitude': 4})) == {'air_pressure...mber': 2, ...} E Full diff: E - Frozen(SortedKeysDict({'number': 2, 'time': 3, 'isobaricInhPa': 2, 'latitude': 3, 'longitude': 4})) E + {'air_pressure': 2, 'latitude': 3, 'longitude': 4, 'number': 2, 'time': 3} xarray/tests/test_backends.py:2483: AssertionError ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063 https://github.com/pydata/xarray/pull/2500#issuecomment-431963883,https://api.github.com/repos/pydata/xarray/issues/2500,431963883,MDEyOklzc3VlQ29tbWVudDQzMTk2Mzg4Mw==,24736507,2018-10-22T20:06:43Z,2018-10-22T20:06:43Z,NONE,"Hello @mrocklin! Thanks for submitting the PR. - There are no PEP8 issues in the file [`asv_bench/benchmarks/dataset_io.py`](https://github.com/mrocklin/xarray/blob/606f2f5eeed29352f4c25006d2697a8ce38c008e/asv_bench/benchmarks/dataset_io.py) ! - There are no PEP8 issues in the file [`xarray/tests/__init__.py`](https://github.com/mrocklin/xarray/blob/606f2f5eeed29352f4c25006d2697a8ce38c008e/xarray/tests/__init__.py) ! - There are no PEP8 issues in the file [`xarray/tests/test_dask.py`](https://github.com/mrocklin/xarray/blob/606f2f5eeed29352f4c25006d2697a8ce38c008e/xarray/tests/test_dask.py) ! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063 https://github.com/pydata/xarray/pull/2500#issuecomment-431934087,https://api.github.com/repos/pydata/xarray/issues/2500,431934087,MDEyOklzc3VlQ29tbWVudDQzMTkzNDA4Nw==,306380,2018-10-22T18:49:11Z,2018-10-22T18:49:11Z,MEMBER,"Yes, github is still having issues. https://status.github.com/messages We are working through the backlogs of webhook deliveries and Pages builds. We continue to monitor as the site recovers. On Mon, Oct 22, 2018 at 2:48 PM Maximilian Roos wrote: > Thanks @mrocklin > > Anyone have any idea why Travis isn't running? Is it the GH issues from > this morning? Looks like the latest run was a couple of days ago: > https://travis-ci.org/pydata/xarray/pull_requests > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , or mute > the thread > > . > ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063 https://github.com/pydata/xarray/pull/2500#issuecomment-431933524,https://api.github.com/repos/pydata/xarray/issues/2500,431933524,MDEyOklzc3VlQ29tbWVudDQzMTkzMzUyNA==,5635139,2018-10-22T18:47:46Z,2018-10-22T18:47:46Z,MEMBER,"Thanks @mrocklin Anyone have any idea why Travis isn't running? Is it the GH issues from this morning? Looks like the latest run was a couple of days ago: https://travis-ci.org/pydata/xarray/pull_requests","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,372640063