html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2479#issuecomment-429126831,https://api.github.com/repos/pydata/xarray/issues/2479,429126831,MDEyOklzc3VlQ29tbWVudDQyOTEyNjgzMQ==,5635139,2018-10-11T21:34:50Z,2018-10-11T21:34:50Z,MEMBER,Thanks @shoyer !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,368912226 https://github.com/pydata/xarray/pull/2479#issuecomment-429122765,https://api.github.com/repos/pydata/xarray/issues/2479,429122765,MDEyOklzc3VlQ29tbWVudDQyOTEyMjc2NQ==,1217238,2018-10-11T21:20:49Z,2018-10-11T21:20:49Z,MEMBER,"There's a real test failure with dask-dev, but it's unrelated.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,368912226 https://github.com/pydata/xarray/pull/2479#issuecomment-428796152,https://api.github.com/repos/pydata/xarray/issues/2479,428796152,MDEyOklzc3VlQ29tbWVudDQyODc5NjE1Mg==,5635139,2018-10-11T02:23:17Z,2018-10-11T02:23:17Z,MEMBER,"Good catch! I'm sorry I missed this. I should have compared the total number of tests running given it was a broad change to the tests. Here's a patch to make the current tests pass: ```diff diff --git a/xarray/tests/test_conventions.py b/xarray/tests/test_conventions.py index a067d01a..5fa518f5 100644 --- a/xarray/tests/test_conventions.py +++ b/xarray/tests/test_conventions.py @@ -18,7 +18,7 @@ from xarray.testing import assert_identical from . import ( assert_array_equal, raises_regex, requires_cftime_or_netCDF4, requires_dask, requires_netCDF4) -from .test_backends import CFEncodedDataTest +from .test_backends import CFEncodedBase class TestBoolTypeArray(object): @@ -255,7 +255,7 @@ class CFEncodedInMemoryStore(WritableCFDataStore, InMemoryDataStore): @requires_netCDF4 -class TestCFEncodedDataStore(CFEncodedDataTest): +class TestCFEncodedDataStore(CFEncodedBase): @contextlib.contextmanager def create_store(self): yield CFEncodedInMemoryStore() ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,368912226 https://github.com/pydata/xarray/pull/2479#issuecomment-428783263,https://api.github.com/repos/pydata/xarray/issues/2479,428783263,MDEyOklzc3VlQ29tbWVudDQyODc4MzI2Mw==,24736507,2018-10-11T01:08:16Z,2018-10-11T01:08:16Z,NONE,"Hello @shoyer! Thanks for submitting the PR. - There are no PEP8 issues in the file [`xarray/backends/pseudonetcdf_.py`](https://github.com/shoyer/xarray/blob/827ab1db649c55057aef933ebe360ca60f9b6425/xarray/backends/pseudonetcdf_.py) ! - There are no PEP8 issues in the file [`xarray/tests/test_backends.py`](https://github.com/shoyer/xarray/blob/827ab1db649c55057aef933ebe360ca60f9b6425/xarray/tests/test_backends.py) ! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,368912226