html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2467#issuecomment-427594908,https://api.github.com/repos/pydata/xarray/issues/2467,427594908,MDEyOklzc3VlQ29tbWVudDQyNzU5NDkwOA==,1217238,2018-10-06T18:09:56Z,2018-10-06T18:09:56Z,MEMBER,"Thanks Maximilian!
On Sat, Oct 6, 2018 at 1:09 PM Maximilian Roos <notifications@github.com>
wrote:

> Merged #2467 <https://github.com/pydata/xarray/pull/2467> into master.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/2467#event-1888659594>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1ooi7R3npC2m27npvMxbEgYbLyXjks5uiOO7gaJpZM4XLHP3>
> .
>
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,367410303
https://github.com/pydata/xarray/pull/2467#issuecomment-427582505,https://api.github.com/repos/pydata/xarray/issues/2467,427582505,MDEyOklzc3VlQ29tbWVudDQyNzU4MjUwNQ==,5635139,2018-10-06T15:24:45Z,2018-10-06T15:24:45Z,MEMBER,"I added a commit to clear up some of the issues that @shoyer found. 

Assuming tests pass, I'll merge shortly given risk of conflicts - please lmk any final comments. I'm also happy to do any flups after merge this weekend.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,367410303
https://github.com/pydata/xarray/pull/2467#issuecomment-427535087,https://api.github.com/repos/pydata/xarray/issues/2467,427535087,MDEyOklzc3VlQ29tbWVudDQyNzUzNTA4Nw==,24736507,2018-10-06T01:16:03Z,2018-10-06T15:15:33Z,NONE,"Hello @max-sixty! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`xarray/tests/__init__.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/__init__.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_accessors.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_accessors.py) !

 - In the file [`xarray/tests/test_backends.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_backends.py), following                are the PEP8 issues :
> [Line 2436:38](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_backends.py#L2436): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'l'
> [Line 2436:58](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_backends.py#L2436): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'l'


 - There are no PEP8 issues in the file [`xarray/tests/test_combine.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_combine.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_conventions.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_conventions.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_dask.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_dask.py) !

 - In the file [`xarray/tests/test_dataarray.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_dataarray.py), following                are the PEP8 issues :
> [Line 444:9](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_dataarray.py#L444): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'I'


 - There are no PEP8 issues in the file [`xarray/tests/test_dataset.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_dataset.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_duck_array_ops.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_duck_array_ops.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_extensions.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_extensions.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_formatting.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_formatting.py) !

 - In the file [`xarray/tests/test_indexing.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_indexing.py), following                are the PEP8 issues :
> [Line 27:9](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_indexing.py#L27): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'I'
> [Line 137:9](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_indexing.py#L137): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'I'
> [Line 157:9](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_indexing.py#L157): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'I'
> [Line 214:9](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_indexing.py#L214): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'I'
> [Line 526:5](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_indexing.py#L526): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'I'


 - There are no PEP8 issues in the file [`xarray/tests/test_merge.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_merge.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_plot.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_plot.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_tutorial.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_tutorial.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_utils.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_utils.py) !

 - There are no PEP8 issues in the file [`xarray/tests/test_variable.py`](https://github.com/max-sixty/xarray/blob/391b1df5859761fc19ba520a993f343751a8b148/xarray/tests/test_variable.py) !



##### Comment last updated on October 06, 2018 at 15:15 Hours UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,367410303
https://github.com/pydata/xarray/pull/2467#issuecomment-427555865,https://api.github.com/repos/pydata/xarray/issues/2467,427555865,MDEyOklzc3VlQ29tbWVudDQyNzU1NTg2NQ==,1217238,2018-10-06T08:15:43Z,2018-10-06T08:15:43Z,MEMBER,we can probably go ahead and safely merge this in its current state -- none of my comments are deal breakers,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,367410303
https://github.com/pydata/xarray/pull/2467#issuecomment-427535714,https://api.github.com/repos/pydata/xarray/issues/2467,427535714,MDEyOklzc3VlQ29tbWVudDQyNzUzNTcxNA==,5635139,2018-10-06T01:25:22Z,2018-10-06T01:25:22Z,MEMBER,Is @pep8speaks respecting `# noqa` directions? It's still complaining about ambiguous variable names here: https://github.com/max-sixty/xarray/blob/pytest/xarray/tests/test_indexing.py#L27,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,367410303