html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2277#issuecomment-519627038,https://api.github.com/repos/pydata/xarray/issues/2277,519627038,MDEyOklzc3VlQ29tbWVudDUxOTYyNzAzOA==,2448579,2019-08-08T18:04:59Z,2019-08-08T18:04:59Z,MEMBER,Yeah! It owes a lot to your hard work too. Hopefully people find this useful.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-519579559,https://api.github.com/repos/pydata/xarray/issues/2277,519579559,MDEyOklzc3VlQ29tbWVudDUxOTU3OTU1OQ==,2448579,2019-08-08T15:57:11Z,2019-08-08T15:57:11Z,MEMBER,Merging.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-518295892,https://api.github.com/repos/pydata/xarray/issues/2277,518295892,MDEyOklzc3VlQ29tbWVudDUxODI5NTg5Mg==,2448579,2019-08-05T16:04:16Z,2019-08-05T16:04:16Z,MEMBER,"Yay, tests pass. I'll merge in a few days (cc @pydata/xarray, @yohai )","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-518044191,https://api.github.com/repos/pydata/xarray/issues/2277,518044191,MDEyOklzc3VlQ29tbWVudDUxODA0NDE5MQ==,2448579,2019-08-04T23:17:20Z,2019-08-04T23:17:20Z,MEMBER,"I don't know what to do about this test failure:
```
xarray/tests/test_plot.py .............................................. [ 92%]
........................................................................ [ 92%]
........................................................................ [ 93%]
...s.................................................................... [ 94%]
.........................Xx
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/main.py"", line 213, in wrap_session
INTERNALERROR> session.exitstatus = doit(config, session) or 0
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/main.py"", line 257, in _main
INTERNALERROR> config.hook.pytest_runtestloop(session=session)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/hooks.py"", line 289, in __call__
INTERNALERROR> return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/manager.py"", line 87, in _hookexec
INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/manager.py"", line 81, in
INTERNALERROR> firstresult=hook.spec.opts.get(""firstresult"") if hook.spec else False,
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 203, in _multicall
INTERNALERROR> gen.send(outcome)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 80, in get_result
INTERNALERROR> raise ex[1].with_traceback(ex[2])
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 187, in _multicall
INTERNALERROR> res = hook_impl.function(*args)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/main.py"", line 278, in pytest_runtestloop
INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/hooks.py"", line 289, in __call__
INTERNALERROR> return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/manager.py"", line 87, in _hookexec
INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/manager.py"", line 81, in
INTERNALERROR> firstresult=hook.spec.opts.get(""firstresult"") if hook.spec else False,
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 208, in _multicall
INTERNALERROR> return outcome.get_result()
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 80, in get_result
INTERNALERROR> raise ex[1].with_traceback(ex[2])
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 187, in _multicall
INTERNALERROR> res = hook_impl.function(*args)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/runner.py"", line 72, in pytest_runtest_protocol
INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/runner.py"", line 87, in runtestprotocol
INTERNALERROR> reports.append(call_and_report(item, ""call"", log))
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/runner.py"", line 171, in call_and_report
INTERNALERROR> hook.pytest_runtest_logreport(report=report)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/hooks.py"", line 289, in __call__
INTERNALERROR> return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/manager.py"", line 87, in _hookexec
INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/manager.py"", line 81, in
INTERNALERROR> firstresult=hook.spec.opts.get(""firstresult"") if hook.spec else False,
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 208, in _multicall
INTERNALERROR> return outcome.get_result()
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 80, in get_result
INTERNALERROR> raise ex[1].with_traceback(ex[2])
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/pluggy/callers.py"", line 187, in _multicall
INTERNALERROR> res = hook_impl.function(*args)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/junitxml.py"", line 592, in pytest_runtest_logreport
INTERNALERROR> reporter.append_skipped(report)
INTERNALERROR> File ""/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/_pytest/junitxml.py"", line 250, in append_skipped
INTERNALERROR> if xfailreason.startswith(""reason: ""):
INTERNALERROR> AttributeError: 'list' object has no attribute 'startswith'
= 7676 passed, 322 skipped, 25 xfailed, 5 xpassed, 41 warnings in 270.39 seconds =
##[error]Bash exited with code '1'.
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-504072678,https://api.github.com/repos/pydata/xarray/issues/2277,504072678,MDEyOklzc3VlQ29tbWVudDUwNDA3MjY3OA==,2448579,2019-06-20T15:30:48Z,2019-06-20T15:30:48Z,MEMBER,Maybe just read over the docs and doc strings? ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-475269561,https://api.github.com/repos/pydata/xarray/issues/2277,475269561,MDEyOklzc3VlQ29tbWVudDQ3NTI2OTU2MQ==,2448579,2019-03-21T15:11:35Z,2019-03-21T15:11:35Z,MEMBER,1/2 AppVeyor tests seems to have crashed randomly.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-470238058,https://api.github.com/repos/pydata/xarray/issues/2277,470238058,MDEyOklzc3VlQ29tbWVudDQ3MDIzODA1OA==,2448579,2019-03-06T19:15:29Z,2019-03-06T19:15:29Z,MEMBER,Failed test is #2803 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-470113191,https://api.github.com/repos/pydata/xarray/issues/2277,470113191,MDEyOklzc3VlQ29tbWVudDQ3MDExMzE5MQ==,2448579,2019-03-06T13:48:06Z,2019-03-06T13:48:06Z,MEMBER,"I went with `markersize` but am happy to change it to `mark_size` or something else.
I think I'm done here. This is missing a legend that shows the `size` variation, but otherwise it's complete. I'd like to leave the legend to a future PR if that's OK.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-463952302,https://api.github.com/repos/pydata/xarray/issues/2277,463952302,MDEyOklzc3VlQ29tbWVudDQ2Mzk1MjMwMg==,2448579,2019-02-15T08:33:45Z,2019-02-15T08:33:45Z,MEMBER,"OK PR switched to `add_guide`, this might need some reworking once we add other plotting methods for which `add_colorbar` is more sensible.
Phew! added support for `scatter_size` now.
```python
ds = xr.tutorial.scatter_example_dataset()
ds.plot.scatter(x='A', y='B', col='z', scatter_size='z')
```
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-462096487,https://api.github.com/repos/pydata/xarray/issues/2277,462096487,MDEyOklzc3VlQ29tbWVudDQ2MjA5NjQ4Nw==,2448579,2019-02-10T01:55:45Z,2019-02-10T01:55:45Z,MEMBER,Well I can't think of anything better than guide so shall we proceed with that?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-460845732,https://api.github.com/repos/pydata/xarray/issues/2277,460845732,MDEyOklzc3VlQ29tbWVudDQ2MDg0NTczMg==,2448579,2019-02-05T23:28:39Z,2019-02-05T23:28:39Z,MEMBER,"> For non-numerical hues (or when `hue_style='discrete'`) the legend is turned off by `add_legend=False` but for numerical ones by `add_colorbar=False`, which might be not intuitive and might require manual editing in various places if you change your mind between a discrete and continuous legend. I would suggest to either unify both options to one, or make them interchangeable (if not contradicting).
I'm not sure about this. Legends and colorbars are different and the `DataArray.plot` API has both switches: `add_legend` and `add_colorbar`.
@pydata/xarray what do you all think?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-460377706,https://api.github.com/repos/pydata/xarray/issues/2277,460377706,MDEyOklzc3VlQ29tbWVudDQ2MDM3NzcwNg==,2448579,2019-02-04T19:24:23Z,2019-02-04T19:24:23Z,MEMBER,"Ok this is ready for review. I haven't added `size` yet. I think we will need to go through a deprecation cycle before doing that.
One alternative would be to have `size` not control axis height in the scatter method only. I'm not a big fan of this approach though .","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-452478910,https://api.github.com/repos/pydata/xarray/issues/2277,452478910,MDEyOklzc3VlQ29tbWVudDQ1MjQ3ODkxMA==,2448579,2019-01-08T22:43:52Z,2019-01-24T06:42:21Z,MEMBER,"> This generally looks good to me...
>
> I guess we still use `s=` for indicating marker size?
Yeah. We'll need to go through a deprecation cycle to rename `size` to `height`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-448672237,https://api.github.com/repos/pydata/xarray/issues/2277,448672237,MDEyOklzc3VlQ29tbWVudDQ0ODY3MjIzNw==,2448579,2018-12-19T17:10:17Z,2018-12-19T17:11:19Z,MEMBER,"I think this is ready for a preliminary review.
I've made the following changes:
1. Add a `hue_style` kwarg that can be either 'discrete' (for legend) or 'continuous' (colorbar). `add_legend, add_colorbar` turn on/off displaying the legend/colorbar which is consistent with our existing `DataArray.plot` API.
Examples:
`ds.plot.scatter(x='A', y='B', hue='x', hue_style='discrete')`
`ds.plot.scatter(x='A', y='B', hue='x', hue_style='continuous')`
2. Under the hood, scatter is always used instead of alternating between plot, scatter depending on `hue_style`.
3. Everything has been refactored out to `plot/dataset_plot.py`
Do people like `hue_style`? Or something else?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-439959138,https://api.github.com/repos/pydata/xarray/issues/2277,439959138,MDEyOklzc3VlQ29tbWVudDQzOTk1OTEzOA==,2448579,2018-11-19T16:41:48Z,2018-11-19T16:41:48Z,MEMBER,@yohai thanks; I might make some changes in the next few weeks.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-438733826,https://api.github.com/repos/pydata/xarray/issues/2277,438733826,MDEyOklzc3VlQ29tbWVudDQzODczMzgyNg==,2448579,2018-11-14T16:50:25Z,2018-11-14T16:50:25Z,MEMBER,@yohai do you have time to pick this back up?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538