html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2277#issuecomment-504072683,https://api.github.com/repos/pydata/xarray/issues/2277,504072683,MDEyOklzc3VlQ29tbWVudDUwNDA3MjY4Mw==,1217238,2019-06-20T15:30:49Z,2019-06-20T15:30:49Z,MEMBER,"Tests seem to be failing due to lint errors, see https://github.com/pydata/xarray/pull/2277#issuecomment-447607250","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-504054087,https://api.github.com/repos/pydata/xarray/issues/2277,504054087,MDEyOklzc3VlQ29tbWVudDUwNDA1NDA4Nw==,1217238,2019-06-20T14:44:07Z,2019-06-20T14:44:07Z,MEMBER,"I haven't reviewed this in detail, but I wonder if we shouldn't just merge it in. This has tests and docs, and most of this has been looked over by both @dcherian and @yohai. Also, it's in a pretty self-contained part of the code (plotting). So it seems pretty slow risk to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-469148347,https://api.github.com/repos/pydata/xarray/issues/2277,469148347,MDEyOklzc3VlQ29tbWVudDQ2OTE0ODM0Nw==,1217238,2019-03-04T07:36:59Z,2019-03-04T07:36:59Z,MEMBER,Could we call this `mark_size` instead of `scatter_size`? The later sounds a little awkward to me.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-461113679,https://api.github.com/repos/pydata/xarray/issues/2277,461113679,MDEyOklzc3VlQ29tbWVudDQ2MTExMzY3OQ==,1217238,2019-02-06T17:33:38Z,2019-02-06T17:33:38Z,MEMBER,"> I'm not sure about this. Legends and colorbars are different and the `DataArray.plot` API has both switches: `add_legend` and `add_colorbar`.

Is there a generic term that covers both discrete legends and colorbars?

ggplot2 uses [""guide""](https://ggplot2.tidyverse.org/reference/index.html#section-guides-axes-and-legends) but I haven't seen that elsewhere. Still, `add_guide=False` could be a good way to write this genericly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-451507184,https://api.github.com/repos/pydata/xarray/issues/2277,451507184,MDEyOklzc3VlQ29tbWVudDQ1MTUwNzE4NA==,1217238,2019-01-04T17:14:37Z,2019-01-04T17:14:37Z,MEMBER,"This generally looks good to me...

I guess we still use `s=` for indicating marker size?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-407198140,https://api.github.com/repos/pydata/xarray/issues/2277,407198140,MDEyOklzc3VlQ29tbWVudDQwNzE5ODE0MA==,1217238,2018-07-23T20:55:41Z,2018-07-23T20:55:41Z,MEMBER,"> The reason I started this PR in the first place is that I happened to do relatively simple scatter plots quite often, so I thought it'd be handy. but for more elaborate ones I would use a dedicated tool like seaborn.

:+1:  This seems like a reasonable place to draw the line to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-405450382,https://api.github.com/repos/pydata/xarray/issues/2277,405450382,MDEyOklzc3VlQ29tbWVudDQwNTQ1MDM4Mg==,1217238,2018-07-17T03:44:11Z,2018-07-17T03:44:11Z,MEMBER,"This is looking really nice. Coincidentally, the new version of Seaborn was released today, and has a whole new doc section on ""relational plots"": http://seaborn.pydata.org/tutorial/relational.html#relational-tutorial

It's probably worth a look over to see if it has good ideas worth stealing, or if we want to make intentional deviations from its behavior in xarray.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-405289693,https://api.github.com/repos/pydata/xarray/issues/2277,405289693,MDEyOklzc3VlQ29tbWVudDQwNTI4OTY5Mw==,1217238,2018-07-16T15:38:08Z,2018-07-16T15:38:08Z,MEMBER,"It is possibly worth taking a look at the recent (not yet released) `scatterplot` (https://github.com/mwaskom/seaborn/pull/1436) and `relplot` (https://github.com/mwaskom/seaborn/pull/1477) additions to Seaborn.

`seaborn.scatterplot` will use `hue`/`size` rather than `c`/`s`, which is definitely more readable. One hazard is that it it means that the `size` argument from `seaborn.FacetGrid` needs to be renamed to avoid name conflicts -- it's now becoming `height`. Unfortunately we would also need to rename the `size` argument if we followed Seaborn's example.

I guess I can see the virtue in sticking with matplotlib's old `c`/`s` names, but those really are terrible names. Maybe `hue`/`mark_size` would be a good compromise? Or we could systematically switch `size` -> `height` elsewhere like Seaborn.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538
https://github.com/pydata/xarray/pull/2277#issuecomment-405145682,https://api.github.com/repos/pydata/xarray/issues/2277,405145682,MDEyOklzc3VlQ29tbWVudDQwNTE0NTY4Mg==,1217238,2018-07-16T04:15:47Z,2018-07-16T04:15:47Z,MEMBER,"> You should try to emulate the pandas scatter api as much as possible (which itself emulates the matplotlib api). That means using the c keyword instead of hue and also implementing s for size.

I disagree here. In many cases, we already follow the naming conventions from Seaborn instead, which uses meaningful names. c and s are pretty meaningless.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340069538