html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2152#issuecomment-432145295,https://api.github.com/repos/pydata/xarray/issues/2152,432145295,MDEyOklzc3VlQ29tbWVudDQzMjE0NTI5NQ==,2448579,2018-10-23T08:19:46Z,2018-10-23T08:19:46Z,MEMBER,"Failed test is cfgrib test.
Thanks @maahn ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-428458679,https://api.github.com/repos/pydata/xarray/issues/2152,428458679,MDEyOklzc3VlQ29tbWVudDQyODQ1ODY3OQ==,24736507,2018-10-10T06:53:49Z,2018-10-23T06:44:34Z,NONE,"Hello @maahn! Thanks for updating the PR.
- There are no PEP8 issues in the file [`xarray/plot/__init__.py`](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/plot/__init__.py) !
- In the file [`xarray/plot/plot.py`](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/plot/plot.py), following are the PEP8 issues :
> [Line 1062:13](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/plot/plot.py#L1062): [W504](https://duckduckgo.com/?q=pep8%20W504) line break after binary operator
> [Line 1063:14](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/plot/plot.py#L1063): [W504](https://duckduckgo.com/?q=pep8%20W504) line break after binary operator
> [Line 1072:13](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/plot/plot.py#L1072): [W504](https://duckduckgo.com/?q=pep8%20W504) line break after binary operator
- There are no PEP8 issues in the file [`xarray/plot/utils.py`](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/plot/utils.py) !
- There are no PEP8 issues in the file [`xarray/tests/test_plot.py`](https://github.com/maahn/xarray/blob/448d6b751379ef7ab67c9287ecbd5ce231a35c66/xarray/tests/test_plot.py) !
##### Comment last updated on October 23, 2018 at 06:44 Hours UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-428629924,https://api.github.com/repos/pydata/xarray/issues/2152,428629924,MDEyOklzc3VlQ29tbWVudDQyODYyOTkyNA==,222557,2018-10-10T16:00:14Z,2018-10-10T16:00:14Z,NONE,"great, thanks for taking care of that! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-428458765,https://api.github.com/repos/pydata/xarray/issues/2152,428458765,MDEyOklzc3VlQ29tbWVudDQyODQ1ODc2NQ==,2448579,2018-10-10T06:54:07Z,2018-10-10T06:54:07Z,MEMBER,"Really sorry for the delay, @maahn.
I've merged master, refactored out the utility functions to `utils.py`, fixed the tests locally and added a whats-new entry. I'll merge once this round of tests pass.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-411840526,https://api.github.com/repos/pydata/xarray/issues/2152,411840526,MDEyOklzc3VlQ29tbWVudDQxMTg0MDUyNg==,222557,2018-08-09T17:46:03Z,2018-08-09T17:46:03Z,NONE,"Sorry, for the delay, I finally merged upstream. Looks like the failed builds are unrelated to my changes, so it should be ready for merging? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-395802950,https://api.github.com/repos/pydata/xarray/issues/2152,395802950,MDEyOklzc3VlQ29tbWVudDM5NTgwMjk1MA==,222557,2018-06-08T15:46:38Z,2018-06-08T15:46:38Z,NONE,Thanks for the review.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-394800550,https://api.github.com/repos/pydata/xarray/issues/2152,394800550,MDEyOklzc3VlQ29tbWVudDM5NDgwMDU1MA==,222557,2018-06-05T17:49:19Z,2018-06-05T17:51:53Z,NONE,"Good idea, it turned out the step function was quite easy to implement by using https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/axes/_axes.py#L1735
So now, 1D data defaults to the standard line plot, but you can use plot.step() instead. I guess changing the default plot to something more sophisticated would make the simple logic in plot() to determine the default quite complex?
See https://gist.github.com/maahn/91da0a8d299ef6567827749cbe2f1913","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-393211218,https://api.github.com/repos/pydata/xarray/issues/2152,393211218,MDEyOklzc3VlQ29tbWVudDM5MzIxMTIxOA==,1217238,2018-05-30T15:42:39Z,2018-05-30T15:42:39Z,MEMBER,"Rather than using `interval_step_plot=True`, what about making an entirely new plot method, `plot.step()`? That would feel a little cleaner to me.
I'm not sure that a step plot would be preferred by most users for a plot over an axis on which groupby_bins was applied. Personally, I would probably prefer a line + scatter plot (e.g., `marker='s'`). Maybe @rabernat (groupby_bins author) has opinions here?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-392944474,https://api.github.com/repos/pydata/xarray/issues/2152,392944474,MDEyOklzc3VlQ29tbWVudDM5Mjk0NDQ3NA==,222557,2018-05-29T21:04:51Z,2018-05-29T21:04:51Z,NONE,"Ok, I added the interval_step_plot kwarg (default True) to the 1D line plot to make a step plot with the real (i.e. not interpolated) boundaries. After that I had the feeling that it's inconsistent if line uses the real boundaries but pcolormesh doesn't. So I also patched that, but I had to disable infer_intervals for these cases. See also:
https://gist.github.com/maahn/91da0a8d299ef6567827749cbe2f1913/530ed7bf77c9c3257cab46c3894c1412085a217a
Let me know what you think and I will also add some documentation.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-391413132,https://api.github.com/repos/pydata/xarray/issues/2152,391413132,MDEyOklzc3VlQ29tbWVudDM5MTQxMzEzMg==,1217238,2018-05-23T16:31:07Z,2018-05-23T16:31:07Z,MEMBER,"A couple of other thoughts:
1. For 2D plots that already show regions (imshow/pcolormesh), I'm not sure it makes sense to update the label to include the word ""center"". This plot around shows intervals pretty clearly:
2. This needs tests, at least something to make sure that plotting with an Intervals on an axis does not crash in xarray/tests/test_plot.py","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-391026312,https://api.github.com/repos/pydata/xarray/issues/2152,391026312,MDEyOklzc3VlQ29tbWVudDM5MTAyNjMxMg==,222557,2018-05-22T15:07:48Z,2018-05-22T15:07:48Z,NONE,"Thanks, for the comment, but I wouldn't use center labels when using `groupby_bins` by default, that could be misleading in case of non-uniform (e.g. exponential) bin spacing. I guess that's acceptable for a plot, but not for a DataArray, because the information about the boundaries would be lost. And from a user perspective, I would find it a bit confusing if an additional coordinate would show up when using `groupby_bins`. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458
https://github.com/pydata/xarray/pull/2152#issuecomment-389939666,https://api.github.com/repos/pydata/xarray/issues/2152,389939666,MDEyOklzc3VlQ29tbWVudDM4OTkzOTY2Ng==,1197350,2018-05-17T17:07:21Z,2018-05-17T17:07:21Z,MEMBER,"This seems like a good idea.
`groupby_bins` has a `labels` option, which can override the default labels generated by pandas. That's what is done in the (multidimensional groupby example](http://xarray.pydata.org/en/stable/examples/multidimensional-coords.html#multidimensional-groupby).
I wonder if it's worth just making this behavior the default, or generating an additional coordinate for the bin centers automatically.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324105458