html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2107#issuecomment-400617636,https://api.github.com/repos/pydata/xarray/issues/2107,400617636,MDEyOklzc3VlQ29tbWVudDQwMDYxNzYzNg==,26040812,2018-06-27T10:09:18Z,2018-06-27T10:09:18Z,NONE,"This is an amazing addition.
Thanks @yohai ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-394406007,https://api.github.com/repos/pydata/xarray/issues/2107,394406007,MDEyOklzc3VlQ29tbWVudDM5NDQwNjAwNw==,1217238,2018-06-04T15:54:51Z,2018-06-04T15:54:51Z,MEMBER,thanks @yohai!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-394060337,https://api.github.com/repos/pydata/xarray/issues/2107,394060337,MDEyOklzc3VlQ29tbWVudDM5NDA2MDMzNw==,1217238,2018-06-02T05:33:27Z,2018-06-02T05:33:27Z,MEMBER,"It looks like the merge went OK, but you have a couple of tests that are failing. Click on the ""Travis-CI"" link above next to the red ""X"" to see details:
https://travis-ci.org/pydata/xarray/jobs/386973465","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-394058188,https://api.github.com/repos/pydata/xarray/issues/2107,394058188,MDEyOklzc3VlQ29tbWVudDM5NDA1ODE4OA==,6164157,2018-06-02T04:47:05Z,2018-06-02T04:47:05Z,CONTRIBUTOR,"OK, somehow the rebasing thing broke everything and I am at a loss. @shoyer, @dcherian please guide me on how to proceed. Sorry.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-394040124,https://api.github.com/repos/pydata/xarray/issues/2107,394040124,MDEyOklzc3VlQ29tbWVudDM5NDA0MDEyNA==,1217238,2018-06-02T00:12:59Z,2018-06-02T00:12:59Z,MEMBER,"> Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function _line_facetgrid, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run pytest locally these lines do get tested (I verified by adding print commands there).
Should I add decorators like pytest.mark.somethingfor coverall to notice these tests?
The specific problematic lines are those marked red in coveralls, e.g.,
https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L101
https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L176
https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L291
These are all cases where an error is raised.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-393897686,https://api.github.com/repos/pydata/xarray/issues/2107,393897686,MDEyOklzc3VlQ29tbWVudDM5Mzg5NzY4Ng==,6164157,2018-06-01T14:27:48Z,2018-06-01T14:27:48Z,CONTRIBUTOR,"Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function `_line_facetgrid`, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run `pytest` locally these lines do get tested (I verified by adding `print` commands there).
Should I add decorators like `pytest.mark.something`for coverall to notice these tests?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-393018032,https://api.github.com/repos/pydata/xarray/issues/2107,393018032,MDEyOklzc3VlQ29tbWVudDM5MzAxODAzMg==,6164157,2018-05-30T03:22:16Z,2018-05-30T03:22:16Z,CONTRIBUTOR,"I wrote some tests and also followed @shoyer's suggestion to make the plots look more like seaborn. Here's what it looks like now:
I also had to refactor the code adding legend to a line plot to avoid duplicities.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-388637796,https://api.github.com/repos/pydata/xarray/issues/2107,388637796,MDEyOklzc3VlQ29tbWVudDM4ODYzNzc5Ng==,10050469,2018-05-13T16:09:45Z,2018-05-13T16:09:45Z,MEMBER,"> writing new functions that will verify that stuff works as it should
Yes. See [here](https://github.com/pydata/xarray/blob/master/xarray/tests/test_plot.py#L1223) for example tests for FacetGrid. Testing plotting functions is not trivial but we usually test only very
basic functionality. You might find some examples in here.
> or that the new addition does not mess up previous plotting behavior?
This is usually covered by continuous integration, which already ran the tests on your current PR
(the ""all checks have passed"" green button above). So on this side you are safe for now, unless
our previous tests weren't efficient enough ;-)","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-388635575,https://api.github.com/repos/pydata/xarray/issues/2107,388635575,MDEyOklzc3VlQ29tbWVudDM4ODYzNTU3NQ==,6164157,2018-05-13T15:34:39Z,2018-05-13T15:34:39Z,CONTRIBUTOR,"@jhamman @shoyer Sorry for being a noob, but what exactly do you mean by ""add some basic unit tests""? you mean writing new functions that will verify that stuff works as it should, or that the new addition does not mess up previous plotting behavior?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-387798725,https://api.github.com/repos/pydata/xarray/issues/2107,387798725,MDEyOklzc3VlQ29tbWVudDM4Nzc5ODcyNQ==,2443309,2018-05-09T16:33:31Z,2018-05-09T16:33:31Z,MEMBER,@yohai - this looks great. Can we add some basic unit tests covering this functionality? ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-387196472,https://api.github.com/repos/pydata/xarray/issues/2107,387196472,MDEyOklzc3VlQ29tbWVudDM4NzE5NjQ3Mg==,6164157,2018-05-07T20:33:19Z,2018-05-07T20:33:19Z,CONTRIBUTOR,was simpler than I thought. @shoyer I added the plots.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-386922376,https://api.github.com/repos/pydata/xarray/issues/2107,386922376,MDEyOklzc3VlQ29tbWVudDM4NjkyMjM3Ng==,6164157,2018-05-06T22:40:43Z,2018-05-07T20:31:19Z,CONTRIBUTOR,"Example code to demonstrate functionality:
```python
import xarray as xr
import numpy as np
import pandas as pd
np.random.seed(0)
tm = pd.date_range('2000-01-01', end='2000-01-02', freq='H')
d4 = xr.DataArray(np.random.randn(len(tm), 6, 3, 3),
dims=['time', 'x', 'text_dim', 'z'],
coords=[tm, range(6), ['foo', 'bar', 'foobar'], [3.5, 4.9, 6.7]],
name='arr_name')
d3 = d4[..., 0].drop('z')
d2 = d3[..., 0].drop('text_dim')
# generate a faceted 4-dimensional plot:
d4.plot(hue='text_dim', col='x', row='z')
# or equivalently:
# d4.plot.line(x='time', col='x', row='z')
````
````python
d3.plot(col='x', row='text_dim')
````
````python
d2.plot(hue='x')
````
````python
d3.plot.line(col='x', col_wrap=3, hue='text_dim')
````
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-387174940,https://api.github.com/repos/pydata/xarray/issues/2107,387174940,MDEyOklzc3VlQ29tbWVudDM4NzE3NDk0MA==,6164157,2018-05-07T19:24:12Z,2018-05-07T19:24:12Z,CONTRIBUTOR,I found some bugs. I'll reopen when I fix them.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-386927718,https://api.github.com/repos/pydata/xarray/issues/2107,386927718,MDEyOklzc3VlQ29tbWVudDM4NjkyNzcxOA==,1217238,2018-05-07T00:15:20Z,2018-05-07T00:15:20Z,MEMBER,"I'm really excited about this!
Could you kindly paste in examples of what the generated plots look like in your comment? (GitHub will upload an image when you paste it in.)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674