html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1924#issuecomment-368910446,https://api.github.com/repos/pydata/xarray/issues/1924,368910446,MDEyOklzc3VlQ29tbWVudDM2ODkxMDQ0Ng==,5635139,2018-02-27T15:12:12Z,2018-02-27T15:28:14Z,MEMBER,"@jhamman @shoyer green!
No auto-check, but easier to add those in the future than thrash between too lenient and too harsh, imo","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367783314,https://api.github.com/repos/pydata/xarray/issues/1924,367783314,MDEyOklzc3VlQ29tbWVudDM2Nzc4MzMxNA==,5635139,2018-02-22T18:55:29Z,2018-02-22T18:55:29Z,MEMBER,"> I would also be OK with just fixing this up in occasional cleanup PR.
Would you prefer in allowed failures, or that's a bad middle-ground?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367783002,https://api.github.com/repos/pydata/xarray/issues/1924,367783002,MDEyOklzc3VlQ29tbWVudDM2Nzc4MzAwMg==,5635139,2018-02-22T18:54:22Z,2018-02-22T18:54:52Z,MEMBER,"> as comments on a PR
\+ the really cool feature is that it'll add commits with changes, where it can","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367778882,https://api.github.com/repos/pydata/xarray/issues/1924,367778882,MDEyOklzc3VlQ29tbWVudDM2Nzc3ODg4Mg==,1217238,2018-02-22T18:40:49Z,2018-02-22T18:40:49Z,MEMBER,"I would also be OK with just fixing this up in occasional cleanup PR.
If Stickler-CI supported this that might be a decisive consideration in terms of enforcing it. Certainly it's a better experience for contributors to get formatting errors as comments on a PR rather than a failed build.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367778778,https://api.github.com/repos/pydata/xarray/issues/1924,367778778,MDEyOklzc3VlQ29tbWVudDM2Nzc3ODc3OA==,221526,2018-02-22T18:40:25Z,2018-02-22T18:40:25Z,CONTRIBUTOR,"I don't have much preference between the two--I picked one and it worked for me. I just fixed up the initial import cleanups by hand and didn't find the need for a tool to do so.
In my experience, having formatting errors hold up a PR hasn't been a problem. IMO, import ordering is a more important style issue than many of the things that flake8 catches.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367776962,https://api.github.com/repos/pydata/xarray/issues/1924,367776962,MDEyOklzc3VlQ29tbWVudDM2Nzc3Njk2Mg==,5635139,2018-02-22T18:34:21Z,2018-02-22T18:35:06Z,MEMBER,"We use [flake8-isort](https://github.com/gforcada/flake8-isort), which implements `isort` itself in `flake8`. @dopplershift do you have a view between them?
One advantage of `isort` is that there's a link between the formatter and the checker, so running `isort` can never cause errors.
But stepping back, we should think about whether we want to mandate this on every PR. It doesn't matter _that_ much (less than flake8 imo), and it can be frustrating to have formatting errors get in the way of a PR. A tool that automatically corrects the code like @stickler-ci is great, but it doesn't support this one.
A compromise could be to put it in allowed failures in Travis? Or if people think we should add this, let's do it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367771955,https://api.github.com/repos/pydata/xarray/issues/1924,367771955,MDEyOklzc3VlQ29tbWVudDM2Nzc3MTk1NQ==,221526,2018-02-22T18:17:27Z,2018-02-22T18:17:27Z,CONTRIBUTOR,"I recommend [flake8-import-order](https://github.com/PyCQA/flake8-import-order). If you install that plugin, then flake8 will enforce import ordering and grouping.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367577212,https://api.github.com/repos/pydata/xarray/issues/1924,367577212,MDEyOklzc3VlQ29tbWVudDM2NzU3NzIxMg==,1217238,2018-02-22T06:05:54Z,2018-02-22T06:05:54Z,MEMBER,"Is it possible to enforce this programmatically, e.g., with flake8?
I'm a little surprised flake8 doesn't already require sorted imports by default. We use a modified version of pylint internally at Google that does this.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-367076037,https://api.github.com/repos/pydata/xarray/issues/1924,367076037,MDEyOklzc3VlQ29tbWVudDM2NzA3NjAzNw==,5635139,2018-02-20T18:39:40Z,2018-02-20T18:39:40Z,MEMBER,Updated,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967
https://github.com/pydata/xarray/pull/1924#issuecomment-366840478,https://api.github.com/repos/pydata/xarray/issues/1924,366840478,MDEyOklzc3VlQ29tbWVudDM2Njg0MDQ3OA==,5635139,2018-02-20T01:18:43Z,2018-02-20T01:18:43Z,MEMBER,Requires https://github.com/pydata/xarray/pull/1925 to make @stickler-ci happy (and this needs to stop the `I002` disabling when that is merged),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,298437967