html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1885#issuecomment-366540505,https://api.github.com/repos/pydata/xarray/issues/1885,366540505,MDEyOklzc3VlQ29tbWVudDM2NjU0MDUwNQ==,1386642,2018-02-18T19:26:31Z,2018-02-18T19:26:31Z,CONTRIBUTOR,cool! Thanks,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-366468848,https://api.github.com/repos/pydata/xarray/issues/1885,366468848,MDEyOklzc3VlQ29tbWVudDM2NjQ2ODg0OA==,1386642,2018-02-17T20:24:36Z,2018-02-17T20:24:36Z,CONTRIBUTOR,I just rebased onto master.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-365372937,https://api.github.com/repos/pydata/xarray/issues/1885,365372937,MDEyOklzc3VlQ29tbWVudDM2NTM3MjkzNw==,1386642,2018-02-13T19:15:30Z,2018-02-13T19:15:47Z,CONTRIBUTOR,no problem. I have always preferred putting operators on new lines though. Didn't realize that was against pep8. oh well 🤷‍♂️ . ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-365332360,https://api.github.com/repos/pydata/xarray/issues/1885,365332360,MDEyOklzc3VlQ29tbWVudDM2NTMzMjM2MA==,1386642,2018-02-13T17:01:26Z,2018-02-13T17:01:26Z,CONTRIBUTOR,"> Sorry @nbren12 there is still a pep8 error somewhere, and you can freely make it an error as @shoyer suggests. Hopefully, the commit I just pushed fixes this. I had some global flake8 settings that were messing with my local linting. > Note that currently the test for monotonic coords is for `pcolormesh` only, while it could be for all 2d plots as well. I don't think I was having any issues with `contour` or `contourf` when I first opened the issue, but it probably does break `imshow`. > If we start to check input for sanity we might as well raise an error when coordinates are not regularly spaced in the imshow case. Maybe we could leave this to a later PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-363533796,https://api.github.com/repos/pydata/xarray/issues/1885,363533796,MDEyOklzc3VlQ29tbWVudDM2MzUzMzc5Ng==,1386642,2018-02-06T19:17:40Z,2018-02-06T19:17:40Z,CONTRIBUTOR,"Yah. I knew my solution before was probably too cute. On Tue, Feb 6, 2018 at 11:14 AM, Fabien Maussion wrote: > Thanks! This looks good. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , or mute > the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-363531759,https://api.github.com/repos/pydata/xarray/issues/1885,363531759,MDEyOklzc3VlQ29tbWVudDM2MzUzMTc1OQ==,1386642,2018-02-06T19:11:04Z,2018-02-06T19:11:04Z,CONTRIBUTOR,There. I think this code should work for all dtypes and 2D coords. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-362992657,https://api.github.com/repos/pydata/xarray/issues/1885,362992657,MDEyOklzc3VlQ29tbWVudDM2Mjk5MjY1Nw==,1386642,2018-02-05T06:24:40Z,2018-02-05T06:24:40Z,CONTRIBUTOR,"> One reason is that it's not obvious if they would like increasing or decreasing coordinates. For me at least, `plt.pcolormesh` automatically displays in increasing order even if one of the input arrays is sorted in descending order. This happens all the time with meteorological data available in pressure coordinates (pressure goes down with height). I usually have to manually call plt.gca().invert_yaxis() to flip the y axis. Does `xarray.plot`'s behave differently?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-362990917,https://api.github.com/repos/pydata/xarray/issues/1885,362990917,MDEyOklzc3VlQ29tbWVudDM2Mjk5MDkxNw==,1386642,2018-02-05T06:12:08Z,2018-02-05T06:12:08Z,CONTRIBUTOR,"@shoyer That would work with me. Is there any chance people would want to make heatmaps involving categorical variables though? If we do decide to raise an error, why not go one step further and just sort the coordinates automatically? On Sun, Feb 4, 2018 at 4:00 PM, Stephan Hoyer wrote: > *@shoyer* commented on this pull request. > ------------------------------ > > In xarray/plot/plot.py > : > > > @@ -750,6 +767,13 @@ def _infer_interval_breaks(coord, axis=0): > [ 2.5, 3.5, 4.5]]) > """""" > coord = np.asarray(coord) > + > + if not _is_monotonic(coord, axis=axis): > + warnings.warn(""The input coordinate is not sorted in increasing order "" > > Rather an a warning, why not make this an error? I don't see any use-cases > for 2d plots with non-monotonic coordinates. With the current version of > xarray, these plots always end up wrong in some way, either by not plotting > everything or with bad axis labels. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-362853059,https://api.github.com/repos/pydata/xarray/issues/1885,362853059,MDEyOklzc3VlQ29tbWVudDM2Mjg1MzA1OQ==,1386642,2018-02-03T20:47:30Z,2018-02-03T20:47:30Z,CONTRIBUTOR,Ok. I think everything is ready now.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233 https://github.com/pydata/xarray/pull/1885#issuecomment-362836782,https://api.github.com/repos/pydata/xarray/issues/1885,362836782,MDEyOklzc3VlQ29tbWVudDM2MjgzNjc4Mg==,1386642,2018-02-03T17:21:16Z,2018-02-03T17:21:16Z,CONTRIBUTOR,Thanks for your help @fmaussion. Hopefully the commit I just pushed fixes the failing tests. I will work on adding a test and fixing the formatting.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,294089233