html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1828#issuecomment-357750708,https://api.github.com/repos/pydata/xarray/issues/1828,357750708,MDEyOklzc3VlQ29tbWVudDM1Nzc1MDcwOA==,5635139,2018-01-15T17:51:33Z,2018-01-15T17:51:33Z,MEMBER,"> Using pip seems to temporary solve this issue.

Nice, thanks. I've put this in. If we're on the way to deprecate 3.4, from which source we install pytest is flexible IMHO","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357750095,https://api.github.com/repos/pydata/xarray/issues/1828,357750095,MDEyOklzc3VlQ29tbWVudDM1Nzc1MDA5NQ==,5635139,2018-01-15T17:48:53Z,2018-01-15T17:48:53Z,MEMBER,"> There are two comment-outed lines using self.assertEqual in test_dataarray and test_dataset.

That are comment-out as part of this PR? Or prior? If prior, then I think we should leave until we attempt to add those back in

> We are still using some methods of TestCase class, such as assertVariableNotEqual.
Can we add equivalent function to testings.py?

I think the best way of handling those is xfailing an `assert_equal` test, rather than having a extra `-not` test for each variant. I also think we should do that in a separate PR (generally am keen to get this in before there are divergences)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357638969,https://api.github.com/repos/pydata/xarray/issues/1828,357638969,MDEyOklzc3VlQ29tbWVudDM1NzYzODk2OQ==,6815844,2018-01-15T10:14:25Z,2018-01-15T10:14:25Z,MEMBER,"There are two comment-outed lines using `self.assertEqual` in test_dataarray and test_dataset.

We are still using some methods of `TestCase` class, such as `assertVariableNotEqual`.
Can we add equivalent function to testings.py?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357620123,https://api.github.com/repos/pydata/xarray/issues/1828,357620123,MDEyOklzc3VlQ29tbWVudDM1NzYyMDEyMw==,6815844,2018-01-15T08:59:29Z,2018-01-15T08:59:29Z,MEMBER,"Using pip seems to temporary solve this issue.
ci/requirements-py34.yml
```
name: test_env
dependencies:
  - python=3.4
  - bottleneck
  - flake8
  - pandas
  - pip:
    - coveralls
    - pytest>=3.3
    - pytest-cov
```

maybe not the best solution, though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357570175,https://api.github.com/repos/pydata/xarray/issues/1828,357570175,MDEyOklzc3VlQ29tbWVudDM1NzU3MDE3NQ==,2443309,2018-01-15T02:50:49Z,2018-01-15T02:50:49Z,MEMBER,@maxim-lian - I opened https://github.com/pydata/xarray/issues/1829 to discuss dropping Python 3.4.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357562144,https://api.github.com/repos/pydata/xarray/issues/1828,357562144,MDEyOklzc3VlQ29tbWVudDM1NzU2MjE0NA==,5635139,2018-01-15T01:38:09Z,2018-01-15T01:38:09Z,MEMBER,"Tests now pass, including flake8, apart from the pytest.warns.

Given how much code this touches, I'm keen to merge this ASAP, before divergences creep in. What's the best course on 3.4? pandas is in the process of [dropping](https://github.com/pandas-dev/pandas/issues/15251) it. 

Alternatively I could revert the `pytest.warns` changes, though there isn't one clean commit to revert.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357542566,https://api.github.com/repos/pydata/xarray/issues/1828,357542566,MDEyOklzc3VlQ29tbWVudDM1NzU0MjU2Ng==,5635139,2018-01-14T21:08:24Z,2018-01-14T21:08:24Z,MEMBER,"> Are you going to make our tests more pytest-ized (e.g. by adopting more @pytest.mark.parametrize)?

Not yet, I think that's a bigger exercise, and more difficult to script","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105
https://github.com/pydata/xarray/pull/1828#issuecomment-357541210,https://api.github.com/repos/pydata/xarray/issues/1828,357541210,MDEyOklzc3VlQ29tbWVudDM1NzU0MTIxMA==,5635139,2018-01-14T20:48:56Z,2018-01-14T20:48:56Z,MEMBER,"I think this is now passing throughout except for Python3.4, which I think is because pytest is on version [3.0.5](https://travis-ci.org/pydata/xarray/jobs/328818925#L1118), which doesn't have the `match` keyword from pytest 3.3.

Does anyone know why an old version of pytest is being installed there? From what I can see on the [pytest home page](https://docs.pytest.org/en/latest/getting-started.html), 3.4 is fully supported, and the [3.4 ci requirements](https://github.com/pydata/xarray/blob/master/ci/requirements-py34.yml#L5) don't force a lower version of pytest.

I could unravel that but if anyone has insight (and is anyone using 3.4? Though this PR prob not the place to make that decision)

I think we should try and merge this asap, as there are going to be (manageable) merge conflicts with other branches","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288382105