html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1826#issuecomment-393366280,https://api.github.com/repos/pydata/xarray/issues/1826,393366280,MDEyOklzc3VlQ29tbWVudDM5MzM2NjI4MA==,5635139,2018-05-31T00:53:25Z,2018-05-31T00:53:25Z,MEMBER,Thanks @shoyer !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-393332974,https://api.github.com/repos/pydata/xarray/issues/1826,393332974,MDEyOklzc3VlQ29tbWVudDM5MzMzMjk3NA==,5635139,2018-05-30T21:56:52Z,2018-05-30T21:56:52Z,MEMBER,Gentlest of pings (but tell me if pings are not helpful - especially given I disappear for a few weeks),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-392597483,https://api.github.com/repos/pydata/xarray/issues/1826,392597483,MDEyOklzc3VlQ29tbWVudDM5MjU5NzQ4Mw==,5635139,2018-05-28T20:18:30Z,2018-05-28T20:19:03Z,MEMBER,"I've updated this. 

My penultimate commit was a simple copy/paste of @shoyer recommended approach. The final commit is the same approach at a slightly different point in the call stack, which I think is better encapsulated. But - as ever - v open to feedback","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-377664335,https://api.github.com/repos/pydata/xarray/issues/1826,377664335,MDEyOklzc3VlQ29tbWVudDM3NzY2NDMzNQ==,5635139,2018-03-31T04:11:06Z,2018-03-31T04:11:06Z,MEMBER,@shoyer gentlest of pings,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-377035720,https://api.github.com/repos/pydata/xarray/issues/1826,377035720,MDEyOklzc3VlQ29tbWVudDM3NzAzNTcyMA==,5635139,2018-03-28T21:03:24Z,2018-03-28T21:03:24Z,MEMBER,"Green @shoyer 

But do let me know if this may still be missing something","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-376739482,https://api.github.com/repos/pydata/xarray/issues/1826,376739482,MDEyOklzc3VlQ29tbWVudDM3NjczOTQ4Mg==,5635139,2018-03-28T02:28:40Z,2018-03-28T02:29:00Z,MEMBER,I think tests are failing for other reasons? https://travis-ci.org/maxim-lian/xarray/builds/359165503,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-370119540,https://api.github.com/repos/pydata/xarray/issues/1826,370119540,MDEyOklzc3VlQ29tbWVudDM3MDExOTU0MA==,5635139,2018-03-03T05:10:42Z,2018-03-03T05:10:42Z,MEMBER,"@shoyer Green!

Is that what you were thinking re the additional tests? Lmk if more would be helpful","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-368389025,https://api.github.com/repos/pydata/xarray/issues/1826,368389025,MDEyOklzc3VlQ29tbWVudDM2ODM4OTAyNQ==,5635139,2018-02-26T04:46:32Z,2018-02-26T04:46:32Z,MEMBER,@shoyer any feedback?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-366839865,https://api.github.com/repos/pydata/xarray/issues/1826,366839865,MDEyOklzc3VlQ29tbWVudDM2NjgzOTg2NQ==,5635139,2018-02-20T01:14:10Z,2018-02-20T01:14:10Z,MEMBER,@shoyer ready for review,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-364500636,https://api.github.com/repos/pydata/xarray/issues/1826,364500636,MDEyOklzc3VlQ29tbWVudDM2NDUwMDYzNg==,5635139,2018-02-09T17:25:42Z,2018-02-09T17:25:42Z,MEMBER,"> This is much simpler than I expected - have I missed something basic here?

Yes I had.

I've spent some time working through some cases and tripped myself up a few times. 

Still working on it (though mainly when I'm on a plane). If I can't resolve some issues I may post some questions here","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213
https://github.com/pydata/xarray/pull/1826#issuecomment-357472742,https://api.github.com/repos/pydata/xarray/issues/1826,357472742,MDEyOklzc3VlQ29tbWVudDM1NzQ3Mjc0Mg==,5635139,2018-01-13T22:36:21Z,2018-01-13T22:36:21Z,MEMBER,This is much simpler than I expected - have I missed something basic here?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288365213