html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1824#issuecomment-357442522,https://api.github.com/repos/pydata/xarray/issues/1824,357442522,MDEyOklzc3VlQ29tbWVudDM1NzQ0MjUyMg==,306380,2018-01-13T15:14:27Z,2018-01-13T15:14:27Z,MEMBER,"Huzzah.  Thanks Zac for picking this up

On Sat, Jan 13, 2018 at 6:37 AM, Zac Hatfield Dodds <
notifications@github.com> wrote:

> Closes #1741 <https://github.com/pydata/xarray/pull/1741> by @mrocklin
> <https://github.com/mrocklin> (who did most of the work I'm presenting
> here). I had an evening free, so I rebased the previous pull on master,
> fixed the conflicts, and then made everything pass with flake8's default
> settings (including line length). My condolences to whoever gets to
> *review* this diff!
>
> The single change any non-pedant will notice: Travis now fails if there is
> a flake8 warning anywhere. My experience in other projects is that this is
> the only way to actually *keep* flake8 passing - it's just unrealistic to
> expect perfect attention to detail from every contributor, but ""make the
> build green before we merge"" is widely understood 😄
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/pydata/xarray/pull/1824
> Commit Summary
>
>    - autoflake
>    - autopep8
>    - manual checking
>    - flake8 entire codebase
>    - fixup test
>    - Xarray is now flake8-clean with dask settings
>    - Fix all flake8 issues under default settings
>
> File Changes
>
>    - *M* .travis.yml
>    <https://github.com/pydata/xarray/pull/1824/files#diff-0> (2)
>    - *M* xarray/backends/__init__.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-1> (11)
>    - *M* xarray/backends/api.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-2> (6)
>    - *M* xarray/backends/h5netcdf_.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-3> (1)
>    - *M* xarray/backends/memory.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-4> (1)
>    - *M* xarray/backends/netCDF4_.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-5> (1)
>    - *M* xarray/backends/pydap_.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-6> (1)
>    - *M* xarray/backends/pynio_.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-7> (1)
>    - *M* xarray/backends/rasterio_.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-8> (13)
>    - *M* xarray/backends/zarr.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-9> (4)
>    - *M* xarray/conventions.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-10> (4)
>    - *M* xarray/core/accessors.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-11> (1)
>    - *M* xarray/core/alignment.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-12> (2)
>    - *M* xarray/core/combine.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-13> (35)
>    - *M* xarray/core/common.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-14> (4)
>    - *M* xarray/core/computation.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-15> (37)
>    - *M* xarray/core/coordinates.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-16> (6)
>    - *M* xarray/core/dataarray.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-17> (43)
>    - *M* xarray/core/dataset.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-18> (2)
>    - *M* xarray/core/extensions.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-19> (7)
>    - *M* xarray/core/formatting.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-20> (2)
>    - *M* xarray/core/groupby.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-21> (18)
>    - *M* xarray/core/indexing.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-22> (21)
>    - *M* xarray/core/merge.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-23> (8)
>    - *M* xarray/core/npcompat.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-24> (6)
>    - *M* xarray/core/nputils.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-25> (1)
>    - *M* xarray/core/ops.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-26> (2)
>    - *M* xarray/core/options.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-27> (1)
>    - *M* xarray/core/pycompat.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-28> (7)
>    - *M* xarray/core/rolling.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-29> (9)
>    - *M* xarray/core/utils.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-30> (2)
>    - *M* xarray/core/variable.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-31> (19)
>    - *M* xarray/plot/__init__.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-32> (11)
>    - *M* xarray/plot/plot.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-33> (6)
>    - *M* xarray/plot/utils.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-34> (2)
>    - *M* xarray/tests/__init__.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-35> (6)
>    - *M* xarray/tests/test_backends.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-36> (132)
>    - *M* xarray/tests/test_coding.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-37> (3)
>    - *M* xarray/tests/test_coding_times.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-38> (58)
>    - *M* xarray/tests/test_combine.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-39> (3)
>    - *M* xarray/tests/test_computation.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-40> (8)
>    - *M* xarray/tests/test_conventions.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-41> (10)
>    - *M* xarray/tests/test_dask.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-42> (29)
>    - *M* xarray/tests/test_dataarray.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-43> (49)
>    - *M* xarray/tests/test_dataset.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-44> (190)
>    - *M* xarray/tests/test_distributed.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-45> (6)
>    - *M* xarray/tests/test_extensions.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-46> (2)
>    - *M* xarray/tests/test_formatting.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-47> (2)
>    - *M* xarray/tests/test_groupby.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-48> (15)
>    - *M* xarray/tests/test_indexing.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-49> (8)
>    - *M* xarray/tests/test_merge.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-50> (4)
>    - *M* xarray/tests/test_plot.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-51> (20)
>    - *M* xarray/tests/test_tutorial.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-52> (1)
>    - *M* xarray/tests/test_utils.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-53> (7)
>    - *M* xarray/tests/test_variable.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-54> (91)
>    - *M* xarray/ufuncs.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-55> (1)
>    - *M* xarray/util/print_versions.py
>    <https://github.com/pydata/xarray/pull/1824/files#diff-56> (8)
>
> Patch Links:
>
>    - https://github.com/pydata/xarray/pull/1824.patch
>    - https://github.com/pydata/xarray/pull/1824.diff
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/1824>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AASszFdoOfPL0XthNrYRAMofHkVvt9uPks5tKJWKgaJpZM4RdMeC>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288322322