html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1824#issuecomment-357541263,https://api.github.com/repos/pydata/xarray/issues/1824,357541263,MDEyOklzc3VlQ29tbWVudDM1NzU0MTI2Mw==,1217238,2018-01-14T20:49:31Z,2018-01-14T20:49:31Z,MEMBER,Thanks!,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288322322 https://github.com/pydata/xarray/pull/1824#issuecomment-357494081,https://api.github.com/repos/pydata/xarray/issues/1824,357494081,MDEyOklzc3VlQ29tbWVudDM1NzQ5NDA4MQ==,12229877,2018-01-14T07:37:53Z,2018-01-14T07:37:53Z,CONTRIBUTOR,@shoyer; done 🎉 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288322322 https://github.com/pydata/xarray/pull/1824#issuecomment-357442522,https://api.github.com/repos/pydata/xarray/issues/1824,357442522,MDEyOklzc3VlQ29tbWVudDM1NzQ0MjUyMg==,306380,2018-01-13T15:14:27Z,2018-01-13T15:14:27Z,MEMBER,"Huzzah. Thanks Zac for picking this up On Sat, Jan 13, 2018 at 6:37 AM, Zac Hatfield Dodds < notifications@github.com> wrote: > Closes #1741 by @mrocklin > (who did most of the work I'm presenting > here). I had an evening free, so I rebased the previous pull on master, > fixed the conflicts, and then made everything pass with flake8's default > settings (including line length). My condolences to whoever gets to > *review* this diff! > > The single change any non-pedant will notice: Travis now fails if there is > a flake8 warning anywhere. My experience in other projects is that this is > the only way to actually *keep* flake8 passing - it's just unrealistic to > expect perfect attention to detail from every contributor, but ""make the > build green before we merge"" is widely understood 😄 > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/pydata/xarray/pull/1824 > Commit Summary > > - autoflake > - autopep8 > - manual checking > - flake8 entire codebase > - fixup test > - Xarray is now flake8-clean with dask settings > - Fix all flake8 issues under default settings > > File Changes > > - *M* .travis.yml > (2) > - *M* xarray/backends/__init__.py > (11) > - *M* xarray/backends/api.py > (6) > - *M* xarray/backends/h5netcdf_.py > (1) > - *M* xarray/backends/memory.py > (1) > - *M* xarray/backends/netCDF4_.py > (1) > - *M* xarray/backends/pydap_.py > (1) > - *M* xarray/backends/pynio_.py > (1) > - *M* xarray/backends/rasterio_.py > (13) > - *M* xarray/backends/zarr.py > (4) > - *M* xarray/conventions.py > (4) > - *M* xarray/core/accessors.py > (1) > - *M* xarray/core/alignment.py > (2) > - *M* xarray/core/combine.py > (35) > - *M* xarray/core/common.py > (4) > - *M* xarray/core/computation.py > (37) > - *M* xarray/core/coordinates.py > (6) > - *M* xarray/core/dataarray.py > (43) > - *M* xarray/core/dataset.py > (2) > - *M* xarray/core/extensions.py > (7) > - *M* xarray/core/formatting.py > (2) > - *M* xarray/core/groupby.py > (18) > - *M* xarray/core/indexing.py > (21) > - *M* xarray/core/merge.py > (8) > - *M* xarray/core/npcompat.py > (6) > - *M* xarray/core/nputils.py > (1) > - *M* xarray/core/ops.py > (2) > - *M* xarray/core/options.py > (1) > - *M* xarray/core/pycompat.py > (7) > - *M* xarray/core/rolling.py > (9) > - *M* xarray/core/utils.py > (2) > - *M* xarray/core/variable.py > (19) > - *M* xarray/plot/__init__.py > (11) > - *M* xarray/plot/plot.py > (6) > - *M* xarray/plot/utils.py > (2) > - *M* xarray/tests/__init__.py > (6) > - *M* xarray/tests/test_backends.py > (132) > - *M* xarray/tests/test_coding.py > (3) > - *M* xarray/tests/test_coding_times.py > (58) > - *M* xarray/tests/test_combine.py > (3) > - *M* xarray/tests/test_computation.py > (8) > - *M* xarray/tests/test_conventions.py > (10) > - *M* xarray/tests/test_dask.py > (29) > - *M* xarray/tests/test_dataarray.py > (49) > - *M* xarray/tests/test_dataset.py > (190) > - *M* xarray/tests/test_distributed.py > (6) > - *M* xarray/tests/test_extensions.py > (2) > - *M* xarray/tests/test_formatting.py > (2) > - *M* xarray/tests/test_groupby.py > (15) > - *M* xarray/tests/test_indexing.py > (8) > - *M* xarray/tests/test_merge.py > (4) > - *M* xarray/tests/test_plot.py > (20) > - *M* xarray/tests/test_tutorial.py > (1) > - *M* xarray/tests/test_utils.py > (7) > - *M* xarray/tests/test_variable.py > (91) > - *M* xarray/ufuncs.py > (1) > - *M* xarray/util/print_versions.py > (8) > > Patch Links: > > - https://github.com/pydata/xarray/pull/1824.patch > - https://github.com/pydata/xarray/pull/1824.diff > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , or mute the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288322322