html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1800#issuecomment-357729370,https://api.github.com/repos/pydata/xarray/issues/1800,357729370,MDEyOklzc3VlQ29tbWVudDM1NzcyOTM3MA==,2443309,2018-01-15T16:22:52Z,2018-01-15T16:22:52Z,MEMBER,Time for final comments. I'll merge tomorrow if nobody has any further changes. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,284607311 https://github.com/pydata/xarray/pull/1800#issuecomment-357471469,https://api.github.com/repos/pydata/xarray/issues/1800,357471469,MDEyOklzc3VlQ29tbWVudDM1NzQ3MTQ2OQ==,2443309,2018-01-13T22:15:47Z,2018-01-13T22:15:47Z,MEMBER,@rabernat - thanks for the review. I've addressed all your comments. I've also tested using this to push data to GCS. We're still getting the best performance we've been able to get when this is combined with gcsf:master and zarr:master. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,284607311 https://github.com/pydata/xarray/pull/1800#issuecomment-356664779,https://api.github.com/repos/pydata/xarray/issues/1800,356664779,MDEyOklzc3VlQ29tbWVudDM1NjY2NDc3OQ==,2443309,2018-01-10T16:54:51Z,2018-01-10T16:54:51Z,MEMBER,"This is ready for some final reviews. Although the title refers to Zarr, I ended up doing some minor refactoring of all the backends so a critical eye there would be nice. I'm also hoping to use @shoyer's coding/encoding work in #1803 here once that is merged.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,284607311 https://github.com/pydata/xarray/pull/1800#issuecomment-354711613,https://api.github.com/repos/pydata/xarray/issues/1800,354711613,MDEyOklzc3VlQ29tbWVudDM1NDcxMTYxMw==,2443309,2018-01-02T07:02:06Z,2018-01-02T07:02:06Z,MEMBER,"@shoyer - I've added a `set_dimensions` method to the writable datastores. This seems to work quite well except for string variables. I have a hacky fix with a comment in there right now, this works for all backends except h5netcdf. Thoughts on a better way to encode variables prior to setting dimensions would be great.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,284607311