html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1787#issuecomment-355812279,https://api.github.com/repos/pydata/xarray/issues/1787,355812279,MDEyOklzc3VlQ29tbWVudDM1NTgxMjI3OQ==,10050469,2018-01-07T10:15:27Z,2018-01-07T10:15:27Z,MEMBER,"In general I'm in favor for this change: adding units to the colorbar is the the first thing I teach my students in class. afaik, we don't do anything with units in xarray (except time handling), so this would be a first time thing and @shoyer maybe wants to chime in here.
Also:
- other labels could print their units too: coordinates on x and y axis labels might have units, e.g. lons/lats (the same way you added it to the y-label for 1d plots).
- are parentheses `Velocity (m/s)` the correct way to represent units in graphics? I got used to brackets `Velocity [m/s]` and thought this was the standard but internet and stackoverflow seem to have various opinions on the matter
- there should be tests for this. The fact that your change didn't break anything is that we have no data attribute called `units` in the graphics test suite: we should change this if we go for this change.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945