html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1787#issuecomment-362976003,https://api.github.com/repos/pydata/xarray/issues/1787,362976003,MDEyOklzc3VlQ29tbWVudDM2Mjk3NjAwMw==,12229877,2018-02-05T04:01:16Z,2018-02-05T04:01:16Z,CONTRIBUTOR,"This is now far enough down my list of priorities that I'm unlikely to get to it any time soon, and (it turns out) there are also some design issues that would need to be resolved.
I therefore suggest that anyone wishing to take this on opens an issue first to clarify the scope of any such change, and then make a PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945
https://github.com/pydata/xarray/pull/1787#issuecomment-355815405,https://api.github.com/repos/pydata/xarray/issues/1787,355815405,MDEyOklzc3VlQ29tbWVudDM1NTgxNTQwNQ==,12229877,2018-01-07T11:21:25Z,2018-01-07T11:21:25Z,CONTRIBUTOR,"- Including units in labels more generally sounds good to me, but I'll hold off until the general concept is approved ๐
- I don't think there's an objectively correct way to label units, but parentheses seem to be fairly standard and least prone to misinterpretation.
- Happy to add tests, though again I'll wait for in-principle approval. Adding a `units` attribute to some of the test data is easy enough!
- `units` is the convention, and if this is unsatisfactory it's quite trivial to override already - I'd hold off on custom options until someone has an actual use-case for the feature.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945
https://github.com/pydata/xarray/pull/1787#issuecomment-355813988,https://api.github.com/repos/pydata/xarray/issues/1787,355813988,MDEyOklzc3VlQ29tbWVudDM1NTgxMzk4OA==,1197350,2018-01-07T10:52:54Z,2018-01-07T10:52:54Z,MEMBER,"Perhaps we could default to โunitsโ for the unit attribute but allow a custom attribute to be set via xarray.set_options?
Sent from my iPhone
> On Jan 7, 2018, at 11:15 AM, Fabien Maussion wrote:
>
> In general I'm in favor for this change: adding units to the colorbar is the the first thing I teach my students in class. afaik, we don't do anything with units in xarray (except time handling), so this would be a first time thing and @shoyer maybe wants to chime in here.
>
> Also:
>
> other labels could print their units too: coordinates on x and y axis labels might have units, e.g. lons/lats (the same way you added it to the y-label for 1d plots).
> are parentheses Velocity (m/s) the correct way to represent units in graphics? I got used to brackets Velocity [m/s] and thought this was the standard but internet and stackoverflow seem to have various opinions on the matter
> there should be tests for this. The fact that your change didn't break anything is that we have no data attribute called units in the graphics test suite: we should change this if we go for this change.
> โ
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945
https://github.com/pydata/xarray/pull/1787#issuecomment-355812279,https://api.github.com/repos/pydata/xarray/issues/1787,355812279,MDEyOklzc3VlQ29tbWVudDM1NTgxMjI3OQ==,10050469,2018-01-07T10:15:27Z,2018-01-07T10:15:27Z,MEMBER,"In general I'm in favor for this change: adding units to the colorbar is the the first thing I teach my students in class. afaik, we don't do anything with units in xarray (except time handling), so this would be a first time thing and @shoyer maybe wants to chime in here.
Also:
- other labels could print their units too: coordinates on x and y axis labels might have units, e.g. lons/lats (the same way you added it to the y-label for 1d plots).
- are parentheses `Velocity (m/s)` the correct way to represent units in graphics? I got used to brackets `Velocity [m/s]` and thought this was the standard but internet and stackoverflow seem to have various opinions on the matter
- there should be tests for this. The fact that your change didn't break anything is that we have no data attribute called `units` in the graphics test suite: we should change this if we go for this change.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945
https://github.com/pydata/xarray/pull/1787#issuecomment-355745453,https://api.github.com/repos/pydata/xarray/issues/1787,355745453,MDEyOklzc3VlQ29tbWVudDM1NTc0NTQ1Mw==,12229877,2018-01-06T12:59:31Z,2018-01-06T12:59:31Z,CONTRIBUTOR,"Ping @fmaussion for review? (the build error is Travis download trouble, not failing tests)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945
https://github.com/pydata/xarray/pull/1787#issuecomment-351963684,https://api.github.com/repos/pydata/xarray/issues/1787,351963684,MDEyOklzc3VlQ29tbWVudDM1MTk2MzY4NA==,12229877,2017-12-15T09:56:32Z,2017-12-15T22:23:59Z,CONTRIBUTOR,"The exact key [`units` is required by the CF Conventions](http://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/cf-conventions.html#units) and most similar conventions, and very common in other landscape and hydrology data I work with.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945
https://github.com/pydata/xarray/pull/1787#issuecomment-351963161,https://api.github.com/repos/pydata/xarray/issues/1787,351963161,MDEyOklzc3VlQ29tbWVudDM1MTk2MzE2MQ==,6815844,2017-12-15T09:54:10Z,2017-12-15T09:54:10Z,MEMBER,"I am slightly wondering if there are some relavents to 'units', such as ' unit', 'Units', or 'UNIT', as xarray does not define how units should be stored (Actually my data has 'Unit').","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,282369945