html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/15#issuecomment-35839091,https://api.github.com/repos/pydata/xarray/issues/15,35839091,MDEyOklzc3VlQ29tbWVudDM1ODM5MDkx,1794715,2014-02-23T18:43:08Z,2014-02-23T18:43:08Z,CONTRIBUTOR,"Fair enough.
On Sun, Feb 23, 2014 at 10:40 AM, Stephan Hoyer notifications@github.comwrote:
> My preference is to stick with the presumably battle-hardened code from
> pandas. It would probably be slightly cleaner to use the git-python library
> but that adds another dependency (at least to the build) and then we'd have
> to debug it. I think git describe has been around for quite a while (and
> is unlikely to change).
>
> ##
>
> Reply to this email directly or view it on GitHubhttps://github.com/akleeman/xray/pull/15#issuecomment-35839019
> .
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,28123550
https://github.com/pydata/xarray/pull/15#issuecomment-35839019,https://api.github.com/repos/pydata/xarray/issues/15,35839019,MDEyOklzc3VlQ29tbWVudDM1ODM5MDE5,1217238,2014-02-23T18:40:48Z,2014-02-23T18:40:48Z,MEMBER,"My preference is to stick with the presumably battle-hardened code from pandas. It would probably be slightly cleaner to use the git-python library but that adds another dependency (at least to the build) and then we'd have to debug it. I think `git describe` has been around for quite a while (and is unlikely to change).
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,28123550
https://github.com/pydata/xarray/pull/15#issuecomment-35838795,https://api.github.com/repos/pydata/xarray/issues/15,35838795,MDEyOklzc3VlQ29tbWVudDM1ODM4Nzk1,1794715,2014-02-23T18:32:44Z,2014-02-23T18:32:44Z,CONTRIBUTOR,"Hmm. Would it be cleaner to use the git-python library? It would be cleaner than running a subprocess with possibly unknown versions of git. In addition, you could have it a requirement only for the build, not for installation.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,28123550