html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1760#issuecomment-349198982,https://api.github.com/repos/pydata/xarray/issues/1760,349198982,MDEyOklzc3VlQ29tbWVudDM0OTE5ODk4Mg==,5635139,2017-12-05T05:21:16Z,2017-12-05T05:21:16Z,MEMBER,"Right, though xarray used to call `.load`, which I think must have called through to `obj.compute`? If that's the case, potentially the tests need changing 

```
xarray/tests/test_backends.py:252: AssertionError
______________________ test_dask_kwargs_variable[compute] ______________________
method = 'compute'
    @pytest.mark.parametrize(""method"", ['load', 'compute'])
    def test_dask_kwargs_variable(method):
        x = Variable('y', da.from_array(np.arange(3), chunks=(2,)))
        # args should be passed on to da.Array.compute()
        with mock.patch.object(da.Array, 'compute',
                               return_value=np.arange(3)) as mock_compute:
            getattr(x, method)(foo='bar')
>       mock_compute.assert_called_with(foo='bar')
xarray/tests/test_dask.py:724: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
_mock_self = <MagicMock name='compute' id='139838059011600'>, args = ()
kwargs = {'foo': 'bar'}, expected = ""compute(foo='bar')""
    def assert_called_with(_mock_self, *args, **kwargs):
        """"""assert that the mock was called with the specified arguments.
    
            Raises an AssertionError if the args and keyword args passed in are
            different to the last call to the mock.""""""
        self = _mock_self
        if self.call_args is None:
            expected = self._format_mock_call_signature(args, kwargs)
>           raise AssertionError('Expected call: %s\nNot called' % (expected,))
E           AssertionError: Expected call: compute(foo='bar')
E           Not called
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,279198672
https://github.com/pydata/xarray/pull/1760#issuecomment-349175469,https://api.github.com/repos/pydata/xarray/issues/1760,349175469,MDEyOklzc3VlQ29tbWVudDM0OTE3NTQ2OQ==,5635139,2017-12-05T02:31:20Z,2017-12-05T02:31:20Z,MEMBER,"I took a look at the tests - I don't have too much helpful beyond breaking it down. 

For example, [this](https://travis-ci.org/pydata/xarray/jobs/311602522#L4602) tests that when `.compute(...)` is called on a `Variable` backed by a dask Array, that `.compute` gets called on the dask `Array`.

Has that changed? Does `dask.compute(x)` call `x.compute()`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,279198672