html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1751#issuecomment-351597414,https://api.github.com/repos/pydata/xarray/issues/1751,351597414,MDEyOklzc3VlQ29tbWVudDM1MTU5NzQxNA==,6815844,2017-12-14T03:23:05Z,2017-12-14T03:23:05Z,MEMBER,"This looks good to me. I think it is ready to expose `_getitem_with_mask` to public. As you mention in #TODO, I also think `isel` is the best place.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278325492 https://github.com/pydata/xarray/pull/1751#issuecomment-351594432,https://api.github.com/repos/pydata/xarray/issues/1751,351594432,MDEyOklzc3VlQ29tbWVudDM1MTU5NDQzMg==,6815844,2017-12-14T03:00:34Z,2017-12-14T03:00:34Z,MEMBER,Sorry for my late review. I will see later today.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278325492 https://github.com/pydata/xarray/pull/1751#issuecomment-348853749,https://api.github.com/repos/pydata/xarray/issues/1751,348853749,MDEyOklzc3VlQ29tbWVudDM0ODg1Mzc0OQ==,6815844,2017-12-04T03:45:48Z,2017-12-04T03:45:48Z,MEMBER,"Could you add more test coverage of the first commit? It would help other developers to follow the logic.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278325492 https://github.com/pydata/xarray/pull/1751#issuecomment-348376506,https://api.github.com/repos/pydata/xarray/issues/1751,348376506,MDEyOklzc3VlQ29tbWVudDM0ODM3NjUwNg==,6815844,2017-12-01T01:39:41Z,2017-12-01T01:39:41Z,MEMBER,"It is a great idea! I previously raised #1553 for multidimensional reindex, but am still thinking how could we implement it. `_getitem_with_mask` looks cleanest. I will look inside the code later, but I feel this should be exposed to the public. In this case, what is the most consistent naming with the existing methods? `isel_mask`? > I would probably leave it as a Variable method since this is pretty low-level. Agreed.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278325492