html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/1668#issuecomment-536336342,https://api.github.com/repos/pydata/xarray/issues/1668,536336342,MDEyOklzc3VlQ29tbWVudDUzNjMzNjM0Mg==,5635139,2019-09-29T20:07:02Z,2019-09-29T20:07:02Z,MEMBER,"OK, yes I see now. I didn't know about that windows behavior. There's a broader [CPython issue](https://bugs.python.org/issue14243) about it too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,269348789
https://github.com/pydata/xarray/issues/1668#issuecomment-536238948,https://api.github.com/repos/pydata/xarray/issues/1668,536238948,MDEyOklzc3VlQ29tbWVudDUzNjIzODk0OA==,1217238,2019-09-29T01:39:05Z,2019-09-29T01:39:05Z,MEMBER,"It might more informative to try removing and this option and to see what fails when you run CI :).
Our current temp file decorator will try to delete files as soon as we exit the scope, but if the file wasn't closed first this results in an exception on Windows. (This can happen because we only generate file names and let lower level library like netCDF open/close the files -- there are usually no Python level file objects, so we can't use `tempfile.TemporaryFile`.)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,269348789
https://github.com/pydata/xarray/issues/1668#issuecomment-536231578,https://api.github.com/repos/pydata/xarray/issues/1668,536231578,MDEyOklzc3VlQ29tbWVudDUzNjIzMTU3OA==,5635139,2019-09-28T22:58:40Z,2019-09-28T22:58:40Z,MEMBER,"> We currently try to explicitly close any temp files we created at the end of each test. Are you suggesting that we should leave that clean-up to the operating system?
IIUC (and my understand isn't advanced here!), python will close and delete temp files & directories once they leave scope:
From
https://docs.python.org/3/library/tempfile.html#examples
```
# create a temporary file using a context manager
>>> with tempfile.TemporaryFile() as fp:
... fp.write(b'Hello world!')
... fp.seek(0)
... fp.read()
b'Hello world!'
>>>
# file is now closed and removed
```
https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory
Or is it that we want to test that they're closed?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,269348789
https://github.com/pydata/xarray/issues/1668#issuecomment-536230684,https://api.github.com/repos/pydata/xarray/issues/1668,536230684,MDEyOklzc3VlQ29tbWVudDUzNjIzMDY4NA==,1217238,2019-09-28T22:37:46Z,2019-09-28T22:37:46Z,MEMBER,We currently try to explicitly close any temp files we created at the end of each test. Are you suggesting that we should leave that clean-up to the operating system?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,269348789
https://github.com/pydata/xarray/issues/1668#issuecomment-536230085,https://api.github.com/repos/pydata/xarray/issues/1668,536230085,MDEyOklzc3VlQ29tbWVudDUzNjIzMDA4NQ==,5635139,2019-09-28T22:26:03Z,2019-09-28T22:26:03Z,MEMBER,Maybe I don't understand the whole problem—can we just use a temp dir for these?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,269348789
https://github.com/pydata/xarray/issues/1668#issuecomment-536229383,https://api.github.com/repos/pydata/xarray/issues/1668,536229383,MDEyOklzc3VlQ29tbWVudDUzNjIyOTM4Mw==,26384082,2019-09-28T22:11:04Z,2019-09-28T22:11:04Z,NONE,"In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity
If this issue remains relevant, please comment here or remove the `stale` label; otherwise it will be marked as closed automatically
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,269348789