html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1657#issuecomment-340282693,https://api.github.com/repos/pydata/xarray/issues/1657,340282693,MDEyOklzc3VlQ29tbWVudDM0MDI4MjY5Mw==,1217238,2017-10-29T18:19:44Z,2017-10-29T18:19:44Z,MEMBER,Everything passed after the pandas 0.21 fixes in #1669,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340240917,https://api.github.com/repos/pydata/xarray/issues/1657,340240917,MDEyOklzc3VlQ29tbWVudDM0MDI0MDkxNw==,2443309,2017-10-29T06:33:08Z,2017-10-29T06:33:08Z,MEMBER,@shoyer - I think this is all good now. We seem to have acquired another unrelated build failures though...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340125292,https://api.github.com/repos/pydata/xarray/issues/1657,340125292,MDEyOklzc3VlQ29tbWVudDM0MDEyNTI5Mg==,1217238,2017-10-28T00:18:35Z,2017-10-28T00:18:35Z,MEMBER,"This looks good to me. Can you add a note to ""what's new"" (under bug fixes) about removing the warning when comparing with NaN?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340122183,https://api.github.com/repos/pydata/xarray/issues/1657,340122183,MDEyOklzc3VlQ29tbWVudDM0MDEyMjE4Mw==,2443309,2017-10-27T23:44:37Z,2017-10-27T23:44:37Z,MEMBER,"@shoyer - updated. If all the tests pass, I'll merge tonight. ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340121436,https://api.github.com/repos/pydata/xarray/issues/1657,340121436,MDEyOklzc3VlQ29tbWVudDM0MDEyMTQzNg==,1217238,2017-10-27T23:37:13Z,2017-10-27T23:37:13Z,MEMBER,"@jhamman sorry, looks like you'll need to merge in master, too -- I just put in some conflicting changes with my unicode to netCDF3 PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340067233,https://api.github.com/repos/pydata/xarray/issues/1657,340067233,MDEyOklzc3VlQ29tbWVudDM0MDA2NzIzMw==,2443309,2017-10-27T19:42:33Z,2017-10-27T19:42:33Z,MEMBER,"Okay, so this knocks off the lowest hanging fruit. I'll pull the pytest error out of the travis build and we'll move forward with this.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340066142,https://api.github.com/repos/pydata/xarray/issues/1657,340066142,MDEyOklzc3VlQ29tbWVudDM0MDA2NjE0Mg==,1217238,2017-10-27T19:37:31Z,2017-10-27T19:37:31Z,MEMBER,"> I'm wondering if we should attack #1652 in stages

Yes, absolutely. Let's do it in stages.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-340064856,https://api.github.com/repos/pydata/xarray/issues/1657,340064856,MDEyOklzc3VlQ29tbWVudDM0MDA2NDg1Ng==,2443309,2017-10-27T19:31:43Z,2017-10-27T19:31:43Z,MEMBER,"@shoyer - I'm wondering if we should attack #1652 in stages. The remaining warnings are going to take a bit more effort and this first block included a lot of line changes. I'm a bit concerned that if we let this sit, we will end up with a million merge conflicts.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252
https://github.com/pydata/xarray/pull/1657#issuecomment-339224835,https://api.github.com/repos/pydata/xarray/issues/1657,339224835,MDEyOklzc3VlQ29tbWVudDMzOTIyNDgzNQ==,2443309,2017-10-25T06:08:57Z,2017-10-25T06:08:57Z,MEMBER,"Down to 96 (was 372) warnings in my py36 test environment.

Two changes that I could uses some input on: 

##### 1 - Numpy element wise comparison

```Python
    def assertEqual(self, a1, a2):
>       assert a1 == a2 or (a1 != a1 and a2 != a2)
E       DeprecationWarning: elementwise == comparison failed; this will raise an error in the future.
```

@shoyer - you and I put together the assertEqual method a while back. Do we need to check the size of arrays before comparing the values?

##### 2 - Numpy invalid value comparison

e.g.: 
```Python
RuntimeWarning: invalid value encountered in greater_equal 
```

I'm hoping there is a succinct way of wrapping many of our nan comparing functions in `numpy.errstat`. Thoughts here? I've run out of time for tonight but will pick this up again tomorrow.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,268264252