html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/1599#issuecomment-1504276696,https://api.github.com/repos/pydata/xarray/issues/1599,1504276696,IC_kwDOAMm_X85ZqXDY,2448579,2023-04-11T23:43:34Z,2023-04-11T23:43:43Z,MEMBER,"Perhaps we should have `array_to_list: bool` instead. If `False`, we just preserve the underlying array type.
Then the user could do `ds.as_numpy().to_dict(array_to_list=False)` to always get numpy arrays as #7739","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-1500552035,https://api.github.com/repos/pydata/xarray/issues/1599,1500552035,IC_kwDOAMm_X85ZcJtj,12465248,2023-04-07T18:59:04Z,2023-04-07T18:59:24Z,CONTRIBUTOR,"The PR #7739 is available for review. @jhamman @dcherian would be my choices. i think this is pretty straight forward. I suppose the name of the kwarg being `numpy_data` is debatable. I based this on the discussion of `numpy` vs `tolist` above, preferring the former but acknowledging the comment that a package name as an arg is odd. Could do `as_numpy` or something slightly different.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-1500454096,https://api.github.com/repos/pydata/xarray/issues/1599,1500454096,IC_kwDOAMm_X85ZbxzQ,2443309,2023-04-07T16:47:09Z,2023-04-07T16:47:09Z,MEMBER,@jmccreight - I don't think there is any specific reason this didn't get done. Still open to contributions here if you are interested.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-1500449963,https://api.github.com/repos/pydata/xarray/issues/1599,1500449963,IC_kwDOAMm_X85Zbwyr,12465248,2023-04-07T16:41:39Z,2023-04-07T16:41:39Z,CONTRIBUTOR,"I'd be interested in reviving this, this is exactly what I want to achieve. It's not clear if there was some reason this never went ahead. I looked around but didnt find anything. LMK if it there's some reason not to pursue it. THanks","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-527253115,https://api.github.com/repos/pydata/xarray/issues/1599,527253115,MDEyOklzc3VlQ29tbWVudDUyNzI1MzExNQ==,26384082,2019-09-02T22:39:29Z,2019-09-02T22:39:29Z,NONE,"In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity
If this issue remains relevant, please comment here or remove the `stale` label; otherwise it will be marked as closed automatically
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333673706,https://api.github.com/repos/pydata/xarray/issues/1599,333673706,MDEyOklzc3VlQ29tbWVudDMzMzY3MzcwNg==,1217238,2017-10-02T21:42:10Z,2017-10-02T21:42:31Z,MEMBER,"@nicain myself, @jhamman and/or @MaximilianR are good choices for reviewers, thanks!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333672308,https://api.github.com/repos/pydata/xarray/issues/1599,333672308,MDEyOklzc3VlQ29tbWVudDMzMzY3MjMwOA==,113055,2017-10-02T21:35:50Z,2017-10-02T21:39:49Z,NONE,"Sweet, this is exactly what I am used to! Ill give a shot to writing a few tests later today, and make a PR. Can you suggest some core devs I can ping for a PR review? Ill ask @chrisbarber (we work together) to review, but I'd like more eyeballs on it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333658466,https://api.github.com/repos/pydata/xarray/issues/1599,333658466,MDEyOklzc3VlQ29tbWVudDMzMzY1ODQ2Ng==,1217238,2017-10-02T20:41:05Z,2017-10-02T20:52:26Z,MEMBER,"We need to write a contributing guide!
But in brief:
- We use the NumPy docstring convention: https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt
- For unit tests, we use pytest, with helper functions/methods for verifying comparisons between objects. Take a look at the existing tests for examples to emulate: https://github.com/pydata/xarray/blob/25d1855e737444c156f50d1f37a67d9674a8bac5/xarray/tests/test_dataset.py#L2402
See also: https://github.com/pydata/xarray/pull/1485/files","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333636786,https://api.github.com/repos/pydata/xarray/issues/1599,333636786,MDEyOklzc3VlQ29tbWVudDMzMzYzNjc4Ng==,113055,2017-10-02T19:18:58Z,2017-10-02T19:18:58Z,NONE,"@chrisbarber
Here is my example implementation: https://github.com/nicain/xarray/blob/fa86e3d38ebf4e641cafd963a5b69a77539b931d/xarray/core/dataarray.py#L1388
@shoyer Can you point me to where to edit documentation and unit test best practices?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333247131,https://api.github.com/repos/pydata/xarray/issues/1599,333247131,MDEyOklzc3VlQ29tbWVudDMzMzI0NzEzMQ==,1530840,2017-09-29T21:48:58Z,2017-09-29T21:48:58Z,NONE,"@nicain, for sure. Probably best for the API's sake to stick to the simplicity of a flag.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333243054,https://api.github.com/repos/pydata/xarray/issues/1599,333243054,MDEyOklzc3VlQ29tbWVudDMzMzI0MzA1NA==,113055,2017-09-29T21:26:17Z,2017-09-29T21:26:17Z,NONE,@chrisbarber Maybe a method to_byte_dict that (in implementation) takes the output from numpy=True and walks the dict with tobytes? ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333240395,https://api.github.com/repos/pydata/xarray/issues/1599,333240395,MDEyOklzc3VlQ29tbWVudDMzMzI0MDM5NQ==,1530840,2017-09-29T21:12:15Z,2017-09-29T21:12:15Z,NONE,"Could have a callable `serializer` kwarg that defaults to `np.ndarray.tolist`. I have a use case where I would pass in `np.ndarray.tobytes` for this. But then again, I could just use `numpy=True` or `tolist=False` and then walk the dict myself.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333224773,https://api.github.com/repos/pydata/xarray/issues/1599,333224773,MDEyOklzc3VlQ29tbWVudDMzMzIyNDc3Mw==,1217238,2017-09-29T20:00:49Z,2017-09-29T20:00:49Z,MEMBER,"I'll let others chime in on the API design here but yes that sounds pretty reasonable, too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333211787,https://api.github.com/repos/pydata/xarray/issues/1599,333211787,MDEyOklzc3VlQ29tbWVudDMzMzIxMTc4Nw==,113055,2017-09-29T19:04:24Z,2017-09-29T19:04:24Z,NONE,"Yeah, my thoughts exactly. I am almost done with this in my fork... numpy might be confusing for those who will see the module name when they look at it. How does a kwarg:
```Python
def to_dict(self, tolist=True):
```
sound?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170
https://github.com/pydata/xarray/issues/1599#issuecomment-333209574,https://api.github.com/repos/pydata/xarray/issues/1599,333209574,MDEyOklzc3VlQ29tbWVudDMzMzIwOTU3NA==,1217238,2017-09-29T18:55:04Z,2017-09-29T18:55:04Z,MEMBER,"We could add a keyword argument to control this, e.g., `numpy=True` to indicate that data should be kept as NumPy arrays.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170