html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1597#issuecomment-508802893,https://api.github.com/repos/pydata/xarray/issues/1597,508802893,MDEyOklzc3VlQ29tbWVudDUwODgwMjg5Mw==,1386642,2019-07-05T15:59:51Z,2019-07-05T15:59:51Z,CONTRIBUTOR,Thanks Joe!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-508598650,https://api.github.com/repos/pydata/xarray/issues/1597,508598650,MDEyOklzc3VlQ29tbWVudDUwODU5ODY1MA==,1386642,2019-07-05T01:07:21Z,2019-07-05T01:07:21Z,CONTRIBUTOR,phew! Thanks for all the reviews and discussion everyone!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-508593312,https://api.github.com/repos/pydata/xarray/issues/1597,508593312,MDEyOklzc3VlQ29tbWVudDUwODU5MzMxMg==,1386642,2019-07-05T00:09:43Z,2019-07-05T00:09:43Z,CONTRIBUTOR,It looks like the CI errors above aren’t related to this PR. There seems to be an issue with `to_pandas`.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-507822750,https://api.github.com/repos/pydata/xarray/issues/1597,507822750,MDEyOklzc3VlQ29tbWVudDUwNzgyMjc1MA==,1386642,2019-07-02T19:57:59Z,2019-07-02T19:57:59Z,CONTRIBUTOR,drat. Should be fixed now.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-507512420,https://api.github.com/repos/pydata/xarray/issues/1597,507512420,MDEyOklzc3VlQ29tbWVudDUwNzUxMjQyMA==,1386642,2019-07-02T04:23:10Z,2019-07-02T04:23:10Z,CONTRIBUTOR,"Okay. I responded to @benbovy's last comments and merged the upstream changes to master. How is this looking? cc @jhamman ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-505533500,https://api.github.com/repos/pydata/xarray/issues/1597,505533500,MDEyOklzc3VlQ29tbWVudDUwNTUzMzUwMA==,1386642,2019-06-25T17:01:52Z,2019-06-25T17:01:52Z,CONTRIBUTOR,"> is there actual use cases where it is useful to provide multiple dimensions for sample_dims? Yes! My main use-case does. For example, if you have a weather dataset where every lat/lon pair should be considered a separate ""sample"", you would use `sample_dims=['lat', 'lon']`.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-504623974,https://api.github.com/repos/pydata/xarray/issues/1597,504623974,MDEyOklzc3VlQ29tbWVudDUwNDYyMzk3NA==,1386642,2019-06-22T03:37:35Z,2019-06-22T03:37:35Z,CONTRIBUTOR,It looks like the tests passed. @benbovy How does it look now? Did I fix the issues you mentioned?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-504621993,https://api.github.com/repos/pydata/xarray/issues/1597,504621993,MDEyOklzc3VlQ29tbWVudDUwNDYyMTk5Mw==,1386642,2019-06-22T03:12:00Z,2019-06-22T03:12:00Z,CONTRIBUTOR,It looks like 43834ac8186a851b7 might have fixed this. Let's see if the tests pass.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-499915652,https://api.github.com/repos/pydata/xarray/issues/1597,499915652,MDEyOklzc3VlQ29tbWVudDQ5OTkxNTY1Mg==,1386642,2019-06-07T14:51:46Z,2019-06-07T14:54:25Z,CONTRIBUTOR,Does anybody have an idea why the `py36-dask-dev` tests are failing? None of the errors seems related to this PR.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-499789587,https://api.github.com/repos/pydata/xarray/issues/1597,499789587,MDEyOklzc3VlQ29tbWVudDQ5OTc4OTU4Nw==,1386642,2019-06-07T07:40:38Z,2019-06-07T07:40:38Z,CONTRIBUTOR,"@benbovy Paradoxically I think making `to_stacked_array` accept the list of dimensions which won't be stacked is clearer. These *unstacked* dims needed to shared across all variables, which is a very simple requirement. I realized this after writing a bunch of error-prone validation code. See my last commit for more of my reasoning (5ca9a1d868a). I also updated the docs and tests accordingly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-499761734,https://api.github.com/repos/pydata/xarray/issues/1597,499761734,MDEyOklzc3VlQ29tbWVudDQ5OTc2MTczNA==,1386642,2019-06-07T05:28:51Z,2019-06-07T05:28:51Z,CONTRIBUTOR,"@benbovy > Is it expected behavior? I guess that not every combination is possible because we're not broadcasting here unlike to_array(). I believe so. In your third case, `to_stacked_array` basically wants to combine `a` and `b` into a DataArray with a dimension `y`. But that is not possible without broadcasting because `b` does not have a dimension `y`. I will try to add a more informative error message.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-494893796,https://api.github.com/repos/pydata/xarray/issues/1597,494893796,MDEyOklzc3VlQ29tbWVudDQ5NDg5Mzc5Ng==,1386642,2019-05-22T17:21:24Z,2019-05-22T17:21:24Z,CONTRIBUTOR,Thanks for your review @benbovy. I'll try to take a look soon.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-493249598,https://api.github.com/repos/pydata/xarray/issues/1597,493249598,MDEyOklzc3VlQ29tbWVudDQ5MzI0OTU5OA==,1386642,2019-05-16T22:11:55Z,2019-05-16T22:11:55Z,CONTRIBUTOR,Hey @rabernat. Did I resolve your comments?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-482640504,https://api.github.com/repos/pydata/xarray/issues/1597,482640504,MDEyOklzc3VlQ29tbWVudDQ4MjY0MDUwNA==,1386642,2019-04-12T16:35:17Z,2019-04-12T16:35:17Z,CONTRIBUTOR,Hey. I just wanted to bump this PR. How does it look @rabernat @jhamman @shoyer?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-479128919,https://api.github.com/repos/pydata/xarray/issues/1597,479128919,MDEyOklzc3VlQ29tbWVudDQ3OTEyODkxOQ==,1386642,2019-04-02T18:15:10Z,2019-04-02T18:15:10Z,CONTRIBUTOR,Ok. I added an example which is very similar to the `DataArray.unstack` example.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-478794367,https://api.github.com/repos/pydata/xarray/issues/1597,478794367,MDEyOklzc3VlQ29tbWVudDQ3ODc5NDM2Nw==,1386642,2019-04-02T00:20:24Z,2019-04-02T00:20:24Z,CONTRIBUTOR,"Okay. It looks like it is passing CI now, so I think it's ready for another look. How does it look? Are you still interested in including this functionality?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-478748969,https://api.github.com/repos/pydata/xarray/issues/1597,478748969,MDEyOklzc3VlQ29tbWVudDQ3ODc0ODk2OQ==,1386642,2019-04-01T21:09:31Z,2019-04-01T21:09:31Z,CONTRIBUTOR,@shoyer Sorry. I rebased...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-478702680,https://api.github.com/repos/pydata/xarray/issues/1597,478702680,MDEyOklzc3VlQ29tbWVudDQ3ODcwMjY4MA==,1386642,2019-04-01T18:58:18Z,2019-04-01T18:58:18Z,CONTRIBUTOR,@jhamman I did a little more work on this today. How do you recommend I update this to master? rebase?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-445483774,https://api.github.com/repos/pydata/xarray/issues/1597,445483774,MDEyOklzc3VlQ29tbWVudDQ0NTQ4Mzc3NA==,1386642,2018-12-08T19:28:40Z,2018-12-08T19:28:40Z,CONTRIBUTOR,I'd be happy to pick this up again if you think it will go through.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-366548976,https://api.github.com/repos/pydata/xarray/issues/1597,366548976,MDEyOklzc3VlQ29tbWVudDM2NjU0ODk3Ng==,1386642,2018-02-18T21:24:28Z,2018-02-18T21:24:28Z,CONTRIBUTOR,Sorry for random activity. I accidentally hard reset the master branch nbren12/xarray to pydata/xarray.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-343643422,https://api.github.com/repos/pydata/xarray/issues/1597,343643422,MDEyOklzc3VlQ29tbWVudDM0MzY0MzQyMg==,1386642,2017-11-11T06:01:52Z,2017-11-11T06:02:12Z,CONTRIBUTOR,"@shoyer If you are okay with it, I think we might want to leave that to a later date if ever. I am not exactly sure what a useful API for that would be ATM. On the other hand, I have been using the original `stack_cat` and `unstack_cat` functions for a couple of months, and they have handled my basic uses pretty well. For more complicated uses (e.g. taking different subsets of each variable and concatenating the output), I have started working on [a project](https://github.com/nbren12/xarray_sklearn) which is similar to [sklearn-pandas](https://github.com/scikit-learn-contrib/sklearn-pandas). Since there are a million ways several xarray variables could be processed/subsetted, stacked and then concatenated, I think this functionality should probably remain in a third party package for now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-343312698,https://api.github.com/repos/pydata/xarray/issues/1597,343312698,MDEyOklzc3VlQ29tbWVudDM0MzMxMjY5OA==,1386642,2017-11-09T22:28:22Z,2017-11-09T22:28:22Z,CONTRIBUTOR,Okay. I think I'm done with the updates to the documentation. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-342665601,https://api.github.com/repos/pydata/xarray/issues/1597,342665601,MDEyOklzc3VlQ29tbWVudDM0MjY2NTYwMQ==,1386642,2017-11-08T00:04:57Z,2017-11-08T00:04:57Z,CONTRIBUTOR,"I just added some docs, but need to add to whats-new still,","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-333337845,https://api.github.com/repos/pydata/xarray/issues/1597,333337845,MDEyOklzc3VlQ29tbWVudDMzMzMzNzg0NQ==,1386642,2017-09-30T21:41:58Z,2017-09-30T21:41:58Z,CONTRIBUTOR,@rabernat Your point is well taken. I will add some docs/motivation to the reshaping page.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-333275551,https://api.github.com/repos/pydata/xarray/issues/1597,333275551,MDEyOklzc3VlQ29tbWVudDMzMzI3NTU1MQ==,1386642,2017-09-30T02:20:41Z,2017-09-30T02:21:14Z,CONTRIBUTOR,"Okay. I just changed the names of the methods and wrote a test case for the problem with the dtype of the stacked dimensions not being preserved by `to_stacked_array`. At the moment, I am filling in the missing dimensions with None, so the resulting index has `dtype object'`. This is then concatenated with the bona fide indices of the variables which are not missing this index, so the index as a whole is cast to the lowest common denominator, which is `object`. Unfortunately we can't just put `Nan` in because, `NaN` is a floating point number thing, so I don't think all numpy dtypes have the equivalent of NaN. @shoyer Do you have any thoughts about how to resolve this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-333271025,https://api.github.com/repos/pydata/xarray/issues/1597,333271025,MDEyOklzc3VlQ29tbWVudDMzMzI3MTAyNQ==,1386642,2017-09-30T01:06:09Z,2017-09-30T01:06:09Z,CONTRIBUTOR,"That naming sounds good to me. Also, I was having an issue with `unstack_cat` returning an index with dtype `object` that I would like to sort out.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-333023152,https://api.github.com/repos/pydata/xarray/issues/1597,333023152,MDEyOklzc3VlQ29tbWVudDMzMzAyMzE1Mg==,1386642,2017-09-29T03:38:07Z,2017-09-29T03:38:07Z,CONTRIBUTOR,Or maybe `DataArray.to_dataset_unstacked` is good.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958 https://github.com/pydata/xarray/pull/1597#issuecomment-333022698,https://api.github.com/repos/pydata/xarray/issues/1597,333022698,MDEyOklzc3VlQ29tbWVudDMzMzAyMjY5OA==,1386642,2017-09-29T03:33:34Z,2017-09-29T03:34:02Z,CONTRIBUTOR,"Thanks! Yah...I'm not very good at naming things. I think `Dataset.to_stacked_array` makes sense, but I would typically expect something like `from_stacked_array` to be a static method of `Dataset` (e.g. `pd.MultiIndex.from_tuples`). We could always move unstack_cat to `Dataset`, but then we miss out on the ability to make sequential method calls. IMO the behavior of unstack_cat is kind of what I would expect `DataArray.to_dataset` to do in the case where `dim` is a stacked coordinate, so maybe we could put it in there.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261131958