html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1580#issuecomment-335603929,https://api.github.com/repos/pydata/xarray/issues/1580,335603929,MDEyOklzc3VlQ29tbWVudDMzNTYwMzkyOQ==,2443309,2017-10-10T20:51:26Z,2017-10-10T20:51:26Z,MEMBER,Thanks @guziy!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482
https://github.com/pydata/xarray/pull/1580#issuecomment-335367729,https://api.github.com/repos/pydata/xarray/issues/1580,335367729,MDEyOklzc3VlQ29tbWVudDMzNTM2NzcyOQ==,2443309,2017-10-10T05:48:51Z,2017-10-10T05:48:51Z,MEMBER,"I think this is ready to go, any final objections?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482
https://github.com/pydata/xarray/pull/1580#issuecomment-332982573,https://api.github.com/repos/pydata/xarray/issues/1580,332982573,MDEyOklzc3VlQ29tbWVudDMzMjk4MjU3Mw==,2443309,2017-09-28T22:36:05Z,2017-09-28T22:36:05Z,MEMBER,LGTM. @crusaderky - I think you should look at this in conjunction with #1551.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482
https://github.com/pydata/xarray/pull/1580#issuecomment-330672715,https://api.github.com/repos/pydata/xarray/issues/1580,330672715,MDEyOklzc3VlQ29tbWVudDMzMDY3MjcxNQ==,900941,2017-09-19T21:02:53Z,2017-09-19T21:02:53Z,CONTRIBUTOR,"Thanks @spencerahill 

py.test seems to be working

Cheers","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482
https://github.com/pydata/xarray/pull/1580#issuecomment-330672462,https://api.github.com/repos/pydata/xarray/issues/1580,330672462,MDEyOklzc3VlQ29tbWVudDMzMDY3MjQ2Mg==,6200806,2017-09-19T21:01:55Z,2017-09-19T21:01:55Z,CONTRIBUTOR,"Try running them via pytest instead (`pip install pytest` or `conda install pytest` if you don't have it already).

Note that you'll need to add new test(s) that cover the modifications you have made -- not just run the existing tests. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482
https://github.com/pydata/xarray/pull/1580#issuecomment-330663981,https://api.github.com/repos/pydata/xarray/issues/1580,330663981,MDEyOklzc3VlQ29tbWVudDMzMDY2Mzk4MQ==,900941,2017-09-19T20:29:58Z,2017-09-19T20:31:01Z,CONTRIBUTOR,"Thanks @spencerahill:

I have run the flake8 test and modified the whats-new.rst.
I think I need more guidance with the tests. 
I tried using nosetests and get the following exceptions (I am sure I am doing smth wrong here):

```
$ nosetests
/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/matplotlib/__init__.py:917: UserWarning: axes.hold is deprecated. Please remove it from your matplotlibrc and/or style files.
  warnings.warn(self.msg_depr_set % key)
/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/matplotlib/rcsetup.py:152: UserWarning: axes.hold is deprecated, will be removed in 3.0
  warnings.warn(""axes.hold is deprecated, will be removed in 3.0"")
E
======================================================================
ERROR: Failure: AttributeError (module 'pytest' has no attribute 'config')
----------------------------------------------------------------------
Traceback (most recent call last):
  File ""/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/failure.py"", line 39, in runTest
    raise self.exc_val.with_traceback(self.tb)
  File ""/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/loader.py"", line 417, in loadTestsFromName
    addr.filename, addr.module)
  File ""/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/importer.py"", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File ""/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/importer.py"", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File ""/Users/huziy/anaconda/envs/py3.6/lib/python3.6/imp.py"", line 244, in load_module
    return load_package(name, filename)
  File ""/Users/huziy/anaconda/envs/py3.6/lib/python3.6/imp.py"", line 216, in load_package
    return _load(spec)
  File ""<frozen importlib._bootstrap>"", line 675, in _load
  File ""<frozen importlib._bootstrap>"", line 655, in _load_unlocked
  File ""<frozen importlib._bootstrap_external>"", line 678, in exec_module
  File ""<frozen importlib._bootstrap>"", line 205, in _call_with_frames_removed
  File ""/Users/huziy/PythonProjects/xarray/xarray/tests/__init__.py"", line 130, in <module>
    _SKIP_FLAKY = not pytest.config.getoption(""--run-flaky"")
AttributeError: module 'pytest' has no attribute 'config'

----------------------------------------------------------------------
Ran 1 test in 0.582s

FAILED (errors=1)
```

Cheers
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482
https://github.com/pydata/xarray/pull/1580#issuecomment-330648836,https://api.github.com/repos/pydata/xarray/issues/1580,330648836,MDEyOklzc3VlQ29tbWVudDMzMDY0ODgzNg==,6200806,2017-09-19T19:31:00Z,2017-09-19T19:32:31Z,CONTRIBUTOR,">have not run tests yet

These will definitely be needed.  Existing tests for `open_mfdataset` are in [xarray/tests/test_backends.py](https://github.com/pydata/xarray/blob/3fb5cbbeabef9d1df538ffa11cb01e6c09ea17a4/xarray/tests/test_backends.py).  @shoyer and/or @jhamman can hopefully help you out if you need more guidance.

>Not sure how to install flake8

`pip install flake8` should work.  Alternatively if you use conda `conda install -c conda-forge flake8`

>Do not think the change is big enough to be added to the files

A brief note in What's New under the [Enhancements](https://github.com/pydata/xarray/blob/master/doc/whats-new.rst#enhancements) section would actually be appropriate.  Just follow the example of the others in that section.

Thanks for taking this on!  We actually just bumped across this ([here](https://github.com/spencerahill/aospy/pull/199)), so your fix will immediately benefit more than just you.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,258884482