html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1570#issuecomment-428819685,https://api.github.com/repos/pydata/xarray/issues/1570,428819685,MDEyOklzc3VlQ29tbWVudDQyODgxOTY4NQ==,1217238,2018-10-11T04:49:50Z,2018-10-11T04:49:50Z,MEMBER,I don't think we have any way to access data via FTP in xarray.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-428818355,https://api.github.com/repos/pydata/xarray/issues/1570,428818355,MDEyOklzc3VlQ29tbWVudDQyODgxODM1NQ==,5647458,2018-10-11T04:39:51Z,2018-10-11T04:39:51Z,NONE,"Is there a way to do this, but then for ftp-servers rather than for opendap? It would be awesome to retrieve data from marine.copernicus.eu and subset it with xarray before saving it to disk. Cheers Jan Jaap","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329829869,https://api.github.com/repos/pydata/xarray/issues/1570,329829869,MDEyOklzc3VlQ29tbWVudDMyOTgyOTg2OQ==,3639582,2017-09-15T16:19:09Z,2017-09-15T16:19:09Z,CONTRIBUTOR,Thank you too! Cool :) ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329825004,https://api.github.com/repos/pydata/xarray/issues/1570,329825004,MDEyOklzc3VlQ29tbWVudDMyOTgyNTAwNA==,1217238,2017-09-15T16:00:26Z,2017-09-15T16:00:26Z,MEMBER,This will be in the forthcoming v0.10 release,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329824959,https://api.github.com/repos/pydata/xarray/issues/1570,329824959,MDEyOklzc3VlQ29tbWVudDMyOTgyNDk1OQ==,1217238,2017-09-15T16:00:17Z,2017-09-15T16:00:17Z,MEMBER,Thanks @mrpgraae !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329475573,https://api.github.com/repos/pydata/xarray/issues/1570,329475573,MDEyOklzc3VlQ29tbWVudDMyOTQ3NTU3Mw==,3639582,2017-09-14T13:05:41Z,2017-09-14T13:05:41Z,CONTRIBUTOR,"> This looks great to me!
>
>One last suggestion -- can you add a brief note about the ability to access password protected datasets in the opendap section of the docs?
http://xarray.pydata.org/en/stable/io.html#opendap

Thanks! It's cool to be able to contribute to a library i use daily.

I added some documentation, please tell me what you think. For the second example, with the NASA URS, i wanted to use a URL that points to an actual NASA dataset, but i couldn't find one that wasn't extremely long. I ended up using that one, which is for a real NASA server, but a non-existant dataset. Hope that's not too confusing. Obviously, the username and password are fake as well :) so maybe it doesn't matter.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-329160391,https://api.github.com/repos/pydata/xarray/issues/1570,329160391,MDEyOklzc3VlQ29tbWVudDMyOTE2MDM5MQ==,3639582,2017-09-13T13:02:21Z,2017-09-13T13:02:21Z,CONTRIBUTOR,"I fixed the documentation stuff and changed the test to one that uses a mock of `pydap.client.open_url`, like we talked about.

I decided against adding `open_url`s other keyword arguments to `PydapDataStore.open`, for the reasons that we discussed and since users can still instantiate their own Pydap dataset and pass that, if they really want to change those parameters.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-328969823,https://api.github.com/repos/pydata/xarray/issues/1570,328969823,MDEyOklzc3VlQ29tbWVudDMyODk2OTgyMw==,1217238,2017-09-12T20:08:51Z,2017-09-12T20:08:51Z,MEMBER,"> One of the reasons i was unsure about adding the other keyword arguments, is that I'm not entirely sure if changing any of them from their default values will break the interface with xarray.

Well, this is probably a good reason to leave out any that we feel unsure about.

> Then there's also the timeout parameter, for which I think we will need to import some module within pydap just to get DEFAULT_TIMEOUT. That seems a bit awkward? 

Yes, that would make me hesitant to use it, especially if it's not clear that `DEFAULT_TIMEOUT` is a supported API.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194
https://github.com/pydata/xarray/pull/1570#issuecomment-328967624,https://api.github.com/repos/pydata/xarray/issues/1570,328967624,MDEyOklzc3VlQ29tbWVudDMyODk2NzYyNA==,3639582,2017-09-12T19:59:51Z,2017-09-12T20:02:20Z,CONTRIBUTOR,"Thank you for the fast review! 

> but if there are a few other optional keyword arguments to complete the function signature, then sure, that would be fine. I would definitely avoid using **kwargs, because that precludes the ability for us to add other xarray specific options at some point in the future.

One of the reasons i was unsure about adding the other keyword arguments, is that I'm not entirely sure if changing any of them from their default values will break the interface with xarray. But i guess you could argue that if users are changing these parameters, they probably know what they are doing.

Then there's also the `timeout` parameter, for which I think we will need to import some module within pydap just to get `DEFAULT_TIMEOUT`. That seems a bit awkward? We could also just leave that one out.

I definitely see your point with **kwargs, I had a feeling that would be a bad idea.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,257076194