html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1557#issuecomment-334315436,https://api.github.com/repos/pydata/xarray/issues/1557,334315436,MDEyOklzc3VlQ29tbWVudDMzNDMxNTQzNg==,1217238,2017-10-04T23:10:44Z,2017-10-04T23:10:44Z,MEMBER,"LGTM, thanks","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811
https://github.com/pydata/xarray/pull/1557#issuecomment-334298058,https://api.github.com/repos/pydata/xarray/issues/1557,334298058,MDEyOklzc3VlQ29tbWVudDMzNDI5ODA1OA==,2443309,2017-10-04T21:41:45Z,2017-10-04T21:41:45Z,MEMBER,"@shoyer - ready for a final review. Turns out, we can just use the unittest decorators. Basically no changes to the test code base :). ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811
https://github.com/pydata/xarray/pull/1557#issuecomment-333583361,https://api.github.com/repos/pydata/xarray/issues/1557,333583361,MDEyOklzc3VlQ29tbWVudDMzMzU4MzM2MQ==,1217238,2017-10-02T16:12:22Z,2017-10-02T16:12:31Z,MEMBER,"Another option is to give up on class decorators and only use a method decorator -- which we could even write ourselves if necessary. We have most of us backend specific logic in a few helper functions that we override for each subclass, so we only really need to decorate those, e.g.,

```
def conditional_skip(condition, reason=''):
    def wrapped(*args, **kwargs):
        if condition:
            raise unittest.SkipTest(reason)
        return wrapped(*args, **kwargs)
    return wrapped

class NetCDFSubclassTest(UnitTest):
    ...
    @contextmanager
    @conditional_skip(...)
    def roundtrip(self):
        ...
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811
https://github.com/pydata/xarray/pull/1557#issuecomment-327886446,https://api.github.com/repos/pydata/xarray/issues/1557,327886446,MDEyOklzc3VlQ29tbWVudDMyNzg4NjQ0Ng==,2443309,2017-09-07T18:34:48Z,2017-09-07T18:34:48Z,MEMBER,"> Maybe it's worth trying the work-around from pytest-dev/pytest#568 (comment)

This gets us quite close but doesn't allow us to have use multiple decorators at once. I'll keep digging.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811
https://github.com/pydata/xarray/pull/1557#issuecomment-327875587,https://api.github.com/repos/pydata/xarray/issues/1557,327875587,MDEyOklzc3VlQ29tbWVudDMyNzg3NTU4Nw==,1217238,2017-09-07T17:54:38Z,2017-09-07T17:54:38Z,MEMBER,Maybe it's worth trying the work-around from https://github.com/pytest-dev/pytest/issues/568#issuecomment-216569420,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811
https://github.com/pydata/xarray/pull/1557#issuecomment-327812648,https://api.github.com/repos/pydata/xarray/issues/1557,327812648,MDEyOklzc3VlQ29tbWVudDMyNzgxMjY0OA==,2443309,2017-09-07T14:15:00Z,2017-09-07T14:16:17Z,MEMBER,"> What about the other @requires class decorators?

I had this thought too. We don't decorate too many classes but I image we have other issues.

> I wonder if this propagation to parent classes is a feature or a bug?

I would think this is a bug. I'm working on a simplified example to report this to pytest.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811
https://github.com/pydata/xarray/pull/1557#issuecomment-327805477,https://api.github.com/repos/pydata/xarray/issues/1557,327805477,MDEyOklzc3VlQ29tbWVudDMyNzgwNTQ3Nw==,10050469,2017-09-07T13:50:48Z,2017-09-07T13:50:48Z,MEMBER,I wonder if this propagation to parent classes is a feature or a bug? Seems quite messy to me,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,255813811