html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1551#issuecomment-335284154,https://api.github.com/repos/pydata/xarray/issues/1551,335284154,MDEyOklzc3VlQ29tbWVudDMzNTI4NDE1NA==,6213168,2017-10-09T20:52:56Z,2017-10-09T20:52:56Z,MEMBER,@shoyer ready for merge,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785
https://github.com/pydata/xarray/pull/1551#issuecomment-334860796,https://api.github.com/repos/pydata/xarray/issues/1551,334860796,MDEyOklzc3VlQ29tbWVudDMzNDg2MDc5Ng==,6213168,2017-10-06T20:23:57Z,2017-10-06T20:23:57Z,MEMBER,@shoyer ready to merge if there's no outstanding critiques,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785
https://github.com/pydata/xarray/pull/1551#issuecomment-331727598,https://api.github.com/repos/pydata/xarray/issues/1551,331727598,MDEyOklzc3VlQ29tbWVudDMzMTcyNzU5OA==,6213168,2017-09-24T18:00:26Z,2017-09-24T18:00:26Z,MEMBER,Should be ready to be merged immediately after #1589 and #1590,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785
https://github.com/pydata/xarray/pull/1551#issuecomment-331723088,https://api.github.com/repos/pydata/xarray/issues/1551,331723088,MDEyOklzc3VlQ29tbWVudDMzMTcyMzA4OA==,6213168,2017-09-24T16:51:28Z,2017-09-24T16:51:28Z,MEMBER,"Finished. One more test failure, as it now triggers #1588 too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785
https://github.com/pydata/xarray/pull/1551#issuecomment-331560071,https://api.github.com/repos/pydata/xarray/issues/1551,331560071,MDEyOklzc3VlQ29tbWVudDMzMTU2MDA3MQ==,6213168,2017-09-22T21:03:44Z,2017-09-22T21:03:44Z,MEMBER,"New, much better version.
There's one test failure but that's actually because now it triggers #1586.
combine.py should be final; need to add more unit tests.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785
https://github.com/pydata/xarray/pull/1551#issuecomment-327512728,https://api.github.com/repos/pydata/xarray/issues/1551,327512728,MDEyOklzc3VlQ29tbWVudDMyNzUxMjcyOA==,1197350,2017-09-06T15:04:00Z,2017-09-06T15:04:00Z,MEMBER,I think this should help with #1385.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785
https://github.com/pydata/xarray/pull/1551#issuecomment-327005863,https://api.github.com/repos/pydata/xarray/issues/1551,327005863,MDEyOklzc3VlQ29tbWVudDMyNzAwNTg2Mw==,1217238,2017-09-04T17:28:56Z,2017-09-04T17:28:56Z,MEMBER,"Yeah, that's OK, I just liked your TODO :)

On Mon, Sep 4, 2017 at 1:33 AM crusaderky <notifications@github.com> wrote:

> *@crusaderky* commented on this pull request.
> ------------------------------
>
> In xarray/core/combine.py
> <https://github.com/pydata/xarray/pull/1551#discussion_r136769128>:
>
> > @@ -208,6 +219,8 @@ def _dataset_concat(datasets, dim, data_vars, coords, compat, positions):
>      dim, coord = _calc_concat_dim_coord(dim)
>      datasets = [as_dataset(ds) for ds in datasets]
>      datasets = align(*datasets, join='outer', copy=False, exclude=[dim])
> +    # TODO: compute dask coords with a single invocation of dask.compute()
>
> I didn't bother as it would be a considerable complication and it would
> not do any good in the most common case where the ""dask"" variable is just a
> lazy load from disk
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/1551#discussion_r136769128>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1kdcqAVVgdHoOZGKBf-IuFBdVJWbks5se7XugaJpZM4PLCZy>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,254841785