html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/1524#issuecomment-324607199,https://api.github.com/repos/pydata/xarray/issues/1524,324607199,MDEyOklzc3VlQ29tbWVudDMyNDYwNzE5OQ==,1197350,2017-08-24T11:18:34Z,2017-08-24T11:18:34Z,MEMBER,"Dask implements percentile now
http://dask.pydata.org/en/latest/array-api.html#dask.array.percentile
So perhaps our version of quantile can be refactored to accommodate actual lazy computation on dask arrays, rather than simply erroring.
In any case, I agree that automatic silent eager evaluation of dask arrays is bad.
Sent from my iPhone
> On Aug 24, 2017, at 11:54 AM, crusaderky wrote:
>
> In variable.py, line 1116, you're missing a raise statement:
>
> if isinstance(self.data, dask_array_type):
> TypeError(""quantile does not work for arrays stored as dask ""
> ""arrays. Load the data via .compute() or .load() prior ""
> ""to calling this method."")
> Currently looking into extending dask.percentile() to support more than 1D arrays, and then use it in xarray too.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,252548859