html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1451#issuecomment-867456954,https://api.github.com/repos/pydata/xarray/issues/1451,867456954,MDEyOklzc3VlQ29tbWVudDg2NzQ1Njk1NA==,14808389,2021-06-24T08:45:18Z,2021-06-24T08:45:18Z,MEMBER,"@mathause, this has been unintentionally closed while renaming the `main` branch. Feel free to reopen (you'd probably have to restore the branch on your repo first) if you think this is still valuable.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564 https://github.com/pydata/xarray/pull/1451#issuecomment-854177478,https://api.github.com/repos/pydata/xarray/issues/1451,854177478,MDEyOklzc3VlQ29tbWVudDg1NDE3NzQ3OA==,26384082,2021-06-03T21:02:32Z,2021-06-03T21:02:32Z,NONE,"In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here or remove the `stale` label; otherwise it will be marked as closed automatically ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564 https://github.com/pydata/xarray/pull/1451#issuecomment-494446221,https://api.github.com/repos/pydata/xarray/issues/1451,494446221,MDEyOklzc3VlQ29tbWVudDQ5NDQ0NjIyMQ==,10194086,2019-05-21T15:42:37Z,2019-05-21T15:42:37Z,MEMBER,"Ok, I just had a look & things still look pretty much the same. Not sure if/ when I find time to do this,","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564 https://github.com/pydata/xarray/pull/1451#issuecomment-493124795,https://api.github.com/repos/pydata/xarray/issues/1451,493124795,MDEyOklzc3VlQ29tbWVudDQ5MzEyNDc5NQ==,10194086,2019-05-16T15:51:06Z,2019-05-16T15:51:06Z,MEMBER,I have a feeling that there where quite some changes to this part of the code (but I'm not sure) - so I'd have to look into it first.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564 https://github.com/pydata/xarray/pull/1451#issuecomment-493109114,https://api.github.com/repos/pydata/xarray/issues/1451,493109114,MDEyOklzc3VlQ29tbWVudDQ5MzEwOTExNA==,2448579,2019-05-16T15:11:55Z,2019-05-16T15:11:55Z,MEMBER,@mathause can you pick this up again? It looks like it's pretty close.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564 https://github.com/pydata/xarray/pull/1451#issuecomment-493084585,https://api.github.com/repos/pydata/xarray/issues/1451,493084585,MDEyOklzc3VlQ29tbWVudDQ5MzA4NDU4NQ==,26384082,2019-05-16T14:12:40Z,2019-05-16T14:12:40Z,NONE,"In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here or remove the `stale` label; otherwise it will be marked as closed automatically ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564 https://github.com/pydata/xarray/pull/1451#issuecomment-308734219,https://api.github.com/repos/pydata/xarray/issues/1451,308734219,MDEyOklzc3VlQ29tbWVudDMwODczNDIxOQ==,10194086,2017-06-15T13:48:13Z,2017-06-15T13:48:13Z,MEMBER,"I tried to dig a bit into this... The reason behind `_cleanup_netcdf_time_units` is to clean up things as `u'Hour␣␣since 1680-01-01 00:00:00'` (double space). However, it does not correct for the case (e.g. daYs remains daYs). Also, the clean up is not [tested](https://github.com/pydata/xarray/blob/master/xarray/tests/test_conventions.py#L130). This seems to be a reasonable thing to do, but, as mentioned the ref_date is changed, too. Thus we have to decide if * we want to keep the cleaning of the ""Hour since"" part, and if the case should be corrected as well (daYs). If yes potentially add tests. * the user-defined ref_date string (e.g. 2015-01-01) should be changed (I would say no). And if no, if it needs a sanity check or if pd.Timestamp(ref_date) does the sanity check for us. In the [CF conventions](http://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html#time-coordinate) they refer to the udunits library. And, as mentioned, provide examples without ""T"". But this seems to be the standard in udunits, version 1. While in the [udunits, version 2](http://www.unidata.ucar.edu/software/udunits/udunits-2.2.25/doc/udunits/udunits2lib.html#UDUNITS-Library), the timestamp format includes ""T"". TIMSTAMP: ` ( ?)? ""T"" ( ?)?` But udunits2 also mentions that it should be able to parse all formats of udunits1. So leaving out the ""T"" seems to be the safer option.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,235542564